Re: [PATCH] fdo#39468: translate German comments (= filter/inc/filter/msfilter/msdffimp.hxx) plus questions
Hi there, On Sat, 2012-06-23 at 20:45 +0200, Philipp Riemer wrote: (1) Since it was addressed on the mailing list today (see http://lists.freedesktop.org/archives/libreoffice/2012-June/034038.html) I spent some time on filter/inc/filter/msfilter/msdffimp.hxx. Thanks for this set; (2) In addition, I was wondering if it would be possible to shorten parameters (e.g. com::sun::star::uno::Reference com::sun::star::embed::XStorage xDestStg) by using aliases or other ways to point to that namespaces. But I am not skilled enough in C++ to do that (see e.g. patch 0003 for examples). The great hope is LibreOffice 4 - which will discard the com::sun::star prefix and/or do something sensible instead here, making our APIs much easier to read. There was also hope for a transitional set of namespace aliases, but I forget why that was shot down, in the meantime we have that ugly, tangled madness (sadly) :-) (3) Moreover, the forward declarations and #define blocks are widely spread over the whole file. Can I rearrange these so that they are all bundled at the top of this file? In my eyes this would make it more readable plus provide all needed classes and definitions on one or two screen pages. Sounds good to me; as long as it's not some scripted thing across the whole code-base (yet) ;-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#39468: translate German comments (= filter/inc/filter/msfilter/msdffimp.hxx) plus questions
On 2012-06-25 15:32, Michael Meeks wrote:
On Sat, 2012-06-23 at 20:45 +0200, Philipp Riemer wrote:
(2) In addition, I was wondering if it would be possible to shorten
parameters (e.g. com::sun::star::uno::Reference
com::sun::star::embed::XStorage xDestStg) by using aliases or
other ways to point to that namespaces. But I am not skilled enough in
C++ to do that (see e.g. patch 0003 for examples).
The great hope is LibreOffice 4 - which will discard the com::sun::star
prefix and/or do something sensible instead here, making our APIs much
easier to read.
There was also hope for a transitional set of namespace aliases, but I
forget why that was shot down, in the meantime we have that ugly,
tangled madness (sadly) :-)
Perhaps we could adopt a transitional scheme, where we move our types
and definitions to a new namespace, but leave aliases in the current
namespace?
i.e. in pseudo-code:
namespace shiny
{
class Reference . yada yada.
}
namespace com.sun.star.uno
{
typedef ::shiny::Reference Reference;
}
Does that sound reasonable (have no real idea, given my lack of C++
experience).
Disclaimer: http://www.peralex.com/disclaimer.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#39468: translate German comments (= filter/inc/filter/msfilter/msdffimp.hxx) plus questions
2012/6/25 Noel Grandin n...@peralex.com:
On 2012-06-25 15:32, Michael Meeks wrote:
On Sat, 2012-06-23 at 20:45 +0200, Philipp Riemer wrote:
(2) In addition, I was wondering if it would be possible to shorten
parameters (e.g. com::sun::star::uno::Reference
com::sun::star::embed::XStorage xDestStg) by using aliases or
other ways to point to that namespaces. But I am not skilled enough in
C++ to do that (see e.g. patch 0003 for examples).
The great hope is LibreOffice 4 - which will discard the
com::sun::star
prefix and/or do something sensible instead here, making our APIs much
easier to read.
There was also hope for a transitional set of namespace aliases,
but I
forget why that was shot down, in the meantime we have that ugly,
tangled madness (sadly) :-)
Perhaps we could adopt a transitional scheme, where we move our types and
definitions to a new namespace, but leave aliases in the current namespace?
i.e. in pseudo-code:
namespace shiny
{
class Reference . yada yada.
}
namespace com.sun.star.uno
{
typedef ::shiny::Reference Reference;
}
Does that sound reasonable (have no real idea, given my lack of C++
experience).
Correct me if I am wrong, but I think that exact step was proposed and
also rejected after discussion a few weeks ago.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
