Re: [PATCH] fdo#64455 Add default line color to standard.soc
Hello Ivan, Ivan Timofeev wrote And then, how about fixing the line color listbox, so that it will show unknown colors like the fill color listbox does? Then we can backport that fix to 4-1 and 4-0 without introducing a new UI string. Do you want to look at that? It's SvxLineColorToolBoxControl[2] and IIRC the StateChanged method is called on a color update. That sounds interesting for me. Thanks for the links. :) I will have a look at it in the next few days. - LibreOffice 3.6.7 -- View this message in context: http://nabble.documentfoundation.org/PATCH-fdo-64455-Add-default-line-color-to-standard-soc-tp4071038p4071531.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#64455 Add default line color to standard.soc
Hi Laurent, On 22.08.2013 12:02, Laurent BP wrote: The default line color is #3465af which is not present in any palette. Weird. :) It's even not a tango color[1]. I'd change the default to Tango: Sky Blue 2 (#3465a4) and recommit http://cgit.freedesktop.org/libreoffice/core/commit/?id=b9c98414ec9084cf97b5dcc911fb9941b5e57ebb Added Tango colors to palette which was reverted for some reason... Commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=895890563cb0cc5fa872bdfd06918a46cdda172d Change default shape color shows where the defaults are hiding. :) I propose to add it to standard.soc. And then, how about fixing the line color listbox, so that it will show unknown colors like the fill color listbox does? Then we can backport that fix to 4-1 and 4-0 without introducing a new UI string. Do you want to look at that? It's SvxLineColorToolBoxControl[2] and IIRC the StateChanged method is called on a color update. [1] http://cgit.freedesktop.org/libreoffice/core/tree/extras/source/palettes/tango.soc [2] http://opengrok.libreoffice.org/search?q=project=coredefs=SvxLineColorToolBoxControlrefs=path=hist= Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#64455 Add default line color to standard.soc
Hi, The default line color is #3465af which is not present in any palette. I propose to add it to standard.soc. 0001-fdo-64455-Add-default-line-color-to-standard.soc.patch http://nabble.documentfoundation.org/file/n4071038/0001-fdo-64455-Add-default-line-color-to-standard.soc.patch - LibreOffice 3.6.7 -- View this message in context: http://nabble.documentfoundation.org/PATCH-fdo-64455-Add-default-line-color-to-standard-soc-tp4071038.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
