Re: [PATCH]BUG#57950 Replace chained O(U)StringBuffer::append() with operator+

2013-04-10 Thread Janit Anjaria
Hey! I aam sure the mentor at that point in time initially when i started my work on the LO codebase...he asked me to do the same ,and that is why i made the following changes But yeah if you still feel i need to change the patch according with the buffer thing resolved,ill do it and mail it

Re: [PATCH]BUG#57950 Replace chained O(U)StringBuffer::append() with operator+

2013-04-09 Thread Janit Anjaria
Hey! I am hereby attaching my patch on fdo#57950 where the .append() calls are replaced by + operator. Regards, Janit On Tue, Apr 9, 2013 at 7:00 PM, Janit Anjaria jani...@gmail.com wrote: Hey Thorsten! As a mentor it would be great if you review my bug and tell me if i need to further

[PATCH]BUG#57950 Replace chained O(U)StringBuffer::append() with operator+

2013-04-08 Thread Janit Anjaria
Hey! I am hereby submitting my patch for review on the bug/feature which i had worked long back which replaces all the .append() calls witha + operator. Regards, Janit 0001-fdo-57950-replace-chained-O-U-StringBuffer-append-wi.patch Description: Binary data

Re: [PATCH]BUG#57950 Replace chained O(U)StringBuffer::append() with operator+

2013-04-08 Thread Thorsten Behrens
Janit Anjaria wrote: I am hereby submitting my patch for review on the bug/feature which i had worked long back which replaces all the .append() calls witha + operator. Hi Janit, thanks for that patch - it needs some cleanup, too, though. String literals can be appended without explicit

Re: [PATCH]BUG#57950 Replace chained O(U)StringBuffer::append() with operator+

2013-04-08 Thread Janit Anjaria
Hey Thorsten, I am not pretty sure how can that be possible but yes i would clean the patch up and then mail it . Regards, Janit On Tue, Apr 9, 2013 at 4:02 AM, Thorsten Behrens t...@documentfoundation.org wrote: Janit Anjaria wrote: I am hereby submitting my patch for review on the