Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

2013-09-17 Thread Laurent BP
> > De : Ivan Timofeev [via Document Foundation Mail Archive] > >À : Laurent BP >Envoyé le : Mardi 17 septembre 2013 17h08 >Objet : Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color >line toolbox > > > &g

Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

2013-09-17 Thread Ivan Timofeev
On 17.09.2013 17:37, Laurent BP [via Document Foundation Mail Archive] wrote: > Moreover, I realized afterwards it may be better to use OUString than > String? I saw many patches proposing to replace String by OUString. Yes, OUString should be used in new code instead of String. You can help with

Re: [PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

2013-09-17 Thread Laurent BP
Hi Ivan, Thanks for this good news. I was wondering if I could use the same code as for Fill toolbox, but I did not understand all the links between classes. So I duplicate the code. Moreover, I realized afterwards it may be better to use OUString than String? I saw many patches proposing to repl

[PUSHED: master,4-1,4-0] fdo#64455 Handle unknown color in color line toolbox

2013-09-17 Thread Ivan Timofeev
Hi Laurent, Thanks, I fixed the indentation and pushed it. Sadly I forgot to amend the author while pushing to 4-1 and stole your commit :( sorry for that. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedes