On Wed, Nov 28, 2012 at 1:13 PM, Miklos Vajna vmik...@suse.cz wrote:
Also, I had to fix the helpcontent2 build after your patch, did you
at least build-test your patch? If not, please always do so (along with
runtime testing if possible) before submitting it to gerrit.
Sorry for the trouble.
Hi Muhammad,
On Thu, Nov 29, 2012 at 05:27:32PM +0200, Muhammad Haggag mhag...@gmail.com
wrote:
Sorry for the trouble. I build and test patches before pushing them. I
did verify that this one built and ran, and that the help content is
showing up correctly. I just double-checked on my
Hmm. At first I thought maybe sc help contents were building fine for
me because they're being skipped (i.e. they're unchanged), but make
helpcontent2.clean make helpcontent2 still succeeds. Perhaps we
have different versions of the tools used to build/compile help?
In any case, I'll keep the
Hi Muhammad,
On Tue, Nov 27, 2012 at 04:08:26PM +0200, Muhammad Haggag mhag...@gmail.com
wrote:
https://gerrit.libreoffice.org/#/c/1163/
Cédric pushed this one as well, marking as such.
Also, I had to fix the helpcontent2 build after your patch, did you
at least build-test your patch? If not,
