Re: [REVIEW][3.5]fdo#46531, spell checking display fun

2012-03-08 Thread Caolán McNamara
On Tue, 2012-02-28 at 14:13 +, Michael Meeks wrote: On Tue, 2012-02-28 at 12:26 +, Caolán McNamara wrote: Dialog is fragile and tricky :-( So - given that the dialog was moved to cui, is not public, and has only one constructor in the factory method - would something like the

Re: [REVIEW][3.5]fdo#46531, spell checking display fun

2012-03-08 Thread Michael Meeks
On Thu, 2012-03-08 at 14:32 +, Caolán McNamara wrote: Nah, I recall some more of the details now. The virtual methods that are a problem are those of SpellDialogChildWindow. Your patch call Ah - hideous :-) so we'd want to expose that late init via the abstract dialog factory, and

Re: [REVIEW][3.5]fdo#46531, spell checking display fun

2012-02-28 Thread Caolán McNamara
On Mon, 2012-02-27 at 17:07 +0100, Cedric Bosdonnat wrote: Hello people, Could someone review and cherry-pick -s this commit into -3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872 FWIW, the nastiness in that SpellDialog is that

Re: [REVIEW][3.5]fdo#46531, spell checking display fun

2012-02-28 Thread Michael Meeks
On Tue, 2012-02-28 at 12:26 +, Caolán McNamara wrote: FWIW, the nastiness in that SpellDialog is that there are a bunch of things which would be natural to put directly into the ctor, but they would require calling virtual methods during construction, which doesn't work in c++, so there's

[REVIEW][3.5]fdo#46531, spell checking display fun

2012-02-27 Thread Cedric Bosdonnat
Hello people, Could someone review and cherry-pick -s this commit into -3-5 branch? http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872 Thanks, -- Cedric ___ LibreOffice mailing list