Re: About liststore in areatabpage.ui (cui module)

2015-08-28 Thread Caolán McNamara
On Wed, 2015-08-26 at 22:52 -0700, julien2412 wrote:
 Hello,
 
 By giving a try to tdf#31488 (pptx import: blue background, 
 save/reopen as
 .odp changes to gray), I noticed that each value of liststore 
 LB_AREA_TYPE
 was at 0, see
 http://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/areatabpage
 .ui#23
 Comparing with other liststore, I wonder if it's correct or not.

Checking the original conversion of
 ad0c6359dc044c659160a6a51c1647607c58979a the original src also had the
same Default id for all None to Bitmap entries, so the value there of
0 is correct from that context. Sometimes the code uses the ids and
sometimes the code uses the positions.

Checking that commit show that GetSelectEntryPos/SelectEntryPos are the
things used here and nothing that uses the ids. So all is well in the
.ui file apparently.

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


About liststore in areatabpage.ui (cui module)

2015-08-26 Thread julien2412
Hello,

By giving a try to tdf#31488 (pptx import: blue background, save/reopen as
.odp changes to gray), I noticed that each value of liststore LB_AREA_TYPE
was at 0, see
http://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/areatabpage.ui#23
Comparing with other liststore, I wonder if it's correct or not.

(Indeed, I thought first it could explain why Gradient was selected when
opening format slide (the only one) of the attachment of tdf#31488 whereas
it's a solid color. It's only in a second time, I noticed that
FillPropertiesContext::createFillContext was called several times (sometimes
with noFill, sometimes with solidFill and also with gradFill) whereas
there's only 1 background.))

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/About-liststore-in-areatabpage-ui-cui-module-tp4158438.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice