Re: Fishy assignment in editdoc (editeng) ?

2019-05-27 Thread Malte Timmermann
For editdoc.cxx: == op compares the individual members of the font if the impl pointer is not equal. If all members are the same, the strange assignment makes sure that both also point to the same internal instance of the font. If you want to avoid that strange assignment, you would need to

Re: Fishy assignment in editdoc (editeng) ?

2019-05-27 Thread Stephan Bergmann
On 26/05/2019 21:24, julien2412 wrote: Taking a look to the new reports generated by Cppcheck, I noticed "duplicateConditionalAssign" and specifically this code: 2028 // If comparing the entire font, or if checking before each alteration 2029 // whether the value changes, remains

Fishy assignment in editdoc (editeng) ?

2019-05-26 Thread julien2412
Hello, Taking a look to the new reports generated by Cppcheck, I noticed "duplicateConditionalAssign" and specifically this code: 2028 // If comparing the entire font, or if checking before each alteration 2029 // whether the value changes, remains relatively the same thing. 2030