Re: Hi-DPI patches for 4.2

2014-03-12 Thread Jan Holesovsky
Hi Norbert, Norbert Thiebaud píše v Út 11. 03. 2014 v 19:29 -0500: then the simplest way disable these patches on the Mac is to just force mnDPIScaleFactor to 1. In that case, these patches would behave as it does on 4.2.1. yep, that does that indeed. pushed

Re: Hi-DPI patches for 4.2

2014-03-12 Thread Jan Holesovsky
Hi Keith, Keith Curtis píše v St 12. 03. 2014 v 13:44 -0400: Who is going to do this? I've just pushed that as https://gerrit.libreoffice.org/8560 All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Stefan Knorr
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, On 10/03/14 22:51, Keith Curtis wrote: Doubling bitmaps is a hack but since bigger bitmaps don't exist, it is better than doing nothing. I haven't looked into the low-level resource loading code, but there are very probably VCL changes

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Khaled Hosny
On Tue, Mar 11, 2014 at 10:33:13AM +0100, Stefan Knorr wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, On 10/03/14 22:51, Keith Curtis wrote: Doubling bitmaps is a hack but since bigger bitmaps don't exist, it is better than doing nothing. I haven't looked into the

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Norbert Thiebaud
On Tue, Mar 11, 2014 at 3:53 AM, Keith Curtis keit...@gmail.com wrote: That picture is bizarre in that the gridlines drawn by Calc are not being doubled. Have you fiddled with the OS DPI stuff? The grid lines are not bitmap, they are vector drawing... but more importantly... _WITH_ the

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Keith Curtis
On Tue, Mar 11, 2014 at 4:57 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Tue, Mar 11, 2014 at 3:53 AM, Keith Curtis keit...@gmail.com wrote: That picture is bizarre in that the gridlines drawn by Calc are not being doubled. Have you fiddled with the OS DPI stuff? The grid lines are

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Keith Curtis
Well, the rabbit hole gets deeper. Norbert, it now seems to me that there isn't something wrong with your build, but with your OS!?! Here is a screenshot of the current released build on Retina for comparison:

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Norbert Thiebaud
On Tue, Mar 11, 2014 at 2:32 PM, Keith Curtis keit...@gmail.com wrote: then the simplest way disable these patches on the Mac is to just force mnDPIScaleFactor to 1. In that case, these patches would behave as it does on 4.2.1. yep, that does that indeed. pushed

Re: Hi-DPI patches for 4.2

2014-03-11 Thread Norbert Thiebaud
for info here is teh different DPI reported by vcl for the same 13'' screen at different display setting n_th@Norberts-MacBook-Pro /lo/core$ ./instdir/LibreOfficeDev.app/Contents/MacOS/soffice 2014-03-11 19:39:44.065 soffice[270:507] final mnRealDPIX = 91 mnRealDPIY = 91 n_th@Norberts-MacBook-Pro

Hi-DPI patches for 4.2

2014-03-10 Thread Jan Holesovsky
Hi Caolán, all, I've just pushed a backport of the hi-dpi patches from master to gerrit for libreoffice-4-2 integration - as was requested earlier, to fix the unfortunate state of LibreOffice on the hi-dpi displays. It is the following 5 patches (order is important):

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Norbert Thiebaud
On Mon, Mar 10, 2014 at 1:24 PM, Jan Holesovsky ke...@collabora.com wrote: Hi Caolán, all, It is only 5 patches, as I have squashed the follow-up fixes into the appropriate patches, but other than that, it should bring us to the very same state that is in master. Not quite.. I had to add a

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Norbert Thiebaud
On Mon, Mar 10, 2014 at 2:11 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Mon, Mar 10, 2014 at 1:24 PM, Jan Holesovsky ke...@collabora.com wrote: Hi Caolán, all, It is only 5 patches, as I have squashed the follow-up fixes into the appropriate patches, but other than that, it should

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Jan Holesovsky
Hi Norbert, Norbert Thiebaud píše v Po 10. 03. 2014 v 14:11 -0500: It is only 5 patches, as I have squashed the follow-up fixes into the appropriate patches, but other than that, it should bring us to the very same state that is in master. Not quite.. I had to add a bunch of #ifndef

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Norbert Thiebaud
On Mon, Mar 10, 2014 at 2:32 PM, Jan Holesovsky ke...@collabora.com wrote: Hi Norbert, Norbert Thiebaud píše v Po 10. 03. 2014 v 14:11 -0500: It is only 5 patches, as I have squashed the follow-up fixes into the appropriate patches, but other than that, it should bring us to the very

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Keith Curtis
Perhaps it would be good to have Norbert double-check his work, but it seems logical the later changes aren't necessary without his first retina change to turn off auto-doubling mode, which is not a part of this set. Norbert is still in the investigation phase, and there are multiple ways to

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Norbert Thiebaud
On Mon, Mar 10, 2014 at 4:51 PM, Keith Curtis keit...@gmail.com wrote: Doubling bitmaps is a hack but since bigger bitmaps don't exist, it is better than doing nothing. The problem is that mac, in compatibility mode, already auto-double.. so we end-up with a quadrupling of the bitmap, which

Re: Hi-DPI patches for 4.2

2014-03-10 Thread Keith Curtis
On Mon, Mar 10, 2014 at 7:15 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Mon, Mar 10, 2014 at 4:51 PM, Keith Curtis keit...@gmail.com wrote: Doubling bitmaps is a hack but since bigger bitmaps don't exist, it is better than doing nothing. The problem is that mac, in compatibility mode,