Re: OpenDocument spec tables row height [was: Writer - row-height, min-row-height and use-optimal-row-height]
For what it's worth as I am no sw expert, I'd say do the commit. It isn't like there is a real chance of an interoperability problem, AFAIK only other implementation is AOO. so... What could possibly go wrong? On Sat, Sep 29, 2018 at 4:51 PM Lionel Elie Mamane wrote: > In the absence of feedback from sw people, we just commit the change? > > On Thu, Jul 26, 2018 at 03:10:37PM +0200, Lionel Elie Mamane wrote: > > Anybody? > > > > On Sun, Jun 17, 2018 at 11:48:49AM +0200, Lionel Elie Mamane wrote: > > > Hi, > > > > > > The Base report builder produces Writer (odt) documents directly (it > > > spits out XML, not using Writer to produce it), and then opens them in > > > Writer. It uses tables heavily. > > > > > > In the context of > > > https://bugs.documentfoundation.org/show_bug.cgi?id=45789 > > > https://gerrit.libreoffice.org/53977 > > > Ilhan prepared a patch to make Report Builder mark some rows of some > > > tables as "fit to size" in row height. By reading the OpenDocument > > > specification, I thought this would happen by setting the > > > style:use-optimal-row-height attribute on the row. However, it turns > > > out that Ilhan had to change some sw code for that to work, and that > > > made me suspicious whether that was the right thing to do. > > > > > > I looked into the XML generated by Writer with "Fit to Size" enabled > > > and disabled, and apparently that checkbox in writer replaces > > > "style:row-height" by "style:min-row-height, and > > > style:use-optimal-row-height is nowhere to be seen. > > > > > > Could a Writer expert please look at the sw changes in > > > https://gerrit.libreoffice.org/53977 > > > and let us know whether these changes are right or wrong with respect > > > to OpenDocument? Is style:use-optimal-row-height supposed to override > > > style:row-height or vice-versa? > > > > > > Thanks in advance, > > > > > ___ > > LibreOffice mailing list > > LibreOffice@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: OpenDocument spec tables row height [was: Writer - row-height, min-row-height and use-optimal-row-height]
In the absence of feedback from sw people, we just commit the change? On Thu, Jul 26, 2018 at 03:10:37PM +0200, Lionel Elie Mamane wrote: > Anybody? > > On Sun, Jun 17, 2018 at 11:48:49AM +0200, Lionel Elie Mamane wrote: > > Hi, > > > > The Base report builder produces Writer (odt) documents directly (it > > spits out XML, not using Writer to produce it), and then opens them in > > Writer. It uses tables heavily. > > > > In the context of > > https://bugs.documentfoundation.org/show_bug.cgi?id=45789 > > https://gerrit.libreoffice.org/53977 > > Ilhan prepared a patch to make Report Builder mark some rows of some > > tables as "fit to size" in row height. By reading the OpenDocument > > specification, I thought this would happen by setting the > > style:use-optimal-row-height attribute on the row. However, it turns > > out that Ilhan had to change some sw code for that to work, and that > > made me suspicious whether that was the right thing to do. > > > > I looked into the XML generated by Writer with "Fit to Size" enabled > > and disabled, and apparently that checkbox in writer replaces > > "style:row-height" by "style:min-row-height, and > > style:use-optimal-row-height is nowhere to be seen. > > > > Could a Writer expert please look at the sw changes in > > https://gerrit.libreoffice.org/53977 > > and let us know whether these changes are right or wrong with respect > > to OpenDocument? Is style:use-optimal-row-height supposed to override > > style:row-height or vice-versa? > > > > Thanks in advance, > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
OpenDocument spec tables row height [was: Writer - row-height, min-row-height and use-optimal-row-height]
Anybody? On Sun, Jun 17, 2018 at 11:48:49AM +0200, Lionel Elie Mamane wrote: > Hi, > > The Base report builder produces Writer (odt) documents directly (it > spits out XML, not using Writer to produce it), and then opens them in > Writer. It uses tables heavily. > > In the context of > https://bugs.documentfoundation.org/show_bug.cgi?id=45789 > https://gerrit.libreoffice.org/53977 > Ilhan prepared a patch to make Report Builder mark some rows of some > tables as "fit to size" in row height. By reading the OpenDocument > specification, I thought this would happen by setting the > style:use-optimal-row-height attribute on the row. However, it turns > out that Ilhan had to change some sw code for that to work, and that > made me suspicious whether that was the right thing to do. > > I looked into the XML generated by Writer with "Fit to Size" enabled > and disabled, and apparently that checkbox in writer replaces > "style:row-height" by "style:min-row-height, and > style:use-optimal-row-height is nowhere to be seen. > > Could a Writer expert please look at the sw changes in > https://gerrit.libreoffice.org/53977 > and let us know whether these changes are right or wrong with respect > to OpenDocument? Is style:use-optimal-row-height supposed to override > style:row-height or vice-versa? > > Thanks in advance, > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
