Re: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-14 Thread Caolán McNamara
On Tue, 2012-03-13 at 16:25 +0100, Lionel Elie Mamane wrote:
 In the 3.5 biblio.odb, they are only hidden from view. Right click on
 any column header (title), choose show columns then all. If we
 want this to be the default, save that odb and commit it to git.

Doh, done, thanks.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


RE: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-13 Thread Winfried Donkers
  b) oddly base doesn't seem to PACK the dbase III files after
 editing, so deleted records still take up space in the file,
 possibly a bug worth fixing ?
 
 Do you have an idea of how to PACK a dbase III file? Is is already
 implemented in our code and we just need to add the function call or
 does that need to be added, too?

I used to work a lot with dBASE III files (quite some time ago) and I remember 
that delete and pack were two separate commands. Deleteing a record did not 
remove the record from the file, it merely placed an asterix in the (hidden) 
field for that record.
Pack was a command that was run to remove deleted records (using it for each 
delete was too time consuming).
So, historically, the behaviour under b) is not a bug.

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-13 Thread Caolán McNamara
On Tue, 2012-03-13 at 06:56 +0100, Lionel Elie Mamane wrote:
 On Fri, Mar 09, 2012 at 03:15:10PM +, Caolán McNamara wrote:
  a) oddly base doesn't show the same fields that the bibliography
 widget does, possibly a bug worth fixing ?
 
 Cannot immediately reproduce. Which field is visible in one, but not
 the other?

If I use in writer tools-bibliography database and also open biblio.odb
in base and click on Tables and then on biblio I get...

in the database view from writer: Identifier, Type, Address, Annotate,
Author, Booktitle, Chapter, Edition, Editor, Howpublish, Institutn,
Journal, Month, Note, Number, Organizat, Pages, Publisher, School,
Series, Title, RepType, Volume, Year, URL, Custom1, Custom2, Custom3,
Custom4, Custom5, ISBN

in base only: Identifier, Type, Address, Annotate, Author, Pages,
Publisher, Title, Year, ISBN

 Do you have an idea of how to PACK a dbase III file? Is is already
 implemented in our code and we just need to add the function call or
 does that need to be added, too?

I have no idea :-), so in that sense it's probably not suitable for an
easy-hack, at least not from me. Maybe in general there isn't a PACK
thing, just nomenclature for write out a copy of the database but just
don't include the deleted records. Current situation suggests that
people's Bibliography Databases can only ever grow in size.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-12 Thread Lionel Elie Mamane
On Fri, Mar 09, 2012 at 03:15:10PM +, Caolán McNamara wrote:

 Aha, now I understand the problem. Looking a bit closer, our biblio.odb
 *doesn't* embed the database inside the .odb, this is one of the .odbs
 which point to an external data source/sink. In this case it points to
 ~/.libreoffice/3/user/database/biblio/biblio.db[f|t] so whenever anyone
 edits it then only their local .dbf and .dbt files get their data
 changed :-)

 Documented a way to update the bibliography database that works with
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7de2ddf67158733ba15cea4cb8f1786e83776d9
  

 caolanm-lionel: might be worth having a look at the points a  b in
 that README, not sure if those are bugs or intentional behavior.

 a) oddly base doesn't show the same fields that the bibliography
widget does, possibly a bug worth fixing ?

Cannot immediately reproduce. Which field is visible in one, but not
the other?

 b) oddly base doesn't seem to PACK the dbase III files after
editing, so deleted records still take up space in the file,
possibly a bug worth fixing ?

Let's make it an easyhack. Put me in CC on it. It is not entirely
clear when we should pack it. After every change is too much
(performance-wise). When some threshold of space is wasted? When the
.odb file is closed? When the .odb file is saved (but then if only
data and no form / report / ... is changed, we never pack).

Do you have an idea of how to PACK a dbase III file? Is is already
implemented in our code and we just need to add the function call or
does that need to be added, too?

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Patch for Easy Hack 45033

2012-03-09 Thread Italo Vignoli
On 3/8/12 9:44 PM, Caolán McNamara wrote:

 Yeah it seems to still consist of OOo and StarOffice entries. Italio
 could you have another go at this. i.e. attaching a biblio.odb which has
 LibreOffice entries in it. I'd like to get this low-hanging fruit out of
 the way.

I have the proper document in my local copy of core, but I have not
pushed it (and will not do). I have compressed in the attached ZIP both
the local copy of biblio.odb and the same content copied into an ODS
file (just in case the ODB does not work).

-- 
Italo Vignoli - italo.vign...@gmail.com
mob +39.348.5653829 - VoIP 5316...@messagenet.it
skype italovignoli - gtalk italo.vign...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Patch for Easy Hack 45033

2012-03-09 Thread Caolán McNamara
On Fri, 2012-03-09 at 11:24 +0100, Italo Vignoli wrote:
 On 3/8/12 9:44 PM, Caolán McNamara wrote:
 
  Yeah it seems to still consist of OOo and StarOffice entries. Italio
  could you have another go at this. i.e. attaching a biblio.odb which has
  LibreOffice entries in it. I'd like to get this low-hanging fruit out of
  the way.
 
 I have the proper document in my local copy of core, but I have not
 pushed it (and will not do). I have compressed in the attached ZIP both
 the local copy of biblio.odb and the same content copied into an ODS
 file (just in case the ODB does not work).

Aha, now I understand the problem. Looking a bit closer, our biblio.odb
*doesn't* embed the database inside the .odb, this is one of the .odbs
which point to an external data source/sink. In this case it points to
~/.libreoffice/3/user/database/biblio/biblio.db[f|t] so whenever anyone
edits it then only their local .dbf and .dbt files get their data
changed :-)

So if the editors of the bibliography open the .odb then they see the
changes, but everyone else still sees the content of their original .dbt
file. Which is why Julien's efforts to update it got lost as well.

Documented a way to update the bibliography database that works with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7de2ddf67158733ba15cea4cb8f1786e83776d9
 
And took the attached .ods and updated the database from that. So job
done.

This will only affect users that don't already have a biblio.odb etc
installed, i.e. new-install users, existing users already have a copy of
the older versions installed in their user dir, which doesn't get
replaced.

caolanm-lionel: might be worth having a look at the points a  b in
that README, not sure if those are bugs or intentional behavior.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Patch for Easy Hack 45033

2012-03-08 Thread Caolán McNamara
On Mon, 2012-02-13 at 22:15 +0100, Rob Snelders wrote:
 Hi,
 
 Are you sure this is the correct file? When I open the file I only see 
 OpenOffice and StarOffice entries. Maybe someone else can check what 
 he/she sees.

Yeah it seems to still consist of OOo and StarOffice entries. Italio
could you have another go at this. i.e. attaching a biblio.odb which has
LibreOffice entries in it. I'd like to get this low-hanging fruit out of
the way.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Patch for Easy Hack 45033

2012-02-14 Thread Miklos Vajna
Hi Italo,

On Mon, Feb 13, 2012 at 12:27:26PM +0100, Italo Vignoli 
it...@italovignoli.com wrote:
 I have patched the biblio.odb document with LibreOffice entries (got rid
 of the old OOo entries). The patch is below to be checked, but I do not
 understand if I have to attach the patched document as well. Please
 help. Thanks, Italo
 
 
 ---
  extras/source/database/biblio.odb |  Bin 2796 - 2723 bytes
  1 files changed, 0 insertions(+), 0 deletions(-)
 
 diff --git a/extras/source/database/biblio.odb
 b/extras/source/database/biblio.odb

Just for the reference, the problem here is that the last two line would
have to be in a single line (whitespace mangled). The best way to avoid
this is to just attach the file produced by git format-patch -1 to the
email.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Patch for Easy Hack 45033

2012-02-13 Thread Italo Vignoli
I have patched the biblio.odb document with LibreOffice entries (got rid
of the old OOo entries). The patch is below to be checked, but I do not
understand if I have to attach the patched document as well. Please
help. Thanks, Italo


---
 extras/source/database/biblio.odb |  Bin 2796 - 2723 bytes
 1 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/extras/source/database/biblio.odb
b/extras/source/database/biblio.odb
index
4e19692a7b3d8dee7988b4b873694e6de9640dda..0939bcb8b03bcf26f0550f79bbb0a73d507f2f8f
100644
GIT binary patch
delta 2036
zcmZWqc{tST7ysI3YzYxYk)0u1)6j?r$!{=(u}yUV#YEkOY^mpEfTV39T_)EC~FKM
z5mJ`945C7kArCJ1a#c^i?(hE2Kj%EocHs2-}64t`Fs{E5#%vPv#P06PHOs7C9i
z@ffpy^XVPXW9bZ4^}@@7cOq2p7}$DDAe?4_|W}q!Z_myx^)6wNdy4!g?=x}Q8
z#G+YT+_64li9Akw+KQGtz*nn3f{8eMP8myJlN~k-bg*mda6r|5x|?_32aAImT*S
zoqH!1E%^HG-|kl0-rnFzj?#EKGxb8+g)hHH{iP+GJE2sSL1!Tpl^3A6{AI{@uaV0m
zORYeRDI!BekZrs^p#X=8RZI1=g=c6r(y29o!Qit=$a{eZ}MWAw|%x!R?8y@AVAr
zG^1WPKiO}_?sl*Cs(_3POW(!RZ8w73s+++_pZOqx*pNh=Nfsu0ig-^v#V;@8%=t
z*}K8w{^AvyxCa{(@A`kBfTDAX6-f3tN#p)r;sk!55_Nai;Wwgi|rR;S;o7x5+tr
z2-pN$Udar-qTaKm8z8=QW75w(*bwXfoNT7JGOIQ4EG`HQYP6R0_xAbx~)TcLUkl
zQ0z_$?hh#)B~grc#0(9liWN=BQFc{YmZ#AObE#_SNkwC(-2#ZANt7P=AiGwaZ}F
zUQH$QYJ#iL3I};tX6c0!HVI+Sx{GexBfdDSPCR@vc8txmf0tlcq1Xgt*Wr3%LY)
zlg(8qKkaPEnlB1sr2z0-S9=4*05xF4#}0vAs{7FTtOa$lR{9WvRRLiJ3wSI@;Z
zE(=hEeFkcqxv*y8I8mS$wx-yJ}8JeJTa1b%eH)fUp)Daq)F%DrbmbRYKLW-je
z1iBG(JDWW=?fxwb6~d!7|M%!5sL8^D1G0K1zHYF_E|B}c=bOTI77u%GfU)tBya
zuCtK$)r%~C`PGV*%_H!L+bn{@T@upOOmnK8z_Ih`O5|e62|mpxwTZ^?SL0WFL*qC
zM*Go8jMYhLeA{mUX*H!L{s4;zoCE)(sjk=W(BN#4!s3%xW|ot8r-dzxnlWBX`$
z;Vr09kL0lc-Xv-om0hdCXI?56O4%p`b!ftd@H3eFYBnQL0XI??J-3sjSzG`x{j^Y
zXSi8cWj*Ff(a5_oFVK?pRo2?{+jL}KQu6$AL(kXyYXXHqt;cAomr?s=21R=
zNLZ5VZr+aqG4pTVUgv|mtIFpwj)EB#=`kC+*~FQZD)+0K2-1$acJ|hzDP7v7dLu
zmwR#dh)vF2`(@gXIhwM!esL4lZQS1;k(lx6Dy_s;tX$Zss56UbF;jbkG$uqt
z6lLK#v)iNlXJh!b@RQhfX#5;p4|waITZAT65uu{-^ot#Pp7PPI-^3MryH+k#Oik
z7`M?@_WPt+E2RN`zsyc)^X9?@L%pbGUm|pgn`m2?aYT8Jj`{q2Z92sEBjn3lSH)
z=Z!49?yWWhb#nfnIQ4|D@rxAmpt6q?fhy@*Ibp+=*=sIi8fY~vTq+Rwh1hA
ztY(`Q5R_xu_L|p26L)1BAm3un;qid^!$c6S?PrydY~1Hu64N$(Ynwi%qJN@^PD
z3Yc_?S;jW@B_@?ImHWp4f(X8*eYC_4bytLtaCZli8|c@;zSCBN4C{JsCT_lw3r5
zgv|aRdu7b%y2HR{`s%h4Ht{nm4a}-kit8-PIB}gzqYaq3AT~zPb^}si+)Xp2i|Y
z_0H)-)zw|OR*gtTO2d@C%IiSK86g!+9DK^DLJPZ|WzS39lOkW$7XK6PWiq)|abEn|
zCM(XbmwXPqfL3T3q#041QiM|ENSs?+04w2+TH}qOGNYFjQK8Hug;lRf}0RsNngZ
z4aR%y7K`0*vX;6GI2hH$RkylUtE}VW8ZH1jDHS4)0^SL4~U+mO?=xveamUGytkT*
zYWh`gnJRHs+R(nb44}9s}42wRc9pUE5zWrtxfBlSc!0MHTxfPZas2U+$5`@Y%J
z-$P}=G%BI%1b6J}EzalKH7kgsR5ADp#}laY^QF{yz1oW3pNijpOI``7s27cneoUC
z3O!b$*m12lu`Z3kW=@;PI#zdyUw|s8%-7l|@xUGG7t#d4~$jbeYa={ni;bh|
zHe-*%(J9$Z^Bo1WT0qmWE^i%1$9XpE3!caPlvs9F6%!7S#8{`I6P6=T~;OdX_D_n
zLx{W@lD2jy!~RpbE4R^D!+bA-`D3ACF0yUs*c1^)Y+l786Lqr1q!Qmk^V%MXKhO
zI?iYjPs3L3{~5f+^=%IAhSBf|005Mkzm0*3SpfJYYugVFZOH*Zx+I64|((9guzS?
zn%#Z;@kEtx2NxOz%01%KmP?KK=o}8h#FQ$VC^^q_w9fQ$RU|FSF~-GUSLgX9he
z3`=GL08LNy_3df7yirh6Xu^k$Mp;2AbNFh?5YnTzN@~d=u~ee;2gifH4O{)A1ZI
Zsh?o~e81rTfR(2|CKSV9!NX@{0*-qhxh;h

delta 2125
zcmZWqdoI19R9gvW2=ZEmz|I$_sf!+iEZwzM5fZ!Yq@Ujx+DirHdF5RvXAW44eY
zyls?A$YgSzl#*MiT*|9D?_1~X^UwElp7VU3pFTcoX?X7n}TiFXD=cu0{~zEU`Agz
zOWt5B`u(LQfDqt+K`Ki~?I$`Qq)f379x#@y|4i_D!DWHK5pLHC_#G@7kn*~J9)PU
zt|BaBAS5IP=+rjUL(KDShOW_I(gai__1MK*~JmlhDxan^F3G)brjn-Y!t!_@b
zgqXp2|M3tMx0lW!r6nSFJk`m~7zfRF;3fQ^}?3j92)=vmO6i=#vpTMnhIi33S9
zI%uc!_9cX@H6_2ib@%1SiTf;1#eoAa=8XSpW!8Cix~CUrmeon1j)HxTm^vLfztbuQ
zXYsr$+pRv~q*~38R-Jv1msHJyM+LvgX4k!D7@kG+S7S5EXvs{Oeo;V(cytv7`hK
z_jzJl3jK=`Svf_Usoq1wVznuYQ!ed-l3*)S`i6J}{?c@|;;q{72hRMjXYR6ev!t@%
zCRD8`5N`GL^m|o5MJ*Mfq%RvvarI6{A_RiIgf-{QV+7qMBO?{`KtXiv7_3d
z?}Z?5%0Ma*7MR9fxBd%9-b6Ao#QRX7-rm*b%SaL6g^pjI0rJdIn`Z8a#EouKIJ}
z6GNuQ#4)0kyMq0=E}gGD+Gx^VL9Fe*C*j-u@MUZtRpPLZQDBXmiBIeO?$mos;q2`f
znuIJYld{VjNG?5sekAu+v0YbE}W}5RF3ka8nx55;cAeWn=v^SKE+W^RFbO;HsLJ
z@MOLhlMy)M^O)n{PdN;Q4|!N)r!8VqYS}K4HY#Ig(U8(hNW5O^Hf#RdSZ6~lC8EV*
z!7fg=sOkDSDvvDL?#03hO2(1s5H%J?6ndm8`#;jNqSc5SNGky;W`jk5$05LX$U8x
zk*;na7@I^Sn#-Bx`_=80D9r{L%=0z1zLA?TWt^_CJmd%^Ny(0-VYoRhWx+AESxVo3
zm(k__un#|3D(xl;o0FCJ4(4*93rA;-{PPr?TvS}Ab$27#E971?lFoSrvu^}o9
zD%afl%3J;@8g*fE76Gv46CdX6!-5_XmWiUYL8+Z(}1`xba?u~ac+@UFTjDn3Ts
zNu}iyLd%gdmxQofF02W?I3pT(HlclB48x$xPCX2Lh1Zr8mxcIFU@Lm!XiE_|75
z1f8;X(_C`VdBU0glSkwc=LfbCS@mV(zL@ExUDgT=7RAWa0aBA}~!t?7V$0^U#$k
zmd%bh;=8OFNHY@ZxMw8gTDm?t0Jh%T)FV~;uiHTsuykv1qsQt?kGJv)45k5?6L0R
z7}Az)oU*h+o2tF*`k?0_=~g@R|YbHC$gES)0V;UHrf$Lf=$RG$7Dzo;Kc|a#
zj8C_$k=-R{?N`6Wo!4n1T1r9aU$3Fz7faXF%R)T#(%D)xVXmxS1K-b$lXRf_
zC5loyk7pEN^uZ-L+`)MaTsjUDHtlA}oD-KX#b8RVTIY?JUyq@R9rIOm=j7(-#8(Jy
zJ2{FSI`?kSSG`wbng7YNsY6bf`7}KOLuSZ6-C;ye3RRuh^4L-pS9s%Ys(QX8FM)eZ
zn^ngjuou`-i@!GXe2^~489rkfdSZCKHePi`}wnJO59QdjYe|QZVj!^}JmsmlaS
z5Oms|jfbcRw^@^FR=d5@$M(w*Zf6w_1fFn%k2H~MPlHO2cp|tsc3`pgC1n;$T@@
z2YX)Y72Wvb)a9zCH(mC^WAzm6*pO@unohjD|E}@SN%Gsb04Nc-IUY2^nl5GZvs
zRbNGh)NFB`uG2YvZgJM)AaTxAy(u@(Ta=CjEm!|QUg`Ah9-Ys$AQw|wE9zvA|dT)
zY(tWB!BR(mWZ?kWPb~`_aYM3(dp`DMPcMA(n@EWm#fj-5pwl3%JZ9NzD^f+@X!5
zta2nYgoKFgc)9xAcy?S{Z4)uecE$|$ePlv$Jtf=s3~}2g)Xc*beYDDo-@!P?u?$X

Re: Patch for Easy Hack 45033

2012-02-13 Thread Tommy
On Mon, 13 Feb 2012 12:27:26 +0100, Italo Vignoli it...@italovignoli.com  
wrote:



I have patched the biblio.odb document with LibreOffice entries (got rid
of the old OOo entries). The patch is below to be checked, but I do not
understand if I have to attach the patched document as well. Please
help. Thanks, Italo



Italo, are you turning into a code-geek after years and years of PR  
activity ?


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Patch for Easy Hack 45033

2012-02-13 Thread Italo Vignoli
On 2/13/12 9:44 PM, Jan Holesovsky wrote:

 If you can attach the file, that would be most helpful.  I am unable to
 reasonably extract the patch from the message - sorry for that, but the
 way that works for me flawlessly for text-only patches failed on this
 binary one :-(

No problem. You know that I am not familiar with patches, so I was not
sure about attaching the file when I have sent the patch. Probably, the
file would be transferred by pushing the patch on master, but I do not
feel confident about doing this myself.

-- 
Italo Vignoli - it...@italovignoli.com
mob +39.348.5653829 - VoIP 5316...@messagenet.it
skype italovignoli - gtalk italo.vign...@gmail.com


biblio.odb
Description: application/vnd.oasis.opendocument.database
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Patch for Easy Hack 45033

2012-02-13 Thread Rob Snelders

Hi,

Are you sure this is the correct file? When I open the file I only see 
OpenOffice and StarOffice entries. Maybe someone else can check what 
he/she sees.


Greetings,
Rob Snelders

On 13-02-12 22:06, Italo Vignoli wrote:

On 2/13/12 9:44 PM, Jan Holesovsky wrote:


If you can attach the file, that would be most helpful.  I am unable to
reasonably extract the patch from the message - sorry for that, but the
way that works for me flawlessly for text-only patches failed on this
binary one :-(


No problem. You know that I am not familiar with patches, so I was not
sure about attaching the file when I have sent the patch. Probably, the
file would be transferred by pushing the patch on master, but I do not
feel confident about doing this myself.




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice