R: [REVIEW 3-5] patch for later cygwins that have a different location for process.h

2012-02-21 Thread walter 
Hi,

read this before apply the patch, file moved back (?)

 http://www.mail-archive.com/cygwin@cygwin.com/msg120501.html
http://www.mail-archive.com/cygwin@cygwin.com/msg120501.html

 

 

Best,

walter

 

 

Da: libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.org
[mailto:libreoffice-bounces+w.guerrieri=ranocchilab@lists.freedesktop.or
g] Per conto di Noel Power
Inviato: martedì 21 febbraio 2012 16:00
A: noel.po...@suse.com
Cc: LibreOffice dev
Oggetto: Re: [REVIEW 3-5] patch for later cygwins that have a different
locaton for process.h

 

On 21/02/12 11:50, Noel Power wrote: 

There is a real sucky problem that will especially affect new Windows
libreoffice developers, namely *real* early there is a big fat build
failure. I came across this as I completely started from scratch creating a
build environment [*]  ( as I managed to bork my windows xp installation )
Attached is a patch, probably there is a better way to do this but I don't
really have a clue about autoconf/configure type stuff and this fix was the
easiest for me. It would be great to get this into 3.5 branch and this is
what we specifically point windows people to ( on the list and irc anyway ).

Note: I didn't attach the generated ( but still under git ) configure a my
autoconf is 1.68 and the previous version used to produce configure was
1.62. I guess it's not so bad I shouldn't push to master anyway right? 

Noel 

[*] btw this was a great opportunity to check out the instructions at
http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies
which I found to be spot on. Ok I have some experience building libreoffice
on windows  and I used the non-free compiler but really I found those
instructions quite good and accurate 





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

oops, seems I deleted a line sometime between compiling and generating the
patch

Noel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: R: [REVIEW 3-5] patch for later cygwins that have a different location for process.h

2012-02-21 Thread Petr Mladek 
walter píše v Út 21. 02. 2012 v 16:10 +0100:
 Hi,
 
 read this before apply the patch, file moved back (?)
 
 http://www.mail-archive.com/cygwin@cygwin.com/msg120501.html
 anyway right? 

The patch added a check if the header was moved and used the new
location when it was moved. Everything will work even when they move the
header back. The patch just makes sure that it works even with the
broken cygwin release. :-)

Anyway, it is great that you pointed out the potential problem.


Best Regards,
Petr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice