Re: [BUG] On shadow textbox frame
On Mon, 2013-09-16 at 09:20 +, Gay, Matthieu wrote: Hello, The patch following is not good, you can see the bug and the good patch here: https://bugs.freedesktop.org/show_bug.cgi?id=69407 I uploaded a counter example to that bug that shows the frame should remain transparent in the .doc importer. So I'm of the opinion that the shadow drawing code should be changed (whereever that code is) to only draw outside the frame area and not underneath it, which appears to be the problem here for transparent frames with shadows. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE: [BUG] On shadow textbox frame
Hello,
The patch following is not good, you can see the bug and the good patch here:
https://bugs.freedesktop.org/show_bug.cgi?id=69407
-Message d'origine-
De : libreoffice-bounces+matthieu.gay=capgemini@lists.freedesktop.org
[mailto:libreoffice-bounces+matthieu.gay=capgemini@lists.freedesktop.org]
De la part de Gay, Matthieu
Envoyé : jeudi 12 septembre 2013 10:53
À : Cedric Bosdonnat
Cc : LibreOffice dev
Objet : RE:[BUG] On shadow textbox frame
Hello,
Sorry, I've just saw your answer.
In fact I have two bugs:
- The first one is about reading a *.doc (see the attached file
SIMPLE_TEST.doc), which has the shadow in the foreground.
I resolve this by applying the following patch (Version 3.5.7):
diff --git a/sw/source/filter/ww8/ww8par6.cxx
b/sw/source/filter/ww8/ww8par6.cxx
index 1677207..796497a 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -2360,7 +2360,7 @@ bool SwWW8ImplReader::IsDropCap() bool
SwWW8ImplReader::StartApo(const ApoTestResults rApo,
const WW8_TablePos *pTabPos)
{
-if (0 == (pWFlyPara = ConstructApo(rApo, pTabPos)))
+if (0 != (pWFlyPara = ConstructApo(rApo, pTabPos)))
return false;
// WW8SwFlyPara constructor has changed - new 4th parameter
I will put a new bug and the commit, but can you tell me if my patch will
provoke any regressions?
- The second one is the bug you answered, I will look in paintfrm.cxx.
Thanks very much for your answers.
Matthieu GAY
De : Cedric Bosdonnat [cbosdon...@suse.com] Envoyé : lundi 15 juillet 2013
09:56 À : Gay, Matthieu Cc : LibreOffice dev Objet : Re: [BUG] On shadow
textbox frame
Hello Matthieu,
On Fri, 2013-07-12 at 13:03 +, Gay, Matthieu wrote:
When I have a text box with shadow on the side, if the background of
the frame is transparent (more than 0%) the shadow come to the
foreground.
Con you tell me if this a bug ? If so where can I resolve it? If this
a UI bug?
That really sounds like a bug in the Frame painting. I would start looking at
SwFlyFrm::Paint:
http://opengrok.libreoffice.org/xref/core/sw/source/core/layout/paintfrm.cxx#3881
I hope this helps,
--
Cedric
This message contains information that may be privileged or confidential and is
the property of the Capgemini Group. It is intended only for the person to whom
it is addressed. If you are not the intended recipient, you are not authorized
to read, print, retain, copy, disseminate, distribute, or use this message or
any part thereof. If you receive this message in error, please notify the
sender immediately and delete all copies of this message.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE:[BUG] On shadow textbox frame
Hello,
Sorry, I've just saw your answer.
In fact I have two bugs:
- The first one is about reading a *.doc (see the attached file
SIMPLE_TEST.doc), which has the shadow in the foreground.
I resolve this by applying the following patch (Version 3.5.7):
diff --git a/sw/source/filter/ww8/ww8par6.cxx
b/sw/source/filter/ww8/ww8par6.cxx
index 1677207..796497a 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -2360,7 +2360,7 @@ bool SwWW8ImplReader::IsDropCap()
bool SwWW8ImplReader::StartApo(const ApoTestResults rApo,
const WW8_TablePos *pTabPos)
{
-if (0 == (pWFlyPara = ConstructApo(rApo, pTabPos)))
+if (0 != (pWFlyPara = ConstructApo(rApo, pTabPos)))
return false;
// WW8SwFlyPara constructor has changed - new 4th parameter
I will put a new bug and the commit, but can you tell me if my patch will
provoke any regressions?
- The second one is the bug you answered, I will look in paintfrm.cxx.
Thanks very much for your answers.
Matthieu GAY
De : Cedric Bosdonnat [cbosdon...@suse.com]
Envoyé : lundi 15 juillet 2013 09:56
À : Gay, Matthieu
Cc : LibreOffice dev
Objet : Re: [BUG] On shadow textbox frame
Hello Matthieu,
On Fri, 2013-07-12 at 13:03 +, Gay, Matthieu wrote:
When I have a text box with shadow on the side, if the background of
the frame is transparent (more than 0%) the shadow come to the
foreground.
Con you tell me if this a bug ? If so where can I resolve it? If this
a UI bug?
That really sounds like a bug in the Frame painting. I would start
looking at SwFlyFrm::Paint:
http://opengrok.libreoffice.org/xref/core/sw/source/core/layout/paintfrm.cxx#3881
I hope this helps,
--
Cedric
This message contains information that may be privileged or confidential and is
the property of the Capgemini Group. It is intended only for the person to whom
it is addressed. If you are not the intended recipient, you are not authorized
to read, print, retain, copy, disseminate, distribute, or use this message or
any part thereof. If you receive this message in error, please notify the
sender immediately and delete all copies of this message.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
