Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-03-22 Thread Norbert Thiebaud
> > Anything else that I could do to grow trust, so that maybe Winfrieds patch > can make it to 3.5.3 ? I pushed it on libreoffice-3.5 it will be there in 3.5.3 Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedes

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-03-22 Thread Cor Nouws
Hi Michael, Michael Meeks wrote (21-02-12 13:03) On Tue, 2012-02-21 at 00:32 +0100, Cor Nouws wrote: Just to be sure: people eligible to do reviews, are those delivering code, or solely those with commit access? I would say a competent developer, and/or someone willing to take the ri

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-21 Thread Michael Meeks
On Tue, 2012-02-21 at 00:32 +0100, Cor Nouws wrote: > Just to be sure: people eligible to do reviews, are those delivering > code, or solely those with commit access? I would say a competent developer, and/or someone willing to take the risk - that can be reduced a lot by showing impress

RE: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Winfried Donkers
Jan Holesovsky wrote (20-02-12 18:04) > Nope, still 3 I am afraid :-( - after the feature freeze, before we even > needed 1 review for pushing to the libreoffice-3-5 branch, it was 3 > reviews for a feature or two that got in few days after the feature > freeze (I remember the SmartArt import).

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Cor Nouws
Hi Kendy, Jan Holesovsky wrote (20-02-12 18:04) Nope, still 3 I am afraid :-( - after the feature freeze, before we even needed 1 review for pushing to the libreoffice-3-5 branch, it was 3 reviews for a feature or two that got in few days after the feature freeze (I remember the SmartArt import

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Jan Holesovsky
Hi Cor, On 2012-02-20 at 17:44 +0100, Cor Nouws wrote: > > Anyhow - I don't see a special case for bending the rules of triple > > reviews, nor a reason to refuse it if it gets that widespread > > support :-) it's a nice fix. > > Thanks, that sounds encouraging. > As written: going for 3.5.2

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Cor Nouws
Hi Michael, Michael Meeks wrote (20-02-12 17:13) On Mon, 2012-02-20 at 15:22 +0100, Cor Nouws wrote: Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: Can this patch be pushed to 3.4 and 3.5 branches as well? The patch addresses problem that go way back in time (pre-LibreOffice at least)

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Michael Meeks
Hi Cor, On Mon, 2012-02-20 at 15:22 +0100, Cor Nouws wrote: > > Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: > >> Can this patch be pushed to 3.4 and 3.5 branches as well? > >> The patch addresses problem that go way back in time (pre-LibreOffice at > >> least). :-) it is some

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-20 Thread Cor Nouws
Hi Kendy, *, Jan Holesovsky wrote (14-02-12 14:47) Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: Can this patch be pushed to 3.4 and 3.5 branches as well? The patch addresses problem that go way back in time (pre-LibreOffice at least). The problem is that it is partially a feature,

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-14 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: > Can this patch be pushed to 3.4 and 3.5 branches as well? > The patch addresses problem that go way back in time (pre-LibreOffice at > least). The problem is that it is partially a feature, and introduces new strings :-( - so

RE: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-14 Thread Winfried Donkers
Olivier Hallot wrote (14 februari 2012) >The new schema with the paper size will work with older versions of >LibreOffice and OpenOffice? In other words, if I replace Labels.xcu from >older OOo, with the new one, is it going to break the label feature or >not of OOo? It will work with 'old style'

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-14 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Em 14-02-2012 04:44, Winfried Donkers escreveu: > Can this patch be pushed to 3.4 and 3.5 branches as well? > The patch addresses problem that go way back in time (pre-LibreOffice at > least). > > > Winfried Just a question... The new schema w