Re: UI/accessibility dev advice needed on change 150546

2023-04-28 Thread Michael Weghorn
On 27/04/2023 07.19, Lionel Élie Mamane wrote: I'm reviewing https://gerrit.libreoffice.org/150546 by Nirnay. It adds a .ui file, and a "make" outputs warning like WARNING: 'GtkLabel' 'browselabel' does not specify what it labels within 'GtkFrame' 'frame1' The other preexisting .ui files also

Re: UI/accessibility dev advice needed on change 150546

2023-04-27 Thread Caolán McNamara
On Thu, 2023-04-27 at 10:22 +0100, Caolán McNamara wrote: > On Thu, 2023-04-27 at 06:19 +0200, Lionel Élie Mamane wrote: > > Hi, > > > > I'm reviewing https://gerrit.libreoffice.org/150546 > > by Nirnay. It adds a .ui file, and a "make" outputs warning like > > > > WARNING: 'GtkLabel'

Re: UI/accessibility dev advice needed on change 150546

2023-04-27 Thread Caolán McNamara
On Thu, 2023-04-27 at 06:19 +0200, Lionel Élie Mamane wrote: > Hi, > > I'm reviewing https://gerrit.libreoffice.org/150546 > by Nirnay. It adds a .ui file, and a "make" outputs warning like > > WARNING: 'GtkLabel' 'browselabel' does not specify what it labels > within 'GtkFrame' 'frame1' While

Re: UI/accessibility dev advice needed on change 150546

2023-04-26 Thread Heiko Tietze
The gla11y tool was implemented to ensure accessibility and is required. Silencing a warning is only appropriate for static strings; see https://wiki.documentfoundation.org/Development/Accessibility for more info. The browselabel seems to be a (dynamic) label for the GtkEntry browseurl, and

UI/accessibility dev advice needed on change 150546

2023-04-26 Thread Lionel Élie Mamane
Hi, I'm reviewing https://gerrit.libreoffice.org/150546 by Nirnay. It adds a .ui file, and a "make" outputs warning like WARNING: 'GtkLabel' 'browselabel' does not specify what it labels within 'GtkFrame' 'frame1' The other preexisting .ui files also generate a bunch of them, but they are