Re: config_host doesn't set $PATH

2012-02-11 Thread Korrawit Pruegsanusak 
Hello Norbert,

On Fri, Feb 10, 2012 at 23:20, Norbert Thiebaud nthieb...@gmail.com wrote:
 Fixed.

Tested and it's fine now. Thanks for fixing :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: config_host doesn't set $PATH

2012-02-10 Thread Norbert Thiebaud 
On Wed, Feb 8, 2012 at 4:38 AM, Korrawit Pruegsanusak
detective.conan.1...@gmail.com wrote:
 Hello Norbert,

 On Wed, Feb 8, 2012 at 17:07, Korrawit Pruegsanusak
 detective.conan.1...@gmail.com wrote:
 Anyway, it doesn't set $PATH - the environment variables - like
 Env.host.sh did in the past, at least in cygwin.

 Sorry. The $PATH is already in config_host.mk, but it's missing some
 directories.
 Here's the diff between $PATH in Env.host.sh and config_host.mk:

 $ diff -u path_line pathnew_line
 --- path_line   2012-02-08 17:32:40.0 +0700
 +++ pathnew_line        2012-02-08 17:31:52.0 +0700
 @@ -1,10 +1,6 @@
  PATH=.
  /cygdrive/d/libo/solenv/bin
  /cygdrive/d/libo/solenv/wntmsci12/bin
 -/cygdrive/c/PROGRA~1/MICROS~1.0/VC/bin
 -/cygdrive/c/PROGRA~1/MI2578~1/Windows/v6.0A/Bin
 -/cygdrive/c/WINDOWS/MICROS~1.NET/FRAMEW~1/v3.5
 -/cygdrive/c/PROGRA~1/MI2578~1/Windows/v6.0A/bin
  /cygdrive/c/PROGRA~1/MICROS~1.0/Common7/IDE
  /usr/local/bin
  /usr/bin

 Note: I split them into many lines to have more readable diff, and
 it's missing 3 directories.
 Not sure whether there are all needed, but IMHO the
    /cygdrive/c/PROGRA~1/MICROS~1.0/VC/bin
 is at least needed.

 Could you please have a look? Thanks again :-)

Fixed.
That was a bug where some part of the PATH were incorrectly not set if
java was disabled.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

config_host doesn't set $PATH

2012-02-08 Thread Korrawit Pruegsanusak 
Hello Norbert, all,

First of all, thanks for your work regarding killing the Env.host.sh :-)

Anyway, it doesn't set $PATH - the environment variables - like
Env.host.sh did in the past, at least in cygwin.

In Env.host.sh, $PATH is created from set_soenv.in, setting the path
to msvc binaries before /usr/bin/*. That is, when calling `link`, it
would execute the msvc linker.
But now it will execute gnu linker, which is incorrect and break my build.

Is this intended? If yes, I have to set the $PATH manually, right?

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice