[SOLVED/WORKAROUNDED] Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread julien2412
Patch pushed, see https://cgit.freedesktop.org/libreoffice/core/commit/?id=930ec0e6ab7bd5492fb4cf4a8f6860e3b728929d -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@l

Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread julien2412
Miklos Vajna-6 wrote > ... > Ah, I see. It would make a lot of sense to do the same on Windows -- are > you interested in creating a patch? > ... Done here: https://gerrit.libreoffice.org/#/c/67092/, as you may have seen, I put you on cc. Julien -- Sent from: http://document-foundation-mail-a

Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread Miklos Vajna
Hi Julian, On Tue, Jan 29, 2019 at 09:06:03AM -0700, julien2412 wrote: > It's disabled only for non Windows build. Indeed it's in the else block > (line 30: else # OS!=WNT) Ah, I see. It would make a lot of sense to do the same on Windows -- are you interested in creating a patch? Thanks, Mik

Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread julien2412
Miklos Vajna-6 wrote > ... > Why do you need that manually? It's the default since commit > 02623af4f5e0049ec5988df8ff6c7ff0f32f3fb1 (nss: disable gtests, > 2019-01-03). > ... Hi Miklos, It's disabled only for non Windows build. Indeed it's in the else block (line 30: else # OS!=WNT) Julien -

Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread Miklos Vajna
Hi Julien, On Tue, Jan 29, 2019 at 03:00:15AM -0700, julien2412 wrote: > Just for the record, I've workarounded this pb in nss by doing: > export NSS_DISABLE_GTESTS=1 Why do you need that manually? It's the default since commit 02623af4f5e0049ec5988df8ff6c7ff0f32f3fb1 (nss: disable gtests, 2019

Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread julien2412
Just for the record, I've workarounded this pb in nss by doing: export NSS_DISABLE_GTESTS=1 Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop

Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-25 Thread julien2412
About license, I just needed to create a Microsoft account and it's ok (Community version doesn't need more). About language, I installed English pack and changed the UI in options/env (see https://docs.microsoft.com/en-us/visualstudio/install/microsoft-language-interface-packs-lips-and-visual-stud

fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-25 Thread julien2412
Hello, Following "Could not determine MSC version (Visual Studio 2017)", I tried a local change for regexp to generate a patch. Now I've got this: PATH="C:\BLP\libo-core\instdir\program" PYTHONHOME="C:/BLP/libo-core/instdir/program/python-core-3.5.6" PYTHONPATH="C:/BLP/libo-core/instdir/program/p