Re: master build broken on macOS due to Firebird update

2024-01-07 Thread Caolán McNamara
On Sun, 2024-01-07 at 19:26 +, Caolán McNamara wrote: > On Sun, 2024-01-07 at 19:03 +0200, Ilmari Lauhakangas wrote: > > Yes, even with the patch the (debug) build fails for me on Linux > > with > > Clang 16. > > I don't quite know what the problem here is but if you drop > >

Re: master build broken on macOS due to Firebird update

2024-01-07 Thread Caolán McNamara
On Sun, 2024-01-07 at 19:03 +0200, Ilmari Lauhakangas wrote: > Yes, even with the patch the (debug) build fails for me on Linux with > Clang 16. I don't quite know what the problem here is but if you drop --enable-ld=mold does it then build?

Re: master build broken on macOS due to Firebird update

2024-01-07 Thread Ilmari Lauhakangas
On 7.1.2024 18.38, Patrick Luby wrote: On 2024-01-06 3:46 p.m., Caolán McNamara wrote: On Sat, 2024-01-06 at 12:03 -0500, Patrick Luby wrote: I have submitted a revert for the Firebird update here: The previous version was 3.0.7 and the current is 3.0.11 which suggests there probably wasn't

Re: master build broken on macOS due to Firebird update

2024-01-07 Thread Patrick Luby
Thank you Caolán for finding the cause of the macOS build failures! I can now build and run the unit tests successfully running "make clean && make && make check" Although the following Gerrit change mostly only affects macOS, I did add a fix for another problem that I found: the Firebird

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Caolán McNamara
On Sat, 2024-01-06 at 12:03 -0500, Patrick Luby wrote: > I have submitted a revert for the Firebird update here: The previous version was 3.0.7 and the current is 3.0.11 which suggests there probably wasn't massive changes. So reading through the upgrade commit I see a macosx specific hunk in one

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Patrick Luby
I have submitted a revert for the Firebird update here: https://gerrit.libreoffice.org/c/core/+/161683 There are still errors even when I build a non-debug build. So, the only way I can see this update sucessfully building on macOS is that Jenkins builds Mac Intel targeting an older

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Patrick Luby
So I used the attached debug patch and now I am only runnning into casting errors. Still more work to do, but at least it is progress. I'll see how far I can get patching the errors. Patrick On 2024-01-06 11:22 a.m., Regina Henschel wrote: Hi all, it breaks for me too. VS2022 on Win11

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Regina Henschel
Hi all, it breaks for me too. VS2022 on Win11 with --enable-dbgutil. So not only macOS. Kind regards, Regina Patrick Luby schrieb am 06.01.2024 um 16:20: All, I am not sure how this update built successfully on macOS on Jenkins, but the Firebird update is filled with hundreds of sprintf

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Patrick Luby
Unfortunately, on macOS neither --enable-werror or --disable-werror doesn't seem to have any affect on the external/firebird build. Patrick On 2024-01-06 10:59 a.m., Mike Kaganski wrote: Hi! On 1/6/2024 9:53 PM, Patrick Luby wrote: Can anyone actually do a debug build on any other platform

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Ilmari Lauhakangas
On 6.1.2024 17.53, Patrick Luby wrote: On 2024-01-06 10:20 a.m., Patrick Luby wrote: All, I am not sure how this update built successfully on macOS on Jenkins, but the Firebird update is filled with hundreds of sprintf calls like the following. Xcode has marked sprintf as deprecated since a

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Mike Kaganski
Hi! On 1/6/2024 9:53 PM, Patrick Luby wrote: Can anyone actually do a debug build on any other platform on master with this update? IIRC Windows also has to suppress deprecation warnings, at least for sprintf, but maybe I am wrong. I have just built master on Windows, using --enable-werror;

Re: master build broken on macOS due to Firebird update

2024-01-06 Thread Patrick Luby
Bad news: this update is worse than I thought when doing a clean debug build after doing a make clean. I am seeing a lengthy list of all sorts of different warnings being converted to errors. There are still a lot of sprintf errors, but now there are even more other, different warnings. See

master build broken on macOS due to Firebird update

2024-01-06 Thread Patrick Luby
All, I am not sure how this update built successfully on macOS on Jenkins, but the Firebird update is filled with hundreds of sprintf calls like the following. Xcode has marked sprintf as deprecated since a couple of versions ago: