Re: odf2xhtml (and other xslt filters) - tabs or spaces?

Am 14.09.2017 um 17:29 schrieb Stephan Bergmann: I would not do so. When you do a change, whatever change, you're responsible for that, with all consequences, positive and negative. :) Ok :) So if I see no veto either here or in Gerrit until monday, I'll merge the patch. Thanks Samuel

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

On 09/14/2017 04:24 PM, Samuel Mehrbrodt wrote: I wonder whether we should credit such patches to a virtual "Cleanup" author, so we don't spoil the stats with such commits? I would not do so. When you do a change, whatever change, you're responsible for that, with all consequences, positive

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

Hi Samuel, Samuel Mehrbrodt píše v Čt 14. 09. 2017 v 14:17 +: > > I wonder, rather than debugging / writing xslt, wouldn't it be > > better > > to extend our html export so that it can generate xhtml if asked to > > (we > > already fulfill many of the requirements there anyway - seems to > >

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

So it seems the general consent is to move ahead with spaces instead of tabs. I updated the patch accordingly, and applied it to all XSLT files: https://gerrit.libreoffice.org/#/c/41009/ I wonder whether we should credit such patches to a virtual "Cleanup" author, so we don't spoil the stats

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

Am 12.09.2017 um 17:44 schrieb Jan Holesovsky: But about the filter in general - please, what are the features that the xhtml export filter can do that our 'normal' html filter cannot? I wonder, rather than debugging / writing xslt, wouldn't it be better to extend our html export so that it can

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

Hi, On Tue, Sep 12, 2017 at 05:44:04PM +0200, Jan Holesovsky wrote: > I'd agree with Miklos.  It's true that git blame is less useful then, As long as the changes are really just whitespace, you can use 'git blame -w' to ignore those. Regards, Miklos signature.asc

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

Hi Samuel, Samuel Mehrbrodt píše v St 06. 09. 2017 v 14:16 +: > Miklos suggested to convert all to 4 spaces instead as we do in C++ > code.The downside is that converting to spaces touches almost all > lines, > while this touches only a few. > > Are there any opinions on this? I'd agree

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

On 09/06/2017 06:34 PM, Thorsten Behrens wrote: consistency (that we don't have anyway). Note that the original tab2space conversion was done as a silent git rewrite, so not losing Ah, that's a good point. Shame we missed some types of source files back then...

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

Samuel Mehrbrodt wrote: > Are there any opinions on this? > Your call I'd say. I see disadvantages for both ways - just that the status quo inconsistency is a real irritation. Personally I value working git blame & history over tree-wide consistency (that we don't have anyway). Note that the

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

> So this is about tabs in the XSLT source code, not in the generated > XHTML? Correct. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: odf2xhtml (and other xslt filters) - tabs or spaces?

On 09/06/2017 04:16 PM, Samuel Mehrbrodt wrote: our xhtml export originally used tabs for indentation. Over time some changes were made which were indented with spaces. So currently it's a mix of both. I'd like to unify it and as the majority was tabs, I converted all to tabs:

odf2xhtml (and other xslt filters) - tabs or spaces?

Hi, our xhtml export originally used tabs for indentation. Over time some changes were made which were indented with spaces. So currently it's a mix of both. I'd like to unify it and as the majority was tabs, I converted all to tabs: https://gerrit.libreoffice.org/#/c/41009/ Miklos suggested to