sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

2015-02-18 Thread Matteo Casalin
Hi all, while looking at http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 I noticed a really suspicious use of ! on the same line that was modified: ! nMinNextEnd nRow Based on the 'n' prefix and the related usage of ! in conditionals on

Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

2015-02-18 Thread Stephan Bergmann
On 02/18/2015 11:51 AM, Matteo Casalin wrote: while looking at http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 I noticed a really suspicious use of ! on the same line that was modified: ! nMinNextEnd nRow mistakes like this (which

Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

2015-02-18 Thread Stephan Bergmann
On 02/18/2015 03:57 PM, Matteo Casalin wrote: That code was already there - could it be that for some reason the plugin was used for that file but did not detect that instance? Sorry for being cryptic. My remark was merely meant as a shameless plug to advertise the usefulness of those

Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

2015-02-18 Thread Matteo Casalin
Hi Stephan, thanks for looking into this. That code was already there - could it be that for some reason the plugin was used for that file but did not detect that instance? Kind regards Matteo On Wed, 18 Feb 2015 12:53:34 +0100 Stephan Bergmann sberg...@redhat.com wrote: On 02/18/2015

Re: sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

2015-02-18 Thread Németh László
Hi, 2015-02-18 17:06 GMT+01:00 Stephan Bergmann sberg...@redhat.com: (In this particular case, the mistake was only originally introduced a few hours earlier, so likely no build with plugins enabled happened to stumble over it before it got fixed.) In this particular case, really a useful