Re: should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-14 Thread David Tardon
Hi, On Tue, May 07, 2013 at 07:08:16PM +0200, Andras Timar wrote: No, I don't think we want install sets without en-US. But we need to make sure that we don't have runtime problems when a localized file is missing. Now there is the en-US copy, but after your proposed patch there will be

Re: should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-14 Thread David Tardon
Hi, this review: https://gerrit.libreoffice.org/3908 drops (now unneeded) DEFAULT_TO_ENGLISH_FOR_PACKING and the installer code that handles it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-10 Thread David Tardon
Hi, On Tue, May 07, 2013 at 07:08:16PM +0200, Andras Timar wrote: Hi, On Tue, May 7, 2013 at 5:35 PM, David Tardon dtar...@redhat.com wrote: No, I don't think we want install sets without en-US. But we need to make sure that we don't have runtime problems when a localized file is missing.

Re: should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-10 Thread David Tardon
Hi, On Fri, May 10, 2013 at 03:25:27PM +0200, David Tardon wrote: Hi, On Tue, May 07, 2013 at 07:08:16PM +0200, Andras Timar wrote: Hi, On Tue, May 7, 2013 at 5:35 PM, David Tardon dtar...@redhat.com wrote: No, I don't think we want install sets without en-US. But we need to make

Re: should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-09 Thread Caolán McNamara
On Tue, 2013-05-07 at 17:35 +0200, David Tardon wrote: The question is: Do we see any reason to create install. sets that do not contain en-US, as explained in i#45118 (in that case there are several things that need to be fixed)? If not, we can just drop DEFAULT_TO_ENGLISH_FOR_PACKING and the

should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-07 Thread David Tardon
Hi all, the installer uses a special variable DEFAULT_TO_ENGLISH_FOR_PACKING to substitute en-US files if there are no files for native language (this is used for the stuff from extras and help). The reasoning why it is needed is in https://issues.apache.org/ooo/show_bug.cgi?id=45118 (Rene had

Re: should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

2013-05-07 Thread Andras Timar
Hi, On Tue, May 7, 2013 at 5:35 PM, David Tardon dtar...@redhat.com wrote: Hi all, the installer uses a special variable DEFAULT_TO_ENGLISH_FOR_PACKING to substitute en-US files if there are no files for native language (this is used for the stuff from extras and help). The reasoning why it