Re: tdf#51165 -> code pointer needed

2015-11-08 Thread Thorsten Behrens
Christina Roßmanith wrote:
> Then for the mixed case the problem could be solved by iterating
> over the polypolygon and calling writePathShape() with each
> individual subpolygon. Or are there reasons not to proceed this way?
> 
Ah, good point - indeed that would be the best way around this. There
are other workarounds / compat fixes already in the filter.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: tdf#51165 -> code pointer needed

2015-11-08 Thread Chr . Roßmanith
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 08.11.2015 um 01:43 schrieb Thorsten Behrens:
> Christina Roßmanith wrote:
>> I'm revisiting tdf#51165. It looks like rendering is the
>> problem, not importing the SVG file. To continue I'd need some
>> code pointers where rendering is implemented.
>> 
> Hi Christina,
> 
> oh, this is an interesting corner case - the polypolygon in the
> bugdoc has both closed and open polygons, therefore 
> B2DPolyPolygon::isClosed() will yield false. Thusly 
> xmloff/source/draw/ximpshap.cxx:1514 and following will pick the
> open shape service.
> 
> The case at hand can be fixed, the problem in general is that LibO 
> cannot handle mixed open & closed polygons within a *single*
> shape.
Then for the mixed case the problem could be solved by iterating over
the polypolygon and calling writePathShape() with each individual
subpolygon. Or are there reasons not to proceed this way?

Christina

> 
> HTH,
> 
> -- Thorsten
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJWP7s1AAoJEN/hiApPuw9SaK8H/1dlm7H8Llhd88dMTyNgxjjt
MHH0uydfLj8ENsh/wEBC4bGmpPsT0tBvd2uPo/SObavypFNMW8zRkXCanPnx91IH
yv8u1aX82DJoUIMRaLz6wG1vWYLiU95YKI7d8OEQYWo2KB43oPTZYRkR/niT5/jL
xRpmRIBeoEumuJMT8ArKcYCHYsQAYATXOa0Dhqmo0Q6NdiPSCl0f9CmGCCOPYTzH
goGgzrf2DoEdEiipy2VspPGwOpX6ODG0n94j7OSXS9hBIYsSMQgB+RE8Q/Z5c4in
wcuwRwWrSgJtivERk3GBCvdCki4Q+g8/TI/v3LtYV/z18pQziNF0wgC31BchPB8=
=9z0l
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: tdf#51165 -> code pointer needed

2015-11-07 Thread Thorsten Behrens
Christina Roßmanith wrote:
> I'm revisiting tdf#51165. It looks like rendering is the problem,
> not importing the SVG file. To continue I'd need some code pointers
> where rendering is implemented.
> 
Hi Christina,

oh, this is an interesting corner case - the polypolygon in the bugdoc
has both closed and open polygons, therefore
B2DPolyPolygon::isClosed() will yield false. Thusly
xmloff/source/draw/ximpshap.cxx:1514 and following will pick the open
shape service.

The case at hand can be fixed, the problem in general is that LibO
cannot handle mixed open & closed polygons within a *single* shape.

HTH,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


tdf#51165 -> code pointer needed

2015-11-06 Thread Chr . Roßmanith
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

I'm revisiting tdf#51165. It looks like rendering  is the problem, not
importing the SVG file. To continue I'd need some code pointers where
rendering is implemented.

Christina
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEbBAEBAgAGBQJWO8phAAoJEN/hiApPuw9SaGAH92VdZh8zvgNBm8mVUmbSMxbI
Gz/JxmYT1wLCBPQoqsW+MLiHPE+haQcyPTOpDsd3w26DIprCa10IC4eNskW2MH2g
5X+RLumFEuFOCjZFogGar8zKOWaUUVCviaack4ioGVn9NFYsIlDPJv0j3PmZC3yK
CxOF7M8tTGeq1sGSB2cm/mS3VMMfdPnYwT8wzS9NV4J/aJgTiMauH7ndjLqAd0Ad
s4RSPaUktXYr9l6LtOCm+BykuuFz52skSbiO4oOquX/jcPAixdGXFdUk61Af2v5H
02AMGGUBFx8fHRJfq/s1cLNzU8J9el2tTtdpoDlSMlkB6hqPN5KhC6RbncHdqA==
=yQ6o
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice