https://bugs.documentfoundation.org/show_bug.cgi?id=105602

            Bug ID: 105602
           Summary: Extended help does not work in GtkToolButton items if
                    the property "action_name" is set
           Product: LibreOffice
           Version: 5.4.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: UI
          Assignee: libreoffice-bugs@lists.freedesktop.org
          Reporter: kelem...@ubuntu.com

Created attachment 130753
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130753&action=edit
Screenshot of the problem in Calc side pane, help debug mode

I noticed that since the Writer[1] and Calc[2] Navigator side pane conversion
to .ui format the extended help stopped working on the tool buttons at the top
of these side panes.

The help content was correctly updated with bookmark and ahelp ids after the
conversion, so I continued looking for other explanations.

I think the problem is that these items have the action_name property set,
which overrides the default "modules/swriter/ui/navigatorpanel/something" style
help id to just the value in the action_name. I wonder if this is intentional?

Now I think one way to go could be to modify the help ids in helpcontent, but
the problem with this approach is that the short command names are not unique
between help files - for example we have a "dragmode" command in Writer, Calc
and Impress and they mean different things by looking at the help.

A better ways would be to somehow preserve the default style help ids.


This problem is not specific to the Navigator side panes, I see this happening
in the Spelling and Grammar dialog[3] and in the Templates dialog[4] too.

[1]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=33603a582bdd173a8e85c78bb0e8ef82874b8e59
[2]
https://cgit.freedesktop.org/libreoffice/core/commit/?id=141a4ac1d21121a4e46470c797c6fce741151fee
[3]
https://cgit.freedesktop.org/libreoffice/core/tree/cui/uiconfig/ui/spellingdialog.ui#n382
[4]
https://cgit.freedesktop.org/libreoffice/core/tree/sfx2/uiconfig/ui/templatedlg.ui#n309

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to