https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Stéphane Guillou (stragu) changed:
What|Removed |Added
See Also|
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Rohit kumar changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Mike Kaganski changed:
What|Removed |Added
CC||kbw9xf...@relay.firefox.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Bug 118320 depends on bug 148085, which changed state.
Bug 148085 Summary: About dialog hyperlinks look bad (invisible / have no
contrast) in dark mode on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=148085
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Stéphane Guillou (stragu) changed:
What|Removed |Added
See Also|https://bugs.documentfounda |
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Xisco Faulí changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Timur changed:
What|Removed |Added
Depends on|148376 |
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Bug 118320 depends on bug 148376, which changed state.
Bug 148376 Summary: Insert Table toolbar: text with table size does not respect
dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=148376
What|Removed
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Timur changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
V Stuart Foote changed:
What|Removed |Added
CC||xordevore...@gmail.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #112 from Pedro ---
Thank you for clarifying this for me Mike. :)
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #111 from Pedro ---
Created attachment 181883
--> https://bugs.documentfoundation.org/attachment.cgi?id=181883=edit
In windows 11 color highlight is too light and up and down buttons still not
themed.
Additional issues in
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #110 from Mike Kaganski ---
(In reply to Pedro from comment #109)
Moving out of experimental early enough in the release cycle is fine; it's
always possible to undo that, but this way, it gets more testing.
--
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #109 from Pedro ---
I would wait to remove it out of experimental because there's those multiple
minor issues that were reported by me and Ryzal that should be addressed before
the 7.5.0 release.
Unless those are worked on
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #108 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/db4c4676b70bb5f9a1c169735e8fbe92b097a57b
Related:
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Commit Notification changed:
What|Removed |Added
Whiteboard|target:7.4.0|target:7.4.0 target:7.5.0
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Rafael Lima changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
V Stuart Foote changed:
What|Removed |Added
CC||baliczeri...@gmail.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #106 from John Mills ---
I agree with Pedro here, what is remaining for this to be moved out of
experimental now? What would be expected in a 'meta' ticket? Something like
selectable light/dark or follow system theme?
--
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #105 from Pedro ---
Agreed. And move it out of experimental.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #104 from Timur ---
Please make a wrap-up or rather close this one and open new ones for what's
missing, unless already open.
We have Meta for many issues, this one also deserved meta.
--
You are receiving this mail
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Heiko Tietze changed:
What|Removed |Added
Depends on||148085
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #103 from ifrozenphoe...@outlook.com ---
I've tested this feature with the daily master build of today (7.4 alpha) on
Windows 11 22000.613 and it looks really good to me. Ok, it looks perfect :-).
I haven't found any issues so
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
V Stuart Foote changed:
What|Removed |Added
Depends on||148376
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #102 from Rizal Muttaqin ---
Created attachment 179282
--> https://bugs.documentfoundation.org/attachment.cgi?id=179282=edit
There's white area in document recovery
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #101 from Pedro ---
Ah got it. Yes I noticed that it detects the theme option selected in Windows.
I thought your comment referred to change the UI color from inside LibreOffice.
My mistake then.
Thank you for clarifying
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #100 from V Stuart Foote ---
(In reply to Pedro from comment #92)
> Where is the dark theme toggle located? Can't find it.
Not a manual action, the toggle is detected by Win10+ API called from
dwmapi.dll and
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #99 from Pedro ---
Created attachment 179036
--> https://bugs.documentfoundation.org/attachment.cgi?id=179036=edit
Column x Line numbers are still black (on black background)
Column x Line numbers are still black (on black
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #98 from Pedro ---
Created attachment 179035
--> https://bugs.documentfoundation.org/attachment.cgi?id=179035=edit
White background on display views Edit Modes
White background also visible in Edit Modes of Display Views
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #97 from Pedro ---
Created attachment 179034
--> https://bugs.documentfoundation.org/attachment.cgi?id=179034=edit
White background on Slide background drop-down
The background on Slide background drop-down in Standard
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
John Mills changed:
What|Removed |Added
CC||jmill...@yahoo.com
--- Comment #96
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #95 from John Mills ---
Hi all,hi Caolán,
This is starting to look really good,I would definitely use this now!
Would the new tabs also be possible to implement in the Light mode? If it is
possible then it would resolve the
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #94 from Pedro ---
So active Tab title background is the same as inactive tab background. It's
different from Tab body background.
This seems like a conscious design decision from Caolán that might be dictated
by limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #93 from Pedro ---
Created attachment 179033
--> https://bugs.documentfoundation.org/attachment.cgi?id=179033=edit
Tabs with latest commit
These are the tabs after Caolán's latest commits.
The white border surrounding the
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #92 from Pedro ---
(In reply to V Stuart Foote from comment #89)
> @Caolán, had a test drive of today's
> Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: a997bd0e77d9721d55311dcfbd50fea802d801bd
> CPU
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #91 from Mike Kaganski ---
(In reply to Heiko Tietze from comment #90)
We need some change in how "automatic" colors are treated in the color schemes,
trying hard to get some meaningful colors from system, including taking
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #90 from Heiko Tietze ---
(In reply to V Stuart Foote from comment #89)
> Can we do similar to toggle over to the "LibreOffice Dark" color scheme in
> 'Application Colors'?
The LibreOffice Dark might follow Breeze Dark but
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #89 from V Stuart Foote ---
@Caolán, had a test drive of today's
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a997bd0e77d9721d55311dcfbd50fea802d801bd
CPU threads: 8; OS: Windows 10.0 Build 19044; UI
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #88 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/29c4d47161dab81971029717ce358de59f52f8c3
Related: tdf#118320
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #87 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/c51140847efa90897253011bd0382a32440d73e3
Related: tdf#118320
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #86 from Pedro ---
It is just a matter of changing Tab body selected background color from #202020
to #66. And to use also #66 for the Tab body border color so that it
disappears.
--
You are receiving this mail
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #85 from Pedro ---
Created attachment 178993
--> https://bugs.documentfoundation.org/attachment.cgi?id=178993=edit
Make background of Tab body and Tab title same color and make Tab body border
transparent (or give it same
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #84 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/892ef6e8b6888b3029041ab150b409f81a5c31b0
Related: tdf#118320
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #83 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/348407dfdf5fd41b99f5998463eb032128799555
Related: tdf#118320
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #82 from Pedro ---
Created attachment 178974
--> https://bugs.documentfoundation.org/attachment.cgi?id=178974=edit
Arrows to increase and decrease numbers
The arrows highlighted in the red box do not obtain dark theme.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #81 from Pedro ---
--off-topic--
You don't do a great disservice in steering Windows users to a UI paradigm they
are used to working with for the past 15 years and that they are confortable
with.
You have kids in high school
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #80 from Pedro ---
Created attachment 178973
--> https://bugs.documentfoundation.org/attachment.cgi?id=178973=edit
Paragraph dialog
Mike Kaganski screenshot in LibreOffice Design Telegram channel showing
Paragraph dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #79 from Pedro ---
Created attachment 178972
--> https://bugs.documentfoundation.org/attachment.cgi?id=178972=edit
Bullets and numbering dialog
Apparently the issue with the Tabbed UI is not restricted to the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #78 from V Stuart Foote ---
As Caolán notes:
"Its possible it makes more sense to not try and use the windows control
drawings apis and just set some dark colors and draw with the old
built-in vcl widget rendering or
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #77 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/c43c4a00089b1965c7ef69ef40c9e645dffc2e43
Related: tdf#118320
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #76 from Pedro ---
IMO (since I don't have the user data to back it up), the Tabbed UI is the most
used in Windows because it is closer to the Ribbon UI from Microsoft Office.
Thus, the only requirement to move this out of
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #75 from V Stuart Foote ---
(In reply to Caolán McNamara from comment #73)
> With "tools, options, advanced, enable experimental features" enabled this
> partial very experimental "demo" is available with the caveats
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #74 from Pedro ---
Caolán, quite frankly this looks amazing already.
The only real blocker I see is the Tabbed UI.
There a couple of other minor issues that I'll open bug reports and append
here.
Another couple of suggestion
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #73 from Caolán McNamara ---
With "tools, options, advanced, enable experimental features" enabled this
partial very experimental "demo" is available with the caveats mentioned in the
above commit message. Maybe it can help
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #72 from Commit Notification
---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/a3f400886768bf95fbd8e6b236e11d7aac393b96
Related: tdf#118320
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Commit Notification changed:
What|Removed |Added
Whiteboard||target:7.4.0
--
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #71 from Pedro ---
Implementing this behind experimental mode would be a great way to gather more
feedback and eve help from other devs, true.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #70 from Rizal Muttaqin ---
(In reply to Telesto from comment #68)
>
> Quote
> "Toggling from dark to light mode is detected, and getting some
> suitable colors for dark mode works.
>
> The titlebar will toggle into
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #69 from Pedro ---
Yes, I understand. Don't want to push for something that is still not working
properly to be included. I don't build on a daily basis, no...
--
You are receiving this mail because:
You are the assignee
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #68 from Telesto ---
(In reply to Pedro from comment #65)
> That seems perfect to me Caolan.
> Is it available on Master? How to enable it? I can test it out and provide
> you feedback.
There isn't a pre-build. You can build
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #67 from Pedro ---
https://bugs.documentfoundation.org/show_bug.cgi?id=121877
Tabbed UIs do not use theme color - keeps the default application color
This might be a challenge for dark mode support in Tabbed bar Caolan.
--
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Pedro changed:
What|Removed |Added
See Also||https://bugs.documentfounda
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #66 from Pedro ---
There might be another issue though: the Tabbed bar. I doubt it will use the
dark theme in Windows. That would probably need another set of patches to fix.
--
You are receiving this mail because:
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #65 from Pedro ---
That seems perfect to me Caolan.
Is it available on Master? How to enable it? I can test it out and provide you
feedback.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #64 from Caolán McNamara ---
Created attachment 178901
--> https://bugs.documentfoundation.org/attachment.cgi?id=178901=edit
screenshot of that approach
Its not totally hopeless to go down a route like
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #63 from Pedro ---
Wow, those are good news indeed. So it's possible to detect dark theme from
Windows 10 and it changes elements?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #62 from Caolán McNamara ---
Created attachment 178847
--> https://bugs.documentfoundation.org/attachment.cgi?id=178847=edit
some partial effect
With the experimental https://gerrit.libreoffice.org/c/core/+/131453 I get
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #61 from John Mills ---
As Microsoft Windows users are an order of magnitude larger than Linux and
MacOS combined in LibreOffice there should be feature parity in the desktop
feature set mode between OS versions. As a
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #60 from Caolán McNamara ---
(In reply to Pedro from comment #59)
> Trying to read their code in Github. Is this the relevant bit?
>
> https://github.com/winscp/winscp/blob/master/source/windows/UserInterface.cpp
following
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #59 from Pedro ---
Trying to read their code in Github. Is this the relevant bit?
https://github.com/winscp/winscp/blob/master/source/windows/UserInterface.cpp
line 376:
void __fastcall ConfigureInterface()
{
int
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #58 from Pedro ---
Github repo of WinSCP
https://github.com/winscp/winscp
https://winscp.net/eng/index.php
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #57 from Pedro ---
Another non-UWP app that supports automatic dark mode in Windows 10 is the ftp
client open source client WinSCP (GPLv3).
Maybe it would be a good idea to get in contact with other open source software
that
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #56 from Jahin Z. ---
(In reply to V Stuart Foote from comment #54)
> (In reply to V Stuart Foote from comment #53)
> >
> > "Either of two ways to address. One would be to implement support for UWP
> > theming mechanism--a
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #55 from Pedro ---
(In reply to V Stuart Foote from comment #54)
> (In reply to V Stuart Foote from comment #53)
> >
> > "Either of two ways to address. One would be to implement support for UWP
> > theming mechanism--a lot
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
Adolfo Jayme changed:
What|Removed |Added
Summary|Add support for Windows 10 |Add support for Windows
75 matches
Mail list logo