https://bugs.documentfoundation.org/show_bug.cgi?id=128502
Tor Lillqvist changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #37 from Tor Lillqvist ---
This feature is not something that I would have tested very often, and I am
sure there are problems related to it still. But best to file those as separate
bugs when encountered. In GitHub. (In
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #36 from Nicolas Christener ---
I just tested this with 6.4.0 (16) and it's working quite well now. Cool!
@Tor: there are some things I encountered (mainly not rendered tiles in one
document) - I'll add a new issue for this.
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #35 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/dead5cae834e78cacee2275c2d1ca60dac51dd7c
tdf#128502: Fix
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #34 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/online/commit/7f25109f72738706359a63c9062764699f00f568
tdf#128502: Chunk
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #33 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/65b5a9848bd01cabbbee8f6e751679a04c1da10f
tdf#128502: Avoid
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #32 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/a22cba07a470385dcb930c56c90cba81b317773e
tdf#128502: Try to
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #31 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/79c933916861d085ab844c50d7f07ba9c2d5e570
tdf#128502: Add a
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #30 from Tor Lillqvist ---
WIP patch for core at https://gerrit.libreoffice.org/c/core/+/95353
--
You are receiving this mail because:
You are the assignee for the bug.___
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #29 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/da68d45ff872cefb8606467c12aedece76a877d7
tdf#128502: Remove
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #28 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/core/commit/bda60c9b1ca6a0fbfde9f3428489f33729cc81f1
tdf#128502: Remove
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
Commit Notification changed:
What|Removed |Added
Whiteboard|target:7.0.0|target:7.0.0 target:7.1.0
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #27 from Tor Lillqvist ---
Now back on this task. After (hopefully) now having most of the work done in
the generic Online code and its iOS-specific parts to have multiple documents
open at the same time (disregarding
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #26 from Tor Lillqvist ---
Yep, will do it like that.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #25 from Nicolas Christener ---
Awesome work Tor! Thanks a lot!
I don't think making it possible to have the same document open twice is
important. Showing a proper message is IMHO enough, my proposal would go in the
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #24 from Tor Lillqvist ---
Created attachment 159996
--> https://bugs.documentfoundation.org/attachment.cgi?id=159996=edit
WIP patch
--
You are receiving this mail because:
You are the assignee for the
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #23 from Tor Lillqvist ---
Created attachment 159994
--> https://bugs.documentfoundation.org/attachment.cgi?id=159994=edit
Screenshot.
Getting closer. But I am sure there are lots of problems still.
One obvious problem is
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #22 from Tor Lillqvist ---
@Nicolas: Nope. See https://developer.apple.com/videos/play/wwdc2019/258/#
"Why? Because applications now still just share one process but may have
multiple user interface instances or scene
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #21 from Nicolas Christener ---
Out of curiosity; iOS does not spawn a second process for a second instance?
--
You are receiving this mail because:
You are the assignee for the
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #20 from Tor Lillqvist ---
Some more loosely written notes:
After now having done modifications to get rid of the lok_document global, I
notice the next hard issue: The Online code runs the lokit_main() function that
runs
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #19 from Tor Lillqvist ---
Another obvious change needed is that we shouldn't any longer let the LOOLWSD
object's run() function terminate as in the loop in the thread dispatched in
AppDelegate.mm. We should have one same
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #18 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/online/commit/b94fb53d4d52bf3f847025aebbebe0383c41ffc8
tdf#128502: Make
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #17 from Commit Notification
---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
https://git.libreoffice.org/online/commit/1525f774d9317e0f40d254b1f2af98344ba79daa
tdf#128502: Get rid
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
Commit Notification changed:
What|Removed |Added
Whiteboard||target:7.0.0
--
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #16 from Tor Lillqvist ---
And more:
> static std::shared_ptr _loKitDocument;
in the Document class in Kit.cpp. And the related getLOKDocument() and
getLOKitDocument() functions.
--
You are receiving this mail because:
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #15 from Tor Lillqvist ---
More notes to self:
More global variables that will have to be removed: In Kit.cpp:
> static std::shared_ptr document;
(Because there can be several documents open.)
In the LOOLWSD class in
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #14 from Tor Lillqvist ---
After some discussion in gerrit it became obvious that the TerminationFlag is
not that relevant after all; the current use of it in the mobile apps is based
on a misunderstanding. In web-based
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #13 from Tor Lillqvist ---
And not only are there iOS-specific global variables that need to be done away
with in ios/ios.h:
> extern int loolwsd_server_socket_fd;
> extern lok::Document *lok_document;
> extern
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #12 from Tor Lillqvist ---
No matter whether we try to support having several documents open at the same
time in some home-grown fashion that ignores the correct APIs that Apple
provides for that purpose (as described in the
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #11 from Nicolas Christener ---
I agree with you - performing well in split view with other apps would of
course be a very nice milestone!
I was just not sure, if I used the right wording to describe what the actual
goal is.
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #10 from Tor Lillqvist ---
Sure, sure, but before even attempting to make it possible to have the app
"split view with itself" (which I think is what having two documents open at
the same time in practice means), we need to
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #9 from Nicolas Christener ---
@Tor: besides the menus there is an other aspect which I think is more complex
to solve (not sure) and which is the root of the request from the users:
They want to be able to have two
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #8 from Tor Lillqvist ---
Note to self in case I jump on to something else and forget all details about
this: The menu bar becomes vertical thanks to the media query in
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #7 from Tor Lillqvist ---
s/just/hurt
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #6 from Tor Lillqvist ---
Created attachment 159612
--> https://bugs.documentfoundation.org/attachment.cgi?id=159612=edit
Screenshot
On the other hand, if I make the menu bar horizontal also in narrow windows, it
won't fit
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #5 from Tor Lillqvist ---
Created attachment 159583
--> https://bugs.documentfoundation.org/attachment.cgi?id=159583=edit
Screenshot of Split View
Currently, when you split the screen between Collabora Office and another
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
Xisco Faulí changed:
What|Removed |Added
Ever confirmed|0 |1
Status|UNCONFIRMED
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #4 from Tor Lillqvist ---
Also https://developer.apple.com/videos/play/wwdc2019/212
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #3 from Tor Lillqvist ---
Note to self: When/if starting work on this, this video is probably useful:
https://developer.apple.com/videos/play/wwdc2019/258/
--
You are receiving this mail because:
You are the assignee for
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #2 from Tor Lillqvist ---
Created attachment 155523
--> https://bugs.documentfoundation.org/attachment.cgi?id=155523=edit
Screenshot with Mail and the Collabora Office apps in SplitView on iPad
No, wait, the app *does*
https://bugs.documentfoundation.org/show_bug.cgi?id=128502
--- Comment #1 from Tor Lillqvist ---
This bug should really be split into two: One about supporting SplitView (i.e.
enabling the app to accept being used on just part of the display, instead of
always being full-screen), and another
41 matches
Mail list logo
