[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.documentfoundation.org/show_bug.cgi?id=65108 Feyza changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Depends on||70681 -- You are

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Depends on|70681 | --- Comment #24 from

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #20 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Lionel Elie Mamane committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #21 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Norbert Thiebaud committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #22 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Norbert Thiebaud committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #23 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Norbert Thiebaud committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #18 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Lionel Elie Mamane committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #19 from Michael Meeks michael.me...@collabora.com --- The ESC resolution was: Header includes vs etc. (Tml/Sberg) + easy-hack closure: + https://bugs.freedesktop.org/show_bug.cgi?id=65108 + situation reasonably

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #14 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #13) A conforming compiler is also allowed to support only 16-bit integers No. I don't really see the point in bringing up theoretical restrictions that no

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #15 from Michael Meeks michael.me...@collabora.com --- Lets decide this finally in the ESC call tomorrow :-) -- You are receiving this mail because: You are the assignee for the bug. ___

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #16 from Thomas Arnhold thomas-l...@arnhold.org --- And we don't need to clean up the whole code base. I have especially those headers in mind which are duplicated in the precompiled* header files due to the .. and .. difference. --

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #17 from Norbert Thiebaud nthieb...@gmail.com --- I would favor that the whole source tree be cleaned-up to whatever 'norm' is agreed upon. There are 3 proposed scheme, as I read it: 1/ use systematically (well except for stdio

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #10 from Thomas Arnhold thomas-l...@arnhold.org --- What's actually the conses about this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #11 from Michael Meeks michael.me...@collabora.com --- The ESC discussed this, here was the minute from 2013-06-20. I guess that it is a good time to resume work on this. AFAIK there is/was no consensus on the list - but worth

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #12 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #11) I'd suggest my compromise: using for includes in the same directory as the cxx file, and for everything else; clearly we'd need a script to identify and

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #13 from Tor Lillqvist t...@iki.fi --- A conforming compiler is also allowed to support only 16-bit integers (or other similar stuff), so I don't really see the point in bringing up theoretical restrictions that no real-life compiler

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #8 from Björn Michaelsen bjoern.michael...@canonical.com --- @Stephan: No, Im not concerned about performance, but that the MSVC interpretation of : This form instructs the preprocessor to look for include files in the same directory

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #5 from Michael Meeks michael.me...@novell.com --- Looks lovely, we should get the code into solenv/bin - Jelle is pushing to gerrit I think, but we should defer running it until we've released 4.1.2 or somesuch I think to continue to

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #3 from Thomas Arnhold tho...@arnhold.org --- Looks promising :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #4 from Jelle van der Waa je...@vdwaa.nl --- Created attachment 80800 -- https://bugs.freedesktop.org/attachment.cgi?id=80800action=edit check_headers program Hi, I've just fixed the header check perl script. I run it from the base

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #1 from Jelle van der Waa je...@vdwaa.nl --- Created attachment 80742 -- https://bugs.freedesktop.org/attachment.cgi?id=80742action=edit Output of the test program -- You are receiving this mail because: You are the assignee for

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 --- Comment #2 from Jelle van der Waa je...@vdwaa.nl --- This is the output of a test program I made to fix this issue. Atm I just need to make it search recursively through directory's. But this is the output when I run it against

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Thomas Arnhold tho...@arnhold.org changed: What|Removed |Added Whiteboard||EasyHack -- You are

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Status|UNCONFIRMED |NEW

[Libreoffice-bugs] [Bug 65108] Clean-up header includes (global/local)

https://bugs.freedesktop.org/show_bug.cgi?id=65108 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Whiteboard|EasyHack