[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Stephan Bergmann changed: What|Removed |Added Status|NEW |RESOLVED

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #31 from Stephan Bergmann --- (In reply to Stephan Bergmann from comment #20) > One idea that comes to mind is to extend include/rtl/character.hxx: For > every declaration of a function taking such a

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #30 from Commit Notification --- dilekuzulmez committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Julien Nabet changed: What|Removed |Added See Also|

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #29 from Michael Stahl --- Stephan points out that the "rsc/source/rscpp" stuff is C not C++ so you can't use toAsciiLowerCase there, put another "easytolower" there too i guess. -- You are receiving this

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #28 from Michael Stahl --- in our own C++ code, there are 2 problematic areas left: * rsc has a couple calls to tolower/toupper, one of which is for a command line flag -I these can be replaced with

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #27 from Stephan Bergmann --- (In reply to jan iversen from comment #26) > Does the revert mean there are still work to be done ? To see whether this issue is done, check whether there are any remaining

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #26 from jan iversen --- Does the revert mean there are still work to be done ? -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #25 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #24 from Commit Notification --- abdulwd committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Commit Notification changed: What|Removed |Added Whiteboard|target:5.2.0

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 jan iversen changed: What|Removed |Added Status|ASSIGNED|NEW

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Gökhan Gurbetoğlu changed: What|Removed |Added

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #15 from Gökhan Gurbetoğlu --- I am now starting a full build with locale tr_TR.UTF-8 and will post the results if it is successful. -- You are receiving this mail because: You are the

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #14 from Gökhan Gurbetoğlu --- I have completed the basic replacement of the naughty functions in .cxx files: tolower -> rtl::toAsciiLowerCase toupper -> rtl::toAsciiUpperCase islower ->

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #13 from Gökhan Gurbetoğlu --- There are a few missing replacements. Currently working on them (for all tolower, toupper, islower and isupper functions). -- You are receiving this mail

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Michael Meeks changed: What|Removed |Added Status|RESOLVED

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 jan iversen changed: What|Removed |Added Status|NEW

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #10 from Commit Notification --- krishna keshav committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Commit Notification changed: What|Removed |Added Whiteboard|target:5.2.0

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #9 from Commit Notification --- apurvapriyadarshi committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #8 from Commit Notification --- Krishna Keshav committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #7 from Commit Notification --- Krishna Keshav committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Commit Notification changed: What|Removed |Added Whiteboard|

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #6 from Gökhan Gurbetoğlu --- Apparently, replacing tolower & toupper to toAsciiLowerCase & toAsciiUpperCase respectively breaks other things and the build fails for any language. It may be

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #5 from Eike Rathke --- isupper() and islower() are equally evil. Instead use inline bool isAsciiLowerCase(sal_uInt32 code) inline bool isAsciiUpperCase(sal_uInt32 code) from rtl/character.hxx -- You are

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #4 from Gökhan Gurbetoğlu --- I am starting to apply the fix suggested by Michael and try to make it less dangerous for Turks. -- You are receiving this mail because: You are the assignee for

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #3 from Michael Meeks --- Perhaps the best way to fix this is a global / manual replace using: #include and using: inline sal_uInt32 toAsciiLowerCase(sal_uInt32 code) inline sal_uInt32

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Julien Nabet changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 --- Comment #1 from Michael Meeks --- Oh ye of little faith ;-) the demo app: /* intended for ~/a.c */ #include #include #include #include #include int main(int argc, char **argv) {

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Michael Meeks changed: What|Removed |Added See Also|

[Libreoffice-bugs] [Bug 99589] tolower / toupper - dangerous to Turks ...

https://bugs.documentfoundation.org/show_bug.cgi?id=99589 Michael Meeks changed: What|Removed |Added Keywords|