[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #40 from Michael Meeks --- Depends how big and risky it is I guess. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #39 from Tor Lillqvist --- Is the commit you refer to important enough to get into 6.1? I thought only clear bug fixes were supposed to be cherry-picked. That commit is not a such. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Aron Budea changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #38 from Aron Budea --- And the missing piece is this commit, also by Tor: https://cgit.freedesktop.org/libreoffice/core/commit/?id=f1d9aca4bf596c0a3be44483b1d60867f12683ec Tor, would it be possible to get this into libreoffice-6-1 and libreoffice-6-1-0? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Aron Budea changed: What|Removed |Added Whiteboard||target:6.2.0 target:6.1.0.1 --- Comment #37 from Aron Budea --- I checked with 6.1.0.1, and the Tools menu opens a lot quicker, albeit still not instantly (for the first time) like the other menus. I'd say that's fine, but to be sure, I'll check again with 6.1.0.2, and also with dictionaries copied to a daily build (I don't have a complete master build including dictionaries, but all relevant dictionary changes have been cherry-picked to 6.1, anyway). Thanks for the fixes, Tor! Commits in master: https://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=2d8dd0af877de8494ca9c2c027eba4a42bbc09eb https://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=846e5da4b28bb40158cfb992f3a371614e25a349 https://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=fe72d24920c8a4dcbee18925cb19e6b6625f6553 In 6.1 (one of them contains the changes from two master commits): https://cgit.freedesktop.org/libreoffice/dictionaries/commit/?h=libreoffice-6-1=d401ecde39ee763e1d28c8850c3eb6fb628d29c3 https://cgit.freedesktop.org/libreoffice/dictionaries/commit/?h=libreoffice-6-1=3b6db3f228458fa2b2f9911716b95ed0d632c9ce -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #36 from Telesto --- No repro for me :-) Version: 6.2.0.0.alpha0+ Build ID: e7d3976cb80f7e7401be071f905a764dd6cb4d6e CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-06-29_04:46:32 Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Tor Lillqvist changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #35 from Tor Lillqvist --- Aron, do you think this is fixed now? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8423 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #34 from Tor Lillqvist --- Could somebody please check if the fix to the pt-BR Lightproof helped also for the thing the initial comment actually is about? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #33 from László Németh --- (In reply to Tor Lillqvist from comment #32) > https://gerrit.libreoffice.org/#/c/56217/ should fix it. I've checked it, it did. Thanks, Tor! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #32 from Tor Lillqvist --- https://gerrit.libreoffice.org/#/c/56217/ should fix it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #31 from Tor Lillqvist --- Ah! Yes, I forgot that thing. I guess in lightproof_impl_pt_BR.py , there needs to be: > calcfunc = None > > +SMGR = None > > # check settings That's what I did when I first experimented with the smaller lightproof for en, but I forgot with pt_BR. I also now see that in pt_BR/Lightproof.py I accidentally use lightproof_impl_en.SMGR.createInstanceWithContext("com.sun.star.linguistic2.SpellChecker", currentContext) ... Will fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #30 from László Németh --- (In reply to Tor Lillqvist from comment #29) > I must confess I have no idea how to check whether the pt-BR Lightproof > works any longer after my change... Anybody? The lightproof_impl_pt_BR.py > and lightproof_pt_BR.py files are rather hard to understand. > > (I did try an equivalent change to the en Lightproof.py and that didn't > break it. But it would be nice to be able to double-check for pt-BR.) It seems, a lower case sentence starting word, ie. "uno" will be underlined by the pt-BR grammar checker. I started to check, there is a problem with the patch yet. I will fix tomorrow, if it's ok: Python exception: : module 'lightproof_impl_pt_BR' has no attribute 'SMGR', traceback follows File "/home/laci/libreoffice/instdir/share/extensions/dict-pt-BR/Lightproof.py", line 67, in doProofreading if lightproof_impl_pt_BR.SMGR == None: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #29 from Tor Lillqvist --- I must confess I have no idea how to check whether the pt-BR Lightproof works any longer after my change... Anybody? The lightproof_impl_pt_BR.py and lightproof_pt_BR.py files are rather hard to understand. (I did try an equivalent change to the en Lightproof.py and that didn't break it. But it would be nice to be able to double-check for pt-BR.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #28 from László Németh --- (In reply to Tor Lillqvist from comment #27) > I am not a Python programmer and it probably shows;) Tor, you are a better Python programmer, than me. :) Many thanks for solving this issue! I will port your solution to the Lightproof framework (https://cgit.freedesktop.org/libreoffice/lightproof/), too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #27 from Tor Lillqvist --- I am not a Python programmer and it probably shows;) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #26 from Tor Lillqvist --- Suggested fix in https://gerrit.libreoffice.org/#/c/56176/ But if you Lászlo are working on a better fix, even better. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 László Németh changed: What|Removed |Added CC||raimundo.smo...@gmail.com --- Comment #25 from László Németh --- Lightproof uses lazy loading by using __import__ for the compiled rules, but not for the extra Python codes defined in [code] parts of the grammar rule file. In fact, that I was intended for small extra functions, not a full Python grammar checker, so I didn't optimize it. The good news, that the smaller file is the problem here: :) laci@nemeth:~/libreoffice/dictionaries/pt_BR/pythonpath$ ls -lS -rw-rw-r-- 1 laci laci 4805925 nov 23 2017 lightproof_pt_BR.py -rw-rw-r-- 1 laci laci 1491297 nov 23 2017 lightproof_impl_pt_BR.py Thanks for your report and research. I will check it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #24 from Telesto --- @Tor Lillqvist Is this related to Lightproof.py or is there maybe some issue with Python itself? DrMemory (on windows) reported quite some UNADDRESSABLE ACCESS beyond heap bounds errors for python35.dll (bug 108270 comment 7) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #23 from Tor Lillqvist --- Corresponding SAL_DEBUG output, not from the exact same run, so the timing is a bit different, here the interesting bit takes over half a second, probably because I had a build ongoing at the same time: > 0.000:debug:29870:36165630: >> pyuno::Adapter::invoke(activate,4) > 0.020:debug:29870:36165630: << pyuno::Adapter::invoke() > 0.020:debug:29870:36165630: >> > pyuno::Adapter::invoke(createInstanceWithContext,1) > 0.045:debug:29870:36165630: << pyuno::Adapter::invoke() > 0.046:debug:29870:36165630: >> pyuno::Adapter::invoke(hasLocale,1) > 0.046:debug:29870:36165630: << pyuno::Adapter::invoke() > 0.046:debug:29870:36165630: >> pyuno::Adapter::invoke(doProofreading,6) > 0.101:debug:29870:36165630: << pyuno::Adapter::invoke() > 0.741:debug:29870:36165479: >> LngSvcMgr::UpdateAll() > 0.742:debug:29870:36165479:LngSvcMgr::UpdateAll() 697 > 'com.sun.star.linguistic2.SpellChecker' nNodeNames=140 > 0.820:debug:29870:36165479: >> MacSpellChecker::getLocales() > 0.840:debug:29870:36165479:MacSpellChecker::getLocales(): count=22 > 0.840:debug:29870:36165479: << MacSpellChecker::getLocales() > 0.889:debug:29870:36165479: >> MacSpellChecker::getLocales() > 0.889:debug:29870:36165479: << MacSpellChecker::getLocales() > 0.889:debug:29870:36165479:LngSvcMgr::UpdateAll() 717 nAvailLocales=140 > 0.936:debug:29870:36165479:LngSvcMgr::UpdateAll() 697 > 'com.sun.star.linguistic2.Proofreader' nNodeNames=19 > 0.937:debug:29870:36165479: >> LngSvcMgr::GetAvailableGrammarSvcs_Impl() > 0.937:debug:29870:36165479: >> pyuno::Adapter::invoke(activate,4) > 0.940:debug:29870:36165479: Lightproof.py HEAD > 0.940:debug:29870:36165479: = 2 > 0.940:debug:29870:36165479: = 3 > 1.598:debug:29870:36165479: = 4 > 1.598:debug:29870:36165479: = 5 > 1.599:debug:29870:36165479: = 6 > 1.599:debug:29870:36165479: = 7 > 1.601:debug:29870:36165479: = 8 > 1.602:debug:29870:36165479: << pyuno::Adapter::invoke() The Lightproof.py line and the following lines "== 2" etc are from instdir/LibreOffice.app/Contents/Resources/extensions/dict-pt-BR/Lightproof.py, where I added some pyuno.sal_debug() calls (an upcoming enhancement, soon in gerrit): > # Lightproof grammar checker for LibreOffice and OpenOffice.org > # 2009-2012 (c) Laszlo Nemeth (nemeth at numbertext org), license: MPL 1.1 / > GPLv3+ / LGPLv3+ > > import pyuno > pyuno.sal_debug('Lightproof.py HEAD') > pyuno.sal_debug('= 2') > import uno, unohelper, os, sys, traceback > pyuno.sal_debug('= 3') > from lightproof_impl_pt_BR import locales > pyuno.sal_debug('= 4') > from lightproof_impl_pt_BR import pkg > pyuno.sal_debug('= 5') > import lightproof_impl_pt_BR > pyuno.sal_debug('= 6') > import lightproof_handler_pt_BR > pyuno.sal_debug('= 7') > I.e. it is clear that the thing that takes lots of time is loading the lightproof_impl_pt_BR Python module. Even if what is done at this stage is just getting a list of locales that we have proofreaders for. The lightproof_impl_pt_BR module is *huge* (it has the actual data for pt-BR for Lightproof). And note that there isn't even any document with text in pt-BR open in LibreOffice... So it is totally unnecessary to waste CPU time on loading that data. The Lightproof code needs to be reorganised so that the heavy data modules are loaded only when actually needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #22 from Tor Lillqvist --- I have been looking at the delay after typing the first character in Writer in a LO session. Seeing this requires having a LO built with --with-myspell-dicts (for typical developers, no idea what it requires for people using end-user packages). It is the LightProof Python code that causes most of the slowness. Here is the "Heaviest Stack Trace" from the TimeProfiler tool in Intruments on macOS, slightly edited. The number after the dylib name is in milliseconds. One can see that the first call to pyuno::Adapter::invoke() takes about 300 ms. (And some temporary SAL_DEBUG output confirms.) > libdyld.dylib 803.0 start > soffice 803.0 main /Users/tml/lo/xxx/desktop/source/app/main.c:47 > libsofficeapp.dylib 803.0 soffice_main > /Users/tml/lo/xxx/desktop/source/app/sofficemain.cxx:167 > libvcllo.dylib 803.0 SVMain() /Users/tml/lo/xxx/vcl/source/app/svmain.cxx:233 > libvcllo.dylib 803.0 ImplSVMainHook(int*) > /Users/tml/lo/xxx/vcl/osx/salinst.cxx:225 > AppKit 803.0 NSApplicationMain > AppKit 803.0 -[NSApplication run] > libvcllo.dylib 803.0 -[VCL_NSApplication sendEvent:] > /Users/tml/lo/xxx/vcl/osx/vclnsapp.mm:101 > libvcllo.dylib 803.0 AquaSalInstance::handleAppDefinedEvent(NSEvent*) > /Users/tml/lo/xxx/vcl/osx/salinst.cxx:463 > libvcllo.dylib 803.0 ImplSVMain() > /Users/tml/lo/xxx/vcl/source/app/svmain.cxx:198 > libsofficeapp.dylib 803.0 desktop::Desktop::Main() > /Users/tml/lo/xxx/desktop/source/app/app.cxx:1641 > libvcllo.dylib 803.0 Application::Execute() > /Users/tml/lo/xxx/vcl/source/app/svapp.cxx:449 > libvcllo.dylib 803.0 ImplYield(bool, bool) > /Users/tml/lo/xxx/vcl/source/app/svapp.cxx:469 > libvcllo.dylib 803.0 AquaSalInstance::DoYield(bool, bool) > /Users/tml/lo/xxx/vcl/osx/salinst.cxx:628 > libvcllo.dylib 601.0 AquaSalTimer::callTimerCallback() > /Users/tml/lo/xxx/vcl/osx/saltimer.cxx:146 > libvcllo.dylib 601.0 Scheduler::ProcessTaskScheduling() > /Users/tml/lo/xxx/vcl/source/app/scheduler.cxx:447 > libswlo.dylib 597.0 sw::DocumentTimerManager::DoIdleJobs(Timer*) > /Users/tml/lo/xxx/sw/source/core/doc/DocumentTimerManager.cxx:146 > libswlo.dylib 597.0 SwViewShell::LayoutIdle() > /Users/tml/lo/xxx/sw/source/core/view/viewsh.cxx:711 > libswlo.dylib 597.0 SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) > /Users/tml/lo/xxx/sw/source/core/layout/layact.cxx:2097 > libswlo.dylib 597.0 SwLayIdle::DoIdleJob(SwLayIdle::IdleJobType, bool) > /Users/tml/lo/xxx/sw/source/core/layout/layact.cxx:2009 > libswlo.dylib 597.0 SwLayIdle::DoIdleJob_(SwContentFrame const*, > SwLayIdle::IdleJobType) > /Users/tml/lo/xxx/sw/source/core/layout/layact.cxx:1891 > libswlo.dylib 595.0 SwTextFrame::AutoSpell_(SwContentNode const*, int) > /Users/tml/lo/xxx/sw/source/core/txtnode/txtedt.cxx:1330 > libswlo.dylib 533.0 SwModule::CreateLngSvcEvtListener() > /Users/tml/lo/xxx/sw/source/uibase/app/swmodule.cxx:233 > libswlo.dylib 533.0 > SwLinguServiceEventListener::SwLinguServiceEventListener() > /Users/tml/lo/xxx/sw/source/uibase/uno/dlelstnr.cxx:51 > libswlo.dylib 533.0 > com::sun::star::linguistic2::LinguServiceManager::create(com::sun::star::uno::Reference > const&) > /Users/tml/lo/xxx/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38 > libuno_cppuhelpergcc3.dylib.3 533.0 non-virtual thunk to > cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, > com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/cppuhelper/source/servicemanager.cxx:0 > libuno_cppuhelpergcc3.dylib.3 533.0 > cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, > com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/cppuhelper/source/servicemanager.cxx:991 > libuno_cppuhelpergcc3.dylib.3 533.0 > cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference > const&, bool) /Users/tml/lo/xxx/cppuhelper/source/servicemanager.cxx:667 > libuno_cppuhelpergcc3.dylib.3 533.0 non-virtual thunk to > cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/cppuhelper/source/factory.cxx:0 > libuno_cppuhelpergcc3.dylib.3 533.0 > cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/cppuhelper/source/factory.cxx:374 > libuno_cppuhelpergcc3.dylib.3 533.0 > cppu::OSingleFactoryHelper::createInstanceWithContext(com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/cppuhelper/source/factory.cxx:175 > libuno_cppuhelpergcc3.dylib.3 533.0 > cppu::OSingleFactoryHelper::createInstanceEveryTime(com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/cppuhelper/source/factory.cxx:149 > liblnglo.dylib 533.0 > LngSvcMgr_CreateInstance(com::sun::star::uno::Reference > const&) /Users/tml/lo/xxx/linguistic/source/lngsvcmgr.cxx:1980 > liblnglo.dylib
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8645 --- Comment #21 from Telesto --- Related: https://gerrit.libreoffice.org/#/c/56095/ Quote from Tor Lillqvist; Patch Set 6: The Right Way to fix the problem would of course be to re-work the code path that is taking so long; why does the code insist on initialising (in some sense) stuff for languages not even used at the moment? Adding debugging printout in various places one sees that LngSvcMgr::getAvailableServices() is called for all potential language/locale combinations. Why? And org.libreoffice.comp.pyuno.Lightproof.pt_BR, org.libreoffice.comp.pyuno.Lightproof.ru_RU, etc even if no document with text in Brazi.ian Portuguese or Rssian os nowhere open. Etc. My God, it's full of crap. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #20 from Telesto--- No repro in: Version: 6.0.0.0.alpha0+ Build ID: e038dfdf05096edc0e9c38c9a686b5d23ba39352 CPU threads: 4; OS: Windows 6.29; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-09-14_23:31:01 Locale: nl-NL (nl_NL); Calc: CL only a small delay (1 or sec) Version: 6.0.0.0.alpha0+ Build ID: e038dfdf05096edc0e9c38c9a686b5d23ba39352 CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-09-14_23:35:41 Locale: nl-NL (nl_NL.UTF-8); Calc: group Please backport =). Probably: https://cgit.freedesktop.org/libreoffice/core/commit/?id=61037c622b13122de578f5ef60a3b343af3f9633 (based on the lt_xml_read_subtag_registry screenshots) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Michael Meekschanged: What|Removed |Added CC||er...@redhat.com --- Comment #19 from Michael Meeks --- Eike is the liblangtag man - and of course, we do read this large file =) I wonder - if we could do that in a thread after startup or something (?) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #18 from Telesto--- Created attachment 136240 --> https://bugs.documentfoundation.org/attachment.cgi?id=136240=edit Xcode instruments allocations and BT It's possible that the slowness is somehow caused while reading a xml file with liblangtag. 0 libsystem_malloc.dylib malloc_zone_malloc 1 libsystem_malloc.dylib malloc 2 libxml2.2.dylib xmlStrndup 3 libxml2.2.dylib xmlSAX2TextNode 4 libxml2.2.dylib xmlSAX2Characters 5 libxml2.2.dylib xmlParseCharData 6 libxml2.2.dylib xmlParseContent 7 libxml2.2.dylib xmlParseElement 8 libxml2.2.dylib xmlParseContent 9 libxml2.2.dylib xmlParseElement 10 libxml2.2.dylib xmlParseContent 11 libxml2.2.dylib xmlParseElement 12 libxml2.2.dylib xmlParseDocument 13 libxml2.2.dylib xmlDoRead 14 liblangtag.1.dylib lt_xml_read_subtag_registry /Users/demo/lode/dev/core/workdir/UnpackedTarball/langtag/liblangtag/lt-xml.c:86 15 liblangtag.1.dylib lt_xml_get_subtag_registry /Users/demo/lode/dev/core/workdir/UnpackedTarball/langtag/liblangtag/lt-xml.c:362 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Aron Budeachanged: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=91 |tion.org/show_bug.cgi?id=10 |781 |8468 --- Comment #17 from Aron Budea --- This seems to be related to bug 108468, as both deal with some kind of language component initialization, though not entirely the same: - if first the user types, and then opens Tools menu, LO only stalls once, - if first the user opens Tools menu, and then types, LO stalls both times. I'd assume preloading the language components would solve this issue as well. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #16 from Telesto--- 1. Comment 15 is obsolete: A full process Monitor output is already attached 2. There seem to be two issues combined here: 2.a disk queries related to python (bug 108698 (added as duplicate to this one) 2.b disk queries related to louno.ini (bug 108645) -> probably the main cause of the lag -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Aron Budeachanged: What|Removed |Added Keywords|bibisected, bisected, | |regression | Blocks||108636 --- Comment #15 from Aron Budea --- Let's remove the regression-related keywords, as it's not a really a regression. Linking Telesto's process monitor output from the other thread: attachment 134214. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108636 [Bug 108636] [META] Extensive file accesses -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #14 from Aron Budea--- *** Bug 108698 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 Yousuf Philips (jay)changed: What|Removed |Added Keywords||haveBacktrace Summary|Opening Tools menu is slow |Thesaurus in the Tools menu |for the first time (Writer |causes it to open slowly |only) |the first time -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs