[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Jean-Pierre Ledure changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |j...@ledure.be |desktop.org | Resolution|FIXED |--- Status|RESOLVED|REOPENED Version|6.0.0.0.alpha0+ |7.0.4.2 release --- Comment #8 from Jean-Pierre Ledure --- The above commits solved the issue in releases LO 6.0 up to LO 6.2. They are a workaround to the lack of metadata info about the current DBMS. Since the implementation described in https://bugs.documentfoundation.org/show_bug.cgi?id=118809, the applied correction is obsolete: - < 6.3: the MetaData.getProductName() returned "" for Firebird database - >= 6.3: ... "FIREBIRD (ENGINE12)" (see https://forum.openoffice.org/en/forum/viewtopic.php?f=47=61447=503397#p503365) Hence the decision to reopen the bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Drew Jensen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #7 from Drew Jensen --- verified fix with build: Version: 6.2.0.0.alpha0+ Build ID: 7f697ec27b1175ed94228155935d9ccd3cd5606c CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-07-20_13:34:48 Locale: en-US (en_US.UTF-8); Calc: group threaded DLookup is working as expected, also the faulty SQL statement in the example form has been updated for Firebird (Thank you Jean-Pierre for that). The updated FB Northwind file has been updated on the tdf nextcloud server. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 --- Comment #6 from Commit Notification --- Jean-Pierre Ledure committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e39524d4171f0ecadad5658d6e03cf44126b2a0 Access2Base - tdf#118767 Fix DLookup for Firebird It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767
--- Comment #5 from Drew Jensen ---
Opened an issue for the metadata uno service returning a null string for
productname. https://bugs.documentfoundation.org/show_bug.cgi?id=118809 added
it to 'see also' here.
Even with that property not returning a name the code could handle it by
checking the URL property. For the URL there would be at least two, embedded
and file.
So, off the code in _DFunction could maybe change to
sProductName = MetaData.getDatabaseProductName()
If sProductName = "" Then
If MetaData.URL = "sdbc:embedded:firebird"
Or Left( MetaData.URL, 13) = "sdbc:firebird" Then
sProductName = "Firebird"
End If
End If
Select Case UCase(sProductName)
Case "MYSQL", "SQLITE"
If psFunction = "" Then
sTarget = psExpr
sLimit = " LIMIT 1"
Else
sTarget = UCase(psFunction) & "(" & psExpr & ")"
End If
sSql = "SELECT " & sTarget & " AS " & sTempField & " FROM " & psDomain &
sWhere & sOrderBy & sLimit
Case "FIREBIRD"
If psFunction = "" Then
sTarget = "FIRST 1 " & psExpr
Else
sTarget = UCase(psFunction) & "(" & psExpr & ")"
End If
sSql = "SELECT " & sTarget & " AS " & sTempField & " FROM " & psDomain &
sWhere & sOrderBy
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Xisco Faulí changed: What|Removed |Added Version|6.1.0.1 rc |6.0.0.0.alpha0+ --- Comment #4 from Xisco Faulí --- Also reproduced in Version: 6.0.0.0.alpha1+ Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #3 from Xisco Faulí --- Created attachment 143627 --> https://bugs.documentfoundation.org/attachment.cgi?id=143627=edit sample file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Drew Jensen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8809 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 Jean-Pierre Ledure changed: What|Removed |Added CC||j...@ledure.be Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Jean-Pierre Ledure --- The SQL statement should not contain SELECT TOP 1 but, if I'm not wrong, SELECT FIRST 1 instead. The statement is built in module "Database" of the Access2Base library from line 1145 on: Select Case UCase(MetaData.getDatabaseProductName()) In LO 6.1 the value returned by getDatabaseProductName() is an empty string. This is clearly a bug. What does LO 6.2 return ? To test it, Drew, insert this simple code typically in the TEST module of the provided database and run it: Sub TestType MsgBox Application.CurrentDb().MetaData.getDatabaseProductName() End Sub With this answer I can easily complete the Select Case on lines 1145 etc and make the DLookup run smoothly. Thanks. JPL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error
https://bugs.documentfoundation.org/show_bug.cgi?id=118767 --- Comment #1 from Drew Jensen --- Created attachment 143550 --> https://bugs.documentfoundation.org/attachment.cgi?id=143550=edit screen shot with selection and error message -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
