[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #20 from p...@sonicviz.com ---
Ah, I didn't see that. Thanks for the link. I agree, that's the most sensible
approach right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0|

--- Comment #19 from Julien Nabet  ---
(In reply to paul from comment #17)
> In that case maybe they shouldn't be using Firebird in the first place...

That's why we put back Firebird migration at experimental.
See
http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-back-Firebird-experimental-td4265392.html#a4266137
The goal with Firebird is to use an embedded DB which isn't dependent on Java.
But Firebird has quite some limitations and IMHO, Firebird migration shouldn't
be proposed at all even in experimental since there are too much pitfalls.
Related code for this part should be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #18 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2acafef57153bfa1ade59e887a55457ba677b976%5E%21

Revert "Related tdf#127040: fix START WITH"

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #17 from p...@sonicviz.com ---
In that case maybe they shouldn't be using Firebird in the first place...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0|

--- Comment #16 from Julien Nabet  ---
(In reply to paul from comment #15)
> Great work, ty!

My patch was wrong, -1 isn't a pb to start a sequence.
The only pb seems to be record size and LO isn't responsable for this.
IMHO, I'd put NOTOURBUG since Firebird migration is now experimental.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #15 from p...@sonicviz.com ---
Great work, ty!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #14 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f4f8bccbd4e2c3979a83d5b2f49e16a99a3a2016%5E%21

Related tdf#127040: fix START WITH

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #13 from Julien Nabet  ---
Also present here:
http://www.firebirdfaq.org/faq61/

I retrieved last Firebird sources from github (see
https://github.com/FirebirdSQL/firebird/commits/master), no evolution about
src/jrd/val.h
still const ULONG MAX_RECORD_SIZE = 65535

Git grepping on this const only gives:
src/jrd/dfw.epp:5581:   if (offset > MAX_RECORD_SIZE)
src/jrd/val.h:54:const ULONG MAX_RECORD_SIZE= 65535;

First line concerns an error message.

Taking a look at the bugtracker, I noticed
http://tracker.firebirdsql.org/browse/CORE-755
So increasing record size is a very old demand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #12 from Julien Nabet  ---
According to https://firebirdsql.org/en/firebird-technical-specifications/
max record size=64kb (at least for Firebird 2.5)

confirmed in src/jrd/val.h of Firebird
53 const ULONG MAX_RECORD_SIZE = 65535;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-09-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #11 from Julien Nabet  ---
I submitted a first patch here to fix sequence start:
https://gerrit.libreoffice.org/#/c/78787/

But there's also a pb of record size.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Xisco Faulí  changed:

   What|Removed |Added

 CC||btom...@gmail.com

--- Comment #10 from Xisco Faulí  ---
@Tamas, I thought you might be interested in this issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Version|6.3.0.4 release |6.2.0.0.alpha0+

--- Comment #9 from Xisco Faulí  ---
Also reproducible in

Version: 6.1.0.0.alpha1+
Build ID: 3a801799536e6870f2fb111b1cc00b9575a35a39
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #8 from Alex Thurgood  ---
I'm guessing that this problem of rewriting the correct generator goes back
earlier than 6304, almost certainly to when the migration code was introduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #7 from Alex Thurgood  ---
Created attachment 153538
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153538=edit
Test ODB file to migrate to FB

Attaching test file from the SQL reported by Paul.

1) Load the file in LO Base.
2) Click on the Tables icon.
3) Accept the suggestion to migrate.
4) Watch it fail miserably.
5) If the user makes the mistake of assuming that saving the file might help,
in some way, e.g. to try and rescue it, a broken ODB file will be created.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #5 from p...@sonicviz.com ---
I also did read all the doc links as well as did some research. 
It was a test copy of my db I was using, and I was testing it to see how robust
it was. Not very!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #6 from p...@sonicviz.com ---
I also did read all the doc links as well as did some research. 
It was a test copy of my db I was using, and I was testing it to see how robust
it was. Not very!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

--- Comment #4 from p...@sonicviz.com ---
Thanks for the repro and confirming it. 

Agree I wasn't being "forced" but considering how twitchy it is imo it should
not even be an option in a production system at the moment. 

Also very premature to be speaking about deprecating it as well! 

I do a fair amount of db work myself, so I'm speaking both as a general user
and from a tech perspective.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Alex Thurgood  changed:

   What|Removed |Added

 Blocks||116970


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116970
[Bug 116970] [META] HSQLDB removal blockers
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Alex Thurgood  changed:

   What|Removed |Added

 Depends on||116968


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116968
[Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Alex Thurgood  changed:

   What|Removed |Added

   Priority|medium  |highest
   Severity|normal  |critical

--- Comment #3 from Alex Thurgood  ---
This is actually a pretty critical function to get right on migration. If the
user can't rely on the migration code to get the ID sequences correct, then
there are going to be a lot of angry Base users.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127040] HSQLDB to Firebird automated migration failure when IDENTITY sequence has altered start number

2019-08-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127040

Alex Thurgood  changed:

   What|Removed |Added

Summary|Database HSQLDB to Firebird |HSQLDB to Firebird
   |automated migration Failure |automated migration failure
   ||when IDENTITY sequence has
   ||altered start number

--- Comment #2 from Alex Thurgood  ---
@Paul : you should really read this before attempting the migration :

https://wiki.documentfoundation.org/Documentation/HowTo/MigrateFromHSQLDB

this is the page that the migration dialog points to when it first appears.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs