[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5880

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #43 from Xisco Faulí  ---
*** Bug 96483 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5846

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5666

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #42 from Harald Koester  ---
(In reply to sophie from comment #41)
> (In reply to Harald Koester from comment #40)
> > I checked the new drop down menu (Ver. 6.0.0.3, Win 10). 2 Comments:
> > 
> > (1) If you search for a previous or next item and the item does not exist,
> > there is no error message. I would expect a message similar, if a search
> > string is not found ("Search key not found"). Write new bug report?
> 
> As this is a navigation drop down, I wouldn't expect an error message, but
> that could be an enhancement :)

New bug report created: Bug 115600.

> > 
> > (2) If you perform a normal find text operation, the object type of the new
> > drop down menu is switched to "Repeat search". This is a bit awkward, if you
> > always have to switch back to the original object type. To my opinion the
> > item "Repeat search" can be omitted in the new menu, because all searches
> > can be done with the drop down menu for searches.
> Agreed there, I wouldn't expect the 'navigate by' to be changed, could you
> also open a bug for that? Thanks! Sophie

New bug report created: Bug 115620.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5620

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5600

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #41 from sophie  ---
(In reply to Harald Koester from comment #40)
> I checked the new drop down menu (Ver. 6.0.0.3, Win 10). 2 Comments:
> 
> (1) If you search for a previous or next item and the item does not exist,
> there is no error message. I would expect a message similar, if a search
> string is not found ("Search key not found"). Write new bug report?

As this is a navigation drop down, I wouldn't expect an error message, but that
could be an enhancement :)
> 
> (2) If you perform a normal find text operation, the object type of the new
> drop down menu is switched to "Repeat search". This is a bit awkward, if you
> always have to switch back to the original object type. To my opinion the
> item "Repeat search" can be omitted in the new menu, because all searches
> can be done with the drop down menu for searches.
Agreed there, I wouldn't expect the 'navigate by' to be changed, could you also
open a bug for that? Thanks! Sophie

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5332

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5330

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5329

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #40 from Harald Koester  ---
I checked the new drop down menu (Ver. 6.0.0.3, Win 10). 2 Comments:

(1) If you search for a previous or next item and the item does not exist,
there is no error message. I would expect a message similar, if a search string
is not found ("Search key not found"). Write new bug report?

(2) If you perform a normal find text operation, the object type of the new
drop down menu is switched to "Repeat search". This is a bit awkward, if you
always have to switch back to the original object type. To my opinion the item
"Repeat search" can be omitted in the new menu, because all searches can be
done with the drop down menu for searches.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #39 from Heiko Tietze  ---
*** Bug 112437 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #38 from Samuel Mehrbrodt (CIB)  ---
So this is fixed now, thanks Jim!

To clean the Navigator up we should consider dropping this navigation stuff
from the Navigator as we have a good working solution in the findbar now.

The only thing that is missing is that you can enter a number directly.
Although we have the "Go to page" feature for that. Just not for other
elements.

Thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.5.0|target:5.5.0 target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #37 from Commit Notification 
 ---
James Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e8208057d098f961a62efa5318a80b0d3372d2a

tdf#79167 Change search type through a drop down control

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #36 from Jim Raykowski  ---
Here is the new patch ready for comments.

https://gerrit.libreoffice.org/#/c/40776/1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #35 from Jim Raykowski  ---
Ok I've experienced some setback due to changes made to SwResId which were
included in the dev master just after I pulled the master which my work was
based on. It confused me when things were working locally and Jenkins passed
the commit and Samual commented that it looked good but Heiko's build failed.
So I now have a master that is only two days old and am close to being able to
commit again. Also I found and have fixed a bug introduced when the SwResId was
changed that makes the previous and next tooltips for the popup and sidebar
controls not correctly display a tooltip. Specifically
SwScrollNaviPopup::GetToolTip const char* id=STR_IMGBTN_ARY[nResId] I believe
needs to be [nResId-NID_START] for the index. Along that line I have made the
scrolltoprevious and scrolltonext control tooltips to use the same as the popup
so instead of 'Previous Repeat Search' the scrolltoprevious toolbar control
will show 'Continue Search Backwards'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #34 from Jim Raykowski  ---
(In reply to Yousuf Philips (jay) from comment #33)
> (In reply to Jim Raykowski from comment #31)
> > Thank you for the explaination. Currently changing the navigate by element
> > in one window does not change the dropdown item or tooltips in other window.
> > If this is correct behavior I will work on implementing.
> 
> Well LO's current behaviour is that if you had two Writer windows open and
> set a different item the Navigation window, it would change it across
> multiple windows, so i guess that should likely be the behaviour, as we'd
> want the set item to be remembered on restarting Writer. @Heiko: What's your
> take?
> 

Yousuf I again looked into the navigation element changing across windows and
indeed it does behave as you have said. When I tested this at first I did not
click over to the other window so it appeared this was not the behavior. Only
after clicking on the other window the dropdown and popup updated to the
selected navigate by element of the window they were changed in.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #33 from Yousuf Philips (jay)  ---
(In reply to Jim Raykowski from comment #31)
> Thank you for the explaination. Currently changing the navigate by element
> in one window does not change the dropdown item or tooltips in other window.
> If this is correct behavior I will work on implementing.

Well LO's current behaviour is that if you had two Writer windows open and set
a different item the Navigation window, it would change it across multiple
windows, so i guess that should likely be the behaviour, as we'd want the set
item to be remembered on restarting Writer. @Heiko: What's your take?

(In reply to Jim Raykowski from comment #32)
> Is this still desired? If so I am interested to do after this patch.

Yes this is still desired.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #30 from Yousuf Philips (jay)  ---
(In reply to Jim Raykowski from comment #29)
> Sorry, I am uncertain what 'works across multiple windows' means.

This means if you have 2 documents open in Writer and the Find toolbar open in
both, will the tooltip change work correctly in both windows if the tooltip is
changed in one window.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #32 from Jim Raykowski  ---
(In reply to Yousuf Philips (jay) from comment #9)
> In bug 89566, i've suggested the reorganization of the navigator
> window/sidebar, which included the inclusion of the navigation window
> buttons into the window/sidebar by having it as a drop down (attachment
> 113625 [details]), so it might be useful to include the same drop down as a
> control in the toolbar.

Is this still desired? If so I am interested to do after this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #31 from Jim Raykowski  ---
(In reply to Yousuf Philips (jay) from comment #30)
> (In reply to Jim Raykowski from comment #29)
> > Sorry, I am uncertain what 'works across multiple windows' means.
> 
> This means if you have 2 documents open in Writer and the Find toolbar open
> in both, will the tooltip change work correctly in both windows if the
> tooltip is changed in one window.

Thank you for the explaination. Currently changing the navigate by element in
one window does not change the dropdown item or tooltips in other window. If
this is correct behavior I will work on implementing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #29 from Jim Raykowski  ---
The dropdown now has icons and the previous and next element controls now
change tooltips to indicate what the control will navigate to. For example, if
the selected navigate by element is 'Page' the tool tips will be 'Previous
Page' and 'Next Page'. Sorry, I am uncertain what 'works across multiple
windows' means. I also made a small change so the previous and next controls
can be placed in any customizable toolbar. The dropdown can as well.

The recent commit says cannot merge. How to fix this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #28 from Heiko Tietze  ---
(In reply to Yousuf Philips (jay) from comment #27)
> > Samuel Mehrbrodt suggested it might be nice to have the icons
> > in the dropdown too.
> 
> I would suggest not doing this as it has very little benefit from a UX
> perspective and most dropdowns dont have icons. @Heiko: Whats your take?

Yes, context menus do not have icons by default. For menus in general the
Microsoft guideline is:

Consider providing menu item icons for:
* The most commonly used menu items.
* Menu items whose icon is standard and well known.
* Menu items whose icon well illustrates what the command does.

Nevertheless I'd like to see how it looks in the wild. Waiting for the upcoming
patch since I wasn't able to compile.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|

--- Comment #27 from Yousuf Philips (jay)  ---
(In reply to Jim Raykowski from comment #26)
> The toolbar listbox control and the small navigation popup window now update
> one another when a navigation item is selected by either method. I'm working
> on how to update this to the previous patch and will provide a link when
> this is done.

Sweet.

> Samuel Mehrbrodt suggested it might be nice to have the icons
> in the dropdown too.

I would suggest not doing this as it has very little benefit from a UX
perspective and most dropdowns dont have icons. @Heiko: Whats your take?

> I will be working on this as well as having the
> previous and next navigate by controls tool tips change with the selected
> navigate by element.

So how would the modified label be formatted? Would this modification work
across multiple windows?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #26 from Jim Raykowski  ---
The toolbar listbox control and the small navigation popup window now update
one another when a navigation item is selected by either method. I'm working on
how to update this to the previous patch and will provide a link when this is
done. Samuel Mehrbrodt suggested it might be nice to have the icons in the
dropdown too. I will be working on this as well as having the previous and next
navigate by controls tool tips change with the selected navigate by element.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #25 from Yousuf Philips (jay)  ---
(In reply to Jim Raykowski from comment #24)
> Yousuf, the tooltip is currently 'Navigation Element'. I would have changed
> it but didn't see your comment until after uploading patch.

'Navigation Element' seems fine to me. :D

Got a link to the commit?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #24 from Jim Raykowski  ---
Initial patch ready for comments. 

Yousuf, the tooltip is currently 'Navigation Element'. I would have changed it
but didn't see your comment until after uploading patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #22 from Michael Meeks  ---
Nice work Jim ! do you have an initial patch to share on gerrit for comments =)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #21 from Jim Raykowski  ---
I've got the drop down list toolbar control enhancement part working. 

Looking into updating the small navigation box item checked and label when
navigation element is changed in the toolbar control and vice versa.

Also to make ScrollToPrevious and ScrollToNext controls quick help change in
relation to navigation element selected instead of generic 'Previous Element',
'Next Element' messages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||marcoagpinto@mail.telepac.p
   ||t

--- Comment #20 from Yousuf Philips (jay)  ---
*** Bug 107352 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|102847  |108743


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
[Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=108743
[Bug 108743] [META] Find toolbar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #19 from sophie  ---
(In reply to Yousuf Philips (jay) from comment #18)
> Created attachment 133755 [details]
> mockup
> 
> As mentioned in comment 9, the most ideal solution is for the user not to
> have to open up the navigation dialog and simply change the search type
> through a drop down menu control.

Great, super great, this is exactly what we need :) Sophie

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #18 from Yousuf Philips (jay)  ---
Created attachment 133755
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133755=edit
mockup

As mentioned in comment 9, the most ideal solution is for the user not to have
to open up the navigation dialog and simply change the search type through a
drop down menu control.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #17 from sophie  ---
(In reply to Yousuf Philips (jay) from comment #16)
> (In reply to Miklos Vajna from comment #14)
> > Discussing this offline with Marina, and checking the current behavior on
> > master, the first thing to fix here would be to open the navigator on the
> > sidebar, not as a separate window, to be consistent with e.g. the style
> > panel, which is also opened there.
> 
> Ideally a user shouldnt to forced to open the navigator at all in order to
> modify the navigate by option, as they would have to be forced again to
> close the navigator.

The Navigate by option should recover the labels of the objects by which
navigation is possible in the Find toolbar, that way you don't have to
open/close the Navigator - Sophie

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||102847

--- Comment #16 from Yousuf Philips (jay)  ---
(In reply to Miklos Vajna from comment #14)
> Discussing this offline with Marina, and checking the current behavior on
> master, the first thing to fix here would be to open the navigator on the
> sidebar, not as a separate window, to be consistent with e.g. the style
> panel, which is also opened there.

Ideally a user shouldnt to forced to open the navigator at all in order to
modify the navigate by option, as they would have to be forced again to close
the navigator.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
[Bug 102847] [META] Quick Find, Search and Replace
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #15 from Commit Notification 
 ---
Francesco Gradi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1955bb1172508b2bf3c7476de241834ae7771359

Related: tdf#79167 sw: open the navigator in sidebar from the findbar

It will be available in 5.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #14 from Miklos Vajna  ---
Discussing this offline with Marina, and checking the current behavior on
master, the first thing to fix here would be to open the navigator on the
sidebar, not as a separate window, to be consistent with e.g. the style panel,
which is also opened there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Zenaan Harkness  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1776

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

Zenaan Harkness  changed:

   What|Removed |Added

 CC||z...@freedbms.net
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=33
   ||232

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #13 from Harald Koester  ---
Just thougt again about this problem. 

Wouldn't it be better, if the "Navigate by" button is moved from the Find bar
to the Navigate bar. Just the name says this already, that this is more
correct. 

If you like to have an object specific search in the find bar, you can look
there for an object with the exact name (e.g. find 'Table1'). But this would be
already a significant enhancement of the find function. For me the fixing of
this bug has a higher a priority.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #12 from riesslibo  ---
Tested with V5.2.0.0 alpha x86 in Win7x64 German localisation:

Still two different workspaces via sidebar and "navigate to" from the
Search Toolbar.
You are able to click different objects in one of them, the focus is set to the
clicked object, but in the other navigator workspace the active object isn't
refreshed and correctly highlighted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs