[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||dennisfrancis...@gmail.com

--- Comment #18 from NISZ LibreOffice Team  ---
*** Bug 90324 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0738

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1309

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #17 from Wolfgang Jäger  ---
(In reply to Buovjaga from comment #16)
...
> No. This is an enhancement report. The commit referenced in comment 6 adds
> something new. Thus, it is really fair to create a new report. Developers
> hate reports that turn into festivals with continued requests in dozens of
> comments.

See tdf#131309.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #15 from Wolfgang Jäger  ---
(In reply to Aron Budea from comment #14)
> Wolfgang, thanks for the comment, please open a new bug report with it, and
> reference this one in the 'See also' field.

Isn't this unnecessarily "bureaucratic"? 
I well noticed that my hints concerning the missing functionality didn't fit
exatly under the subject. There are many bug reports, however, basically
matching their subject even less. 

Surley user "burnuser" didn't just want a fake feature, but a working one, and
insofar the bug (enhancement) isn't resolved.

It would cost me another half hour probably to create an extra report, and
there are already at least two more important ones I already deferred. (I'm not
as fast as you, obviously.)

(I may surrender anyway.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Aron Budea  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Aron Budea  ---
Wolfgang, thanks for the comment, please open a new bug report with it, and
reference this one in the 'See also' field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #13 from Wolfgang Jäger  ---
(As a clarification to Wolfgang Jäger from comment #12)
> ...

Wanted to say:
> The formula entered under >Custom>Formula is passed to the respective
> control under the 'Cell range' path, but isn't put in force as long as it
> not got at least a fake edit IN THE 'Cell range' EDIT LINE.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Wolfgang Jäger  changed:

   What|Removed |Added

 CC||j...@psilosoph.de
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #12 from Wolfgang Jäger  ---
Q thread: https://ask.libreoffice.org/en/question/233184/ 
In pursuit of the mentioned thread I first noticed that the Validity feature
got the new Allow:>Custom>Formula variant.  

I tested it (though I judge it to be completely useless; 'Cell range' option
always allowed to enter a formula, and this is sufficiently made clear there)
and found with version 6.2.5.2 and with 6.4.2.1 as well that the new feature
doesnt't work as requested and expected:

The formula entered under >Custom>Formula is passed to the respective control
under the 'Cell range' path, but isn't put in force as long as it not got at
least a fake edit.

(The feature also is not mentioned in the online helöp for 6.4)

My suggsetion: Make sure that formulas entered in 'Cell range' mode are treated
properly by the Excel filters when importing/exporting, and remove it from Calc
again OR cancel the redundancy concerning 'Cell range'. First alternative
clearly preferred.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||324

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #11 from Justin L  ---
(In reply to burnuser from comment #9)
> This is a very important fix - should be documented in the changelog:
Done (since I already have an account for the wiki). Added "Data Validation now
supports custom formulas (Marco Cecchetti - Collabora) tdf#96698"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #10 from Cor Nouws  ---
(In reply to burnuser from comment #9)
> This is a very important fix - should be documented in the changelog:
> https://wiki.documentfoundation.org/ReleaseNotes/6.2#Calc

Feel free to do it yourself :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #9 from burnu...@gmail.com ---
This is a very important fix - should be documented in the changelog:
https://wiki.documentfoundation.org/ReleaseNotes/6.2#Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #8 from Commit Notification 
 ---
Zdeněk Crhonek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1394bad8ce5c5e341f824fd6cd14769ada32eeb3

uitest for bug tdf#96698 , Validity-> Custom

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Justin L  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #7 from Justin L  ---
I love it. Verified in 6.2 alpha using my personal TSC problem document. Thanks
for sticking with this Marco.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #6 from Commit Notification 
 ---
Marco Cecchetti committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f15c4b0f3c2cdfa7a72c97301ff32cc1764c54da

tdf#96698 - calc: add support for custom validation (through a formula)

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #5 from Justin L  ---
Created attachment 134080
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134080=edit
partial fix: custom formulas work as long as they don't reference the edited
cell.

Currently, custom formulas do not work at all. The only time it MIGHT work out
is working with non-zero numbers.

The larger problem here is that the formula runs on the previous data, so
whatever you typed is not being checked.  So using my example document, if you
type "comma,", then it will be accepted (since it evaluated an empty cell), but
anything you enter after that will be rejected (because it is evaluating the
old value of "comma,").

I think that is what this comment is trying to indicate.
//  for Custom, it must be eOp == SC_COND_DIRECT
//TODO: the value must be in the document !!!

It is easy to ensure that for Custom, eOp == SC_COND_DIRECT. That is why the
patch does for .xls[xb] and .xls. I'm not submitting it on it's own though
because the formula will almost always be checking it's own value, so the TODO
part is an essential part of any fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #4 from Justin L  ---
Created attachment 134044
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134044=edit
customValidation.xlsx: a couple of scenarios for testing custom validation

code pointers
-xlsx import: sc/source/filter/oox/worksheethelper.cxx
-xls import: sc/source/filter/excel/xicontent.cxx
-validation: sc/source/core/data/validat.cxx ::IsDataValid()
-validation: sc/source/core/data/conditio.cxx ::IsValidStr()

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Justin L  changed:

   What|Removed |Added

 CC||n...@cyviz.com

--- Comment #3 from Justin L  ---
*** Bug 102273 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

--- Comment #2 from burnu...@gmail.com ---
Bug is still present. No changes in bug behavior.
Testsystem:
LO 5.2.3.3 on Windows Vista

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
   Hardware|x86 (IA32)  |All
Version|unspecified |Inherited From OOo
 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Beluga  ---
Sounds fair -> NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs