[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Markus Mohrhard  changed:

   What|Removed |Added

Crash report or|["ImplOpenGLTexture::Decrea |["ImplOpenGLTexture::Decrea
crash signature|seRefCount(int)+0x1c"]  |seRefCount(int)"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Aron Budea  changed:

   What|Removed |Added

Crash report or|["ImplImage::~ImplImage()+0 |["ImplOpenGLTexture::Decrea
crash signature|x2a"]   |seRefCount(int)+0x1c"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Markus Mohrhard  changed:

   What|Removed |Added

Crash report or||["ImplImage::~ImplImage()+0
crash signature||x2a"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #16 from Markus Mohrhard  ---
(In reply to Tor Lillqvist from comment #14)
> I am not sure how this exception that was handled in VCLExceptionSignal_impl
> even showed up to the user, and was reported? At least for me, what I saw
> was this:
> 
> I start LibreOffice with an empty user profile (no instdir/cache,
> instdir/user, or \Users\Tor\AppData\Roaming\LibreOffice). It uses OpenGL,
> and works fine. Without doing anything special, I exit LibreOffice. I see no
> error messages or anything. (The exit just take a bit longer that expected,
> a few seconds, but this is noticeable only when running soffice.exe from the
> command-line of course.)
> 
> Next time I start LibreOffice, it does not use OpenGL.
> 
> *That* was the problem I was having, that OpenGL was mysteriously turned off
> for no apparent reason, with no warning or error message at all. Digging
> deeper then showed that an exception happened during exiting and this
> VCLExceptionSignal_impl was invoked that turned off OpenGL.
> 
> So I wonder how Aron here even saw any indication of a crash? Or is it so
> that if I would have actually had a document open when exiting, I would have
> seen error messages?
> 
> Anyway, whatever, the stack trace provided *does* match that which I saw
> when the exception hit, so probably best to resolve this as fixed.

The crash reporting most likely created a minidump and told him during the next
start-up that we crashed. One of our signal handlers automatically deactivates
OpenGL if the crash happened while the OpenGLWatchdog was active.

So at least if we crash now even during shut down the user should always get a
notification during the next start that we crashed and ask him to upload the
crash report. We could and most likely should of course add a note in the crash
report that this happened in an OpenGL code path. The current UseOpenGL flag
just tells us that OpenGL was activated at all and not if we crashed during an
OpenGL part.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #15 from Aron Budea  ---
(In reply to Tor Lillqvist from comment #14)
> So I wonder how Aron here even saw any indication of a crash? Or is it so
> that if I would have actually had a document open when exiting, I would have
> seen error messages?

I had no document open upon exit.
I still have the aforementioned dbgutil build from master when it was still
exhibiting this behavior (~2 weeks ago), is there anything useful I could check
about this inexplicably showing crash? (for me, this crash never got
suppressed, unlike the crash at the start, for which I now opened bug 100300)

Tor, Tomaz, thanks for looking into this, and for the fix! I'll verify it when
RC1 comes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Tor Lillqvist  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Tor Lillqvist  ---
I am not sure how this exception that was handled in VCLExceptionSignal_impl
even showed up to the user, and was reported? At least for me, what I saw was
this:

I start LibreOffice with an empty user profile (no instdir/cache, instdir/user,
or \Users\Tor\AppData\Roaming\LibreOffice). It uses OpenGL, and works fine.
Without doing anything special, I exit LibreOffice. I see no error messages or
anything. (The exit just take a bit longer that expected, a few seconds, but
this is noticeable only when running soffice.exe from the command-line of
course.)

Next time I start LibreOffice, it does not use OpenGL.

*That* was the problem I was having, that OpenGL was mysteriously turned off
for no apparent reason, with no warning or error message at all. Digging deeper
then showed that an exception happened during exiting and this
VCLExceptionSignal_impl was invoked that turned off OpenGL.

So I wonder how Aron here even saw any indication of a crash? Or is it so that
if I would have actually had a document open when exiting, I would have seen
error messages?

Anyway, whatever, the stack trace provided *does* match that which I saw when
the exception hit, so probably best to resolve this as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #13 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3217029eaf355ee059dc4d371cf1e65c346405dd=libreoffice-5-2

tdf#100184 add missing changes to FixedTextureAtlas

It will be available in 5.2.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #12 from Tomaz Vajngerl  ---
Indeed, changes to FixedTextureAtlas aren't present in 5-2 but they are in
master. I must have missed the file when cherry-picking and rebasing. I have
added them back in [1].

[1] https://gerrit.libreoffice.org/26080

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #11 from Tomaz Vajngerl  ---
Maybe I made a mistake when backporting to 5.2 or I missed something. I'll
check today.Maybe I made a mistake when backporting to 5.2 or I missed
something. I'll check today.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #10 from Aron Budea  ---
These are the steps I take. There are two different crashes, see linked crash
reports (thanks, Markus :)).

-delete user profile
-start Writer

=> possible result 1: Writer starts fine, UI render is default => rinse and
repeat from start

=> possible result 2: splash screen shows, very briefly disappears and
reappears, then empty LibreOfficeDev Document Recovery dialog is shown

-press OK
-Crash Report dialog appears, press Send Crash Report (
http://crashreport.libreoffice.org/stats/crash_details/b9ee7997-479b-47fa-8cea-c725dcc28f72
), then Close
-LibreOfficeDev main application appears, UI render is GL
-Exit

=> crash (LibreOfficeDev has stopped working etc.)

-on next start Crash Report dialog appears, press Send Crash Report (
http://crashreport.libreoffice.org/stats/crash_details/820f75cf-3df2-4c87-a0ab-9fcf7f2d4377
<= same crash as in the attached backtrace, this is what's been discussed so
far), then Close
-LibreOfficeDev main application appears, UI render is default.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Aron Budea  changed:

   What|Removed |Added

 CC||markus.mohrhard@googlemail.
   ||com

--- Comment #9 from Aron Budea  ---
Note that I'm still getting those weird crashes upon start as well (with 5.2
beta2). I chose the title of my bug report for a reason.

CCing Markus, so he knows that the crash reports I'm uploading are related to
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #8 from Tor Lillqvist  ---
Hmm, in master, on the other hand, I can't reproduce the problem any longer.
There I get no unhandled exception when exiting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #7 from Tor Lillqvist  ---
Unfortunately that commit did not seem to fix the problem. In 5.2, for which I
happen to have a fresh build with the above commit, I still get a exception
when exiting, that gets handled by the VCLExceptionSignal_impl(). A
SAL_DEBUG_TRACE() there produces this backtrace which sadly doesn't seem very
useful:

debug:7936:6912: > VCLExceptionSignal_impl at:
8: osl_backtraceAsString - 0x6e24f710
7: `anonymous namespace'::log - 0x6e21d1f0
6: sal_detail_log - 0x6e21d820
5: VCLExceptionSignal_impl - 0x6ad70830
4: callSignalHandler - 0x6e21d8b0
3: `anonymous namespace'::signalHandlerFunction - 0x6e267e60
2: UnhandledExceptionFilter - 0x7689f320
1: LdrSetAppCompatDllRedirectionCallback - 0x76fabb00
0: RtlUnicodeStringToInteger - 0x76f85b90

and the VCLExceptionSignal_impl() then calls OpenGLZone::hardDisable().

If I instead attach soffice.bin to VS, and exit LO, VS catches an unhandled
exception  0xC005: Access violation reading location 0xDDE5. Its
backtrace:

>   vcllo.dll!std::vector::size() Line 1148   
> C++
vcllo.dll!ImplOpenGLTexture::DecreaseRefCount(int nSlotNumber) Line 246
C++
vcllo.dll!OpenGLTexture::operator=(const OpenGLTexture & rTexture) Line
591 C++
vcllo.dll!OpenGLSalBitmap::Destroy() Line 244   C++
vcllo.dll!OpenGLSalBitmap::~OpenGLSalBitmap() Line 125  C++
vcllo.dll!OpenGLSalBitmap::`scalar deleting destructor'(unsigned int)  
C++
vcllo.dll!ImpBitmap::~ImpBitmap() Line 39   C++
vcllo.dll!ImpBitmap::`scalar deleting destructor'(unsigned int) C++
vcllo.dll!std::_Ref_count::_Destroy() Line 159   C++
vcllo.dll!std::_Ref_count_base::_Decref() Line 119  C++
vcllo.dll!std::_Ptr_base::_Decref() Line 344 C++
vcllo.dll!std::shared_ptr::~shared_ptr() Line 611
C++
vcllo.dll!Bitmap::~Bitmap() Line 126C++
vcllo.dll!BitmapEx::~BitmapEx() Line 188C++
vcllo.dll!std::pair::~pair()  C++
vcllo.dll!std::pair
>::~pair >()C++
vcllo.dll!std::pair
>::`scalar deleting destructor'(unsigned int) C++
vcllo.dll!std::allocator,void *> >::destroy >(std::pair > * _Ptr) Line 608C++
   
vcllo.dll!std::allocator_traits,void *> > >::destroy
>(std::allocator,void *> > & _Al, std::pair > * _Ptr) Line 731  C++
   
vcllo.dll!std::_Wrap_alloc,void *> > >::destroy >(std::pair > * _Ptr) Line 879 C++
vcllo.dll!std::_List_buy,std::allocator >
>::_Freenode(std::_List_node,void *> * _Pnode) Line 853 C++
vcllo.dll!std::list,std::allocator > >::clear() Line 1505   C++
   
vcllo.dll!std::_Hash,std::_Uhash_compare,std::allocator >,0>
>::clear() Line 718  C++
vcllo.dll!ImplImageTree::shutDown() Line 268C++
vcllo.dll!DeInitVCL() Line 394  C++
vcllo.dll!ImplSVMain() Line 204 C++
vcllo.dll!SVMain() Line 214 C++
sofficeapp.dll!soffice_main() Line 165  C++
soffice.bin!sal_main() Line 48  C
soffice.bin!main(int argc, char * * argv) Line 47   C

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #6 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6efb6fa31270adc84b5884cd4a84e1a3296d535d=libreoffice-5-2

tdf#100184 fix the lifecycle of a texture in an atlas

It will be available in 5.2.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

--- Comment #5 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8dcf60ecbe9c159831ece3b6201882f1d0033472

tdf#100184 fix the lifecycle of a texture in an atlas

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100184] OpenGL-related crash upon exit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100184

Tor Lillqvist  changed:

   What|Removed |Added

Summary|Weird, likely   |OpenGL-related crash upon
   |OpenGL-related crashes upon |exit
   |startup/exit|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs