https://bugs.documentfoundation.org/show_bug.cgi?id=101566

            Bug ID: 101566
           Summary: [I18N] Untranslated button names on the Track changes
                    toolbar
           Product: LibreOffice
           Version: 5.3.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Writer
          Assignee: libreoffice-bugs@lists.freedesktop.org
          Reporter: kelem...@ubuntu.com

Created attachment 126863
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126863&action=edit
Screenshot of the problem in 5.3 master

Enable the Track Changes toolbar in Writer.
Right click on the toolbar, select Visible Buttons. The list of the buttons
appears in English. 
These strings are not translatable, see for example:
https://translations.documentfoundation.org/hu/libo_ui/translate/#search=Regular%20Comment&sfields=source

These are coming from sw/uiconfig/swriter/toolbar/changes.xml
and were introduced here: 
https://cgit.freedesktop.org/libreoffice/core/commit/sw/uiconfig/swriter/toolbar/changes.xml?id=bba15935842071289f6fbf9edef409b605254508

I find it interesting that there are no other toolbars using non-default names
with the toolbar:text attribute:

gabor@dome:~/src/core$ find . -path "*toolbar*xml" -print0 | xargs -0 grep
"toolbar\:text"
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:ShowTrackedChanges" toolbar:text="Show"
toolbar:helpid="10624"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:TrackChanges" toolbar:text="Record" toolbar:helpid="10725"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:PreviousTrackedChange" toolbar:text="Previous"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:NextTrackedChange" toolbar:text="Next"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:AcceptTrackedChange" toolbar:text="Accept"
toolbar:helpid="10625"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:RejectTrackedChange" toolbar:text="Reject"
toolbar:helpid="10626"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:AcceptTrackedChanges" toolbar:text="List"
toolbar:helpid="10622"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:InsertAnnotation" toolbar:text="Regular Comment"
toolbar:helpid="10625"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:CommentChangeTracking" toolbar:text="Change Comment"
toolbar:helpid="10625"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:ProtectTraceChangeMode" toolbar:text="Protect"
toolbar:helpid="10625"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:CompareDocuments" toolbar:text="Compare"/>
./sw/uiconfig/swriter/toolbar/changes.xml: <toolbar:toolbaritem
xlink:href=".uno:MergeDocuments" toolbar:text="Merge" toolbar:visible="false"/>
gabor@dome:~/src/core$ 

Maybe it would provide for a consistent UX if we would just drop these button
nicknames altogether.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to