[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks||98259, 85811
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |philip...@hotmail.com
   |desktop.org |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #8 from Commit Notification 
 ---
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2075a1e4a4001300afeef3bf1c9c285022ed7473

tdf#101951 Add shortcuts to common alignment shortcuts

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #7 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #1)
> The difference is that .uno:*Para commands work only with text, but
> .uno:CommonAlign* (as the name suggest) are universal and work for shapes
> too, i.e. if you select 2 shapes, it will do the same as the commands in
> alignmentbar toolbar.

Yes that is true, but .uno:Common* dont work in impress/draw on shapes or text,
so there are two Align submenu entries in impress, 1 for text and 1 for
objects. On the other hand .uno:*Para dont work in calc cells.

I've submitted a patch to assign the shortcuts for Common* which will benefit
writer and calc - https://gerrit.libreoffice.org/28724

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #6 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #5)

> I assume you mean formatting toolbar.
> 

Sorry, yes assigned to button widgets toolbar and sidebar, just not yet to menu
entries.

> The Para commands are set at the module level, so we should be able to
> assign the Common ones at LibreOffice level and the shortcuts will appear.

So adding for the Common and not adding the Para to the menus should cover keep
the UI consistent. Only question is if using the Common command on Paragraphs
actually gives the same result--visually it seems to in some simple
comparisons.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #5 from Yousuf Philips (jay)  ---
(In reply to V Stuart Foote from comment #3)
> Are the same shortcuts assigned to the Common as to the Para .uno commands?

No the Common ones dont have shortcuts assigned to them.

> Shortcuts (Formatting menu and Sidebar Properties deck) look to be:

I assume you mean formatting toolbar.

The Para commands are set at the module level, so we should be able to assign
the Common ones at LibreOffice level and the shortcuts will appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #4 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #2)
> So do you think i should also include the *Para commands in the menu, so
> people can discover the shortcuts?

Shortcuts should be shown, but don't think a second set is needed--if shortcuts
are otherwise the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #3 from V Stuart Foote  ---
Not sure they are needed. 

Are the same shortcuts assigned to the Common as to the Para .uno commands?

Shortcuts (Formatting menu and Sidebar Properties deck) look to be:
+L -- left
+E -- centered
+R -- right
+J -- justified.

But notice the mnemonic accelerator on the Format -> Align menu for Centered is
currently "C" and that no shortcuts are listed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #2 from Yousuf Philips (jay)  ---
So do you think i should also include the *Para commands in the menu, so people
can discover the shortcuts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101951] Shortcuts dont appear in menu for horizontal alignment options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101951

--- Comment #1 from Maxim Monastirsky  ---
Shortcuts are assigned for .uno:LeftPara, .uno:CenterPara, .uno:RightPara,
.uno:JustifyPara, but the menu has different commands: .uno:CommonAlignLeft,
.uno:CommonAlignHorizontalCenter, .uno:CommonAlignRight,
.uno:CommonAlignJustified.

The difference is that .uno:*Para commands work only with text, but
.uno:CommonAlign* (as the name suggest) are universal and work for shapes too,
i.e. if you select 2 shapes, it will do the same as the commands in
alignmentbar toolbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs