https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Kevin Suo changed:
What|Removed |Added
CC||freelikeabird2...@gmail.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
V Stuart Foote changed:
What|Removed |Added
CC||helpmep...@gmail.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #69 from Kevin Suo ---
(In reply to Armin Le Grand from comment #67)
No, the concatenation will only be applied to TextElements, and only apply if
the following conditions are met:
1. The current char and next char use the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #68 from V Stuart Foote ---
(In reply to Kevin Suo from comment #66)
> I am testing locally.But V Stuart Foote could you upload some a simple doc
> covering most of the cases you have mentioned?
>
The 1945 UN Charter,
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #67 from Armin Le Grand ---
@Kevin, Stuart: It's not really a gap - a pic would say more than 1000 words,
but...
- if next char starts at the same pos (test before) it covers current -> bad
- it's about 'guessing' the width
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #66 from Kevin Suo ---
I am testing locally.But V Stuart Foote could you upload some a simple doc
covering most of the cases you have mentioned?
I have already tweaked to combine the space chars (which will result in the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #65 from V Stuart Foote ---
@Armin, Kevin, *
(In reply to Armin Le Grand from comment #64)
> ... It may even be that this needs
> adaption e.g. vertical decisions for chinese...? I do not know. Also
> possible that spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #64 from Armin Le Grand ---
Created attachment 173657
--> https://bugs.documentfoundation.org/attachment.cgi?id=173657=edit
revvised solution with adapting width during concatenation
Have to hand in a value that describes
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #63 from Armin Le Grand ---
Adapting rCurGC.Transformation as needed streches texts in result -> so not
intended (?), width scale *has* to stay relative to fontScaling. So need to
internally add a correction value used to
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #62 from Armin Le Grand ---
Thanks for the clear description, made it very effective to start debugging.
I guess I found it -> I implied that rCurGC.Transformation gets *adapted* when
conactenation happens in the true case,
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #61 from Kevin Suo ---
The failing to concatenate "Tim" and "e" may due to the issue as discussed
here:
https://gitlab.freedesktop.org/poppler/poppler/-/issues/418
--
You are receiving this mail because:
You are the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #60 from Kevin Suo ---
(In reply to Armin Le Grand from comment #59)
Thank you for your suggested patch. I checked, but it does not work for some
chars.
For instance:
On The current master there is a test file named
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Armin Le Grand changed:
What|Removed |Added
CC||armin.le.gr...@me.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #58 from Kevin Suo ---
(In reply to Armin Le Grand from comment #57)
Could you prepare the revised patch?
--
You are receiving this mail because:
You are the assignee for the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #57 from Armin Le Grand ---
Ah - sorry, one note to that: Of course since internally the Y-Axis goes down,
to get the lower-left edge you would need to multiply Point(0,1) with the
matrices - but in the given example working
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #56 from Armin Le Grand ---
To comment 53: I would not recommend to remove the transformation comparison. I
have made bad experiences with guesses like 'will nearly never happen'. That
often is true, but when you multiply
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #55 from Kevin Suo ---
Created attachment 173618
--> https://bugs.documentfoundation.org/attachment.cgi?id=173618=edit
rtl.pdf (a simplified RTL file which can be used as a unittest case)
--
You are receiving this mail
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #54 from Kevin Suo ---
Created attachment 173617
--> https://bugs.documentfoundation.org/attachment.cgi?id=173617=edit
screenshot showing the PDF open in draw, with the "not perfect" patch applied
--
You are receiving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #53 from Kevin Suo ---
Created attachment 173616
--> https://bugs.documentfoundation.org/attachment.cgi?id=173616=edit
tdf104597-not-perfect-patch.diff
Good news is that we are almost there.
With the attached modification
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #52 from Kevin Suo ---
(In reply to V Stuart Foote from comment #51)
As I said, if all the following evaluate true:
'''
if( (pCur->FontId == pNext->FontId || isSpaces(pNext)) &&
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #51 from V Stuart Foote ---
(In reply to Alex Cohn from comment #50)
> > X(curr) + currCharWitdh <-similar-> to X(next)
>
> only note that for an RTL sequence, this will probably be
>
> X(curr) - currCharWitdh
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #50 from Alex Cohn ---
> X(curr) + currCharWitdh <-similar-> to X(next)
only note that for an RTL sequence, this will probably be
X(curr) - currCharWitdh <-similar-> to X(next)
--
You are receiving this mail because:
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #49 from Armin Le Grand ---
It's a 3x3 homogen transformation matrix as known from linear algebra and used
in CG systems. Usually only 3x2 is used since the last line may host
perspective change stuff, but usually not used in
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #48 from Thorsten Behrens (allotropia) ---
(In reply to Kevin Suo from comment #47)
> Apparently rCurGC.Transformation != rNextGC.Transformation. The different is
> in the (0,2): one is 46240, the other one is 46690. What are
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #47 from Kevin Suo ---
Further info:
If xpdf generated the following output:
drawChar 462.40 770.989000 466.90 770.989000 1.00 0.00 0.00
1.00 12.00 ة
then sdext pdfimport will produce the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #46 from Kevin Suo ---
Further info:
If xpdf generated the following output:
drawChar 462.40 770.989000 466.90 770.989000 1.00 0.00 0.00
1.00 12.00 ة
then sdext pdfimport will produce the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #45 from Kevin Suo ---
(In reply to V Stuart Foote from comment #44)
Well, below is my observation these days. I may be wrong, but I think these are
helpful to those who are interested:
1. The "mirrorString" function is
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
V Stuart Foote changed:
What|Removed |Added
CC||suokunl...@126.com
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #43 from shmuel.glo...@gmail.com ---
I am just waiting for this issue to be resolved. It's top priority for many
users. It really handicaps the use of LibreOffice in Israel and the whole
Middle East.
--
You are receiving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #42 from Buovjaga ---
(In reply to Alex Cohn from comment #41)
> @Justin is there an established way to look for such sponsor?
There is no established way. Ideally the sponsors would come looking instead of
the other way
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #41 from Alex Cohn ---
@Justin is there an established way to look for such sponsor?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Justin L changed:
What|Removed |Added
Status|ASSIGNED|NEW
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Thorsten Behrens (CIB) changed:
What|Removed |Added
Assignee|libreoffice-b...@lists.free |t...@libreoffice.org
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
Priority|high|highest
--- Comment #31 from
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #30 from Jack ---
Five years, seven bug reports, three major version number increments, and many
replies later, finally this is being taken seriously.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #29 from Eyal Rozenberg ---
> Changing priority to 'high' since the number of duplicates is 5 or higher
Thank you; this is very significant to us.
Quoting myself from one of the dupes:
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
CC||ati...@live.com
--- Comment #25
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
CC||yousifjka...@yahoo.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
CC||shiv...@hotmail.com
--- Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
CC||nasrinkhaks...@gmail.com
---
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
Severity|normal |major
Priority|medium
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
Xisco Faulí changed:
What|Removed |Added
Severity|minor |normal
--
You are receiving this
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #23 from Fahad Al-Saidi ---
This bug affects my workflow a lot. I hope someone can fix it. Thanks in
advance.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #22 from vv...@yandex.ru ---
TextElements are created just in one place: inside processGlyphLine function.
Also there they are placed inside new FrameElement.
Characters, which are processed inside processGlyphLine call are
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #21 from vv...@yandex.ru ---
Another possibility is that transformation check may be not needed at all now
since all characters inside paragraph have the same transformation (except for
translation part).
--
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #20 from vv...@yandex.ru ---
I was fixing scale in my commit.
So, maybe, scaling for text elements should be skipped.
While staying intact for images.
More investigation is needed.
--
You are receiving this mail because:
You
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #19 from Justin L ---
(In reply to vvort from comment #18)
> DrawXmlOptimizer::optimizeTextElements() fails to concatenate TextElements
because before notTransformed() previously returned true, and now it returns
false. (same
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #18 from vv...@yandex.ru ---
Characters are processed one by one because
DrawXmlOptimizer::optimizeTextElements() fails to concatenate TextElements.
Inside of that function check for transformation equality exists:
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #17 from Justin L ---
(In reply to vvort from comment #16)
> Are you sure that image transformations are related to text processing?
You can bibisect with comment 15's document to verify.
I don't know the hows or the whys,
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #16 from vv...@yandex.ru ---
Are you sure that image transformations are related to text processing?
--
You are receiving this mail because:
You are the assignee for the bug.___
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #15 from Justin L ---
Created attachment 153035
--> https://bugs.documentfoundation.org/attachment.cgi?id=153035=edit
arabic RTL3.pdf: shows when mirroring changed from paragraphs to individual
characters
(In reply to
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
--- Comment #14 from Justin L ---
(In reply to V Stuart Foote from comment #13)
> Not clear if the (isRTL) is applied logically to do the mirror::String()?
> I get confused walking through the code.
I agree that it doesn't seem to
https://bugs.documentfoundation.org/show_bug.cgi?id=104597
V Stuart Foote changed:
What|Removed |Added
Blocks||43808
53 matches
Mail list logo
