[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |ba...@caesar.elte.hu
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Timur  changed:

   What|Removed |Added

Version|5.2.0.0.alpha1  |5.1.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Aron Budea  changed:

   What|Removed |Added

   Priority|medium  |high
 Blocks||83946
   Severity|minor   |normal

--- Comment #13 from Aron Budea  ---
The problem is with the following piece of change:
https://cgit.freedesktop.org/libreoffice/core/diff/sw/source/core/doc/DocumentContentOperationsManager.cxx?id=db17d3c17c40d6b0e92392cf3c6e343d1d17b771

The pointer in pDelPam actually needs to be preserved here:
pDelPam.reset(new SwPaM( *pCpyStt, pDelPam.get() ));

The following change fixes the behavior by releasing the smart pointer:
pDelPam.reset(new SwPaM( *pCpyStt, pDelPam.release() ));

Is the code otherwise correct? I'm surprised working with an invalid pointer
didn't cause a serious issue.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Aron Budea  changed:

   What|Removed |Added

 CC||gti...@gmail.com

--- Comment #12 from Aron Budea  ---
*** Bug 116199 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||noelgran...@gmail.com,
   ||r...@post.cz

--- Comment #11 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin; Could you possibly take a look at this one? Thanks


86334d4aee98252413f81e7fe4e2e0fbd01346de is the first bad commit
commit 86334d4aee98252413f81e7fe4e2e0fbd01346de
Author: Norbert Thiebaud 
Date:   Thu Nov 12 10:00:12 2015 -0800

source sha:db17d3c17c40d6b0e92392cf3c6e343d1d17b771

author  Noel Grandin  2015-11-10 11:36:34 (GMT)
committer   Noel Grandin 2015-11-11 07:16:20
(GMT)
commit  db17d3c17c40d6b0e92392cf3c6e343d1d17b771 (patch)
tree9d562fcf764e7717df9585ef0e735a12ea4aaa16
parent  2ce9e4be4a438203382cb9cca824ce3e90647f3a (diff)
new loplugin: memoryvar
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Version|5.3.1.2 release |5.2.0.0.alpha1

--- Comment #10 from Xisco Faulí  ---
Issue reproduced in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

but not in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #9 from Buovjaga  ---
(In reply to Frederic Parrenin from comment #8)
> If you want to copy deleted text, you discard the changes, then copy/paste.
> The problem again is that it works as I expect when I start from a fresh LO
> document: deleted text is NOT copied. So there is a least a consistency
> problem here.

Ok, in my first test with a fresh document it was copied, but now I tried again
and it was not copied..

I noticed that in the example docx, the final surveys is not copied.

..and now I noticed this is a regression: it works like expected in 3.6.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 595e3971b130addbc6e5b749f53fc681fa6bc031
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 27th 2016

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

--- Comment #8 from Frederic Parrenin 
 ---
If you want to copy deleted text, you discard the changes, then copy/paste.
The problem again is that it works as I expect when I start from a fresh LO
document: deleted text is NOT copied. So there is a least a consistency problem
here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #7 from Buovjaga  ---
Frederic: what if I want to copy deleted words? You would take that away from
me?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

--- Comment #6 from Frederic Parrenin 
 ---
If you start a fresh .odt file, it works as expected, i.e. the changes are
copied.
So this is really a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from m.a.riosv  ---
Sorry, I don't agree it is a bug, now we have the option to copy with/without
the changes changing the 'Show', if it works as you like there is no option to
copy with the changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

--- Comment #4 from Frederic Parrenin 
 ---
Sorry but I don't understand what you are meaning.
Were you able to reproduce the bug or not?
Why did you set the bug to "Needinfo"? Which info do you need from me?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

--- Comment #3 from m.a.riosv  ---
I'd read it, but if it's done how you want, how can be copied all?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

--- Comment #2 from Frederic Parrenin 
 ---
Yes, it works when you do not show the track changes.
But if you show them and copy some text, it will copy the words that have been
deleted in the track changes.
Please read again carefully my steps to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Hidden the revisions works fine for me.
Menu/Edit/Track changes/Show

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs