[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

--- Comment #4 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a7057250c8f73fdfb4c65a7525d17e9770459df

tdf#108210: Allow to ignore a lock file if there's no filesystem lock

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

--- Comment #3 from Aron Budea  ---
(In reply to Aron Budea from comment #2)
> 3. If there's a lock file, and a different user tries to access the file:
>  there is a dialog with text STR_LOCKFAILED_MSG from [1], choices are "Open
> Read-Only", "Open Copy", "Cancel".

I pasted the wrong id, the correct text for this is STR_OPENLOCKED_MSG.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Aron Budea  changed:

   What|Removed |Added

   Severity|minor   |normal

--- Comment #2 from Aron Budea  ---
Elaborating on the dialog and choices:
1. If there's a lock file, and the same user tries to access the file from the
same LO path: file is opened without confirmation dialog.
2. If there's a lock file, and the same user tries to access the file from a
different LO path:
 there is a dialog with text STR_ALREADYOPEN_MSG from [1], choices are "Open
Read-Only", "Open", "Cancel".
3. If there's a lock file, and a different user tries to access the file:
 there is a dialog with text STR_LOCKFAILED_MSG from [1], choices are "Open
Read-Only", "Open Copy", "Cancel".

An idea I had is to only check system lock if that's what the code relies on
with that file system. I discussed with Mike, one concern is that we can't
really know for sure if the system lock is reliable underneath. His conclusion
was that first the code should check if the file can be opened for writing, and
then in the dialog allow the user the choice to open the file. So the dialog
shouldn't be completely eliminated. In this case an extra text is needed,
because the current ones don't cover this option (they mention situation and
choices).

[1] https://opengrok.libreoffice.org/xref/core/uui/inc/strings.hrc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Aron Budea  changed:

   What|Removed |Added

 Blocks||114300


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
[Bug 114300] [META] Bugs and enhancements involving lock files or file locking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|5.4.0.0.alpha1+ |Inherited From OOo
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
Repro.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.5.0.0.alpha0+
Build ID: c855400e9686ddd8bcba5691393f839f6f52c966
CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on June 2nd 2017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs