[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #16 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/43f983d08d66520536980339f33ef44d5eec35f6

tdf#115026 sw tableAutoFormat: don't clear break/keep

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #15 from Justin L  ---
(In reply to Jim Raykowski from comment #13)
> One way we can can work around this case is by not setting the break here
> [1] if it is SvxBreak::NONE.  

Exactly.  https://gerrit.libreoffice.org/#/c/83879

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #14 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #13 from Jim Raykowski  ---
This is related to the table properties text flow:

Table > Properties... > Text Flow tab > Break checkbox and break type radio
buttons.

One way we can can work around this case is by not setting the break here [1]
if it is SvxBreak::NONE.  

[1]
https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/tblafmt.cxx#906

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page (& deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #12 from Telesto  ---
Repro
Version: 6.2.0.0.alpha0+
Build ID: 8e9d43546c8e46ea635472ddf07f5c183dc13360
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-07-11_23:34:15
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded

STR
1. Open Writer
2. Insert a page break -> CTRL+ENTER
3. Insert a table with a table style applied (non-default)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #11 from Telesto  ---
Repro with:
Version: 6.1.0.0.alpha0+
Build ID: 2ed7c02478968852d7d39c2c4677f2ecf3441bc7
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-22_01:00:56
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Telesto  changed:

   What|Removed |Added

 Blocks||107553


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107553
[Bug 107553] [META] Writer table styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5573

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #10 from Jim Raykowski  ---
Created attachment 139232
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139232=edit
commit that introduce Break table-level property recording

Here may be where this behavior began.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #9 from Jim Raykowski  ---
I have located what seems to be the cause of this bug. 

tblafmt.cxx

void SwTableAutoFormat::RestoreTableProperties(SwTable ) const
{
SwTableFormat* pFormat = table.GetFrameFormat();
if (!pFormat)
return;

SwDoc *pDoc = pFormat->GetDoc();
if (!pDoc)
return;

SfxItemSet rSet(pDoc->GetAttrPool(), aTableSetRange);

//rSet.Put(m_aBreak);  < comment this line

When this line of code is removed a table inserted at the start of a new page
behaves as expected. I don't really understand why. My knowledge of itemsets
and pools and ranges is not strong.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #8 from Jacques Guilleron  ---
Confirm the behavior from Comment 6 with
LO 3.6.0.4 (Build ID: 932b512)
and upper versions
but not with
LO 3.5.7.2 Version ID : 3215f89-f603614-ab984f2-7348103-1225a5b
under Windows 7 Home.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Telesto  changed:

   What|Removed |Added

   Keywords||bibisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Telesto  changed:

   What|Removed |Added

 Attachment #139115|0   |1
is obsolete||

--- Comment #7 from Telesto  ---
Created attachment 139143
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139143=edit
Bibisect log

I would suspect the patch for bug 49342...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Telesto  changed:

   What|Removed |Added

   Keywords|bisected|
 CC||xiscofa...@libreoffice.org
Version|6.0.0.2 rc  |4.0.0.3 release

--- Comment #6 from Telesto  ---
Found in
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

but not in
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5

1. Open Writer
2. Insert a page break (CTRL+ENTER)
3. Add a table on the next page
4. Menu Table -> Autoformat styles -> Choose a style and apply

Table moves to previous page

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #5 from Jim Raykowski  ---
(In reply to Yousuf Philips (jay) from comment #4)
> @Jim,
> Seems your apply default table style to inserted table patch has a
> regression.
> 
> https://gerrit.libreoffice.org/#/c/46842/

Hi Jay,

This behavior can be reproduced in versions before the patch was merged by
manually performing what the patch does automatically. (Apply a style to a
table)

I have reproduced it in the following two versions:
Version: 5.4.4.2, Build ID: 1:5.4.4~rc2-0ubuntu0.16.04.1~lo1 
and
Version: 6.0.0.0.beta2 (x64) mswindows

Here are the steps to reproduce in pre patched versions:
1. Open a version of Writer without this patch
2. Open Sidebar -> View > Sidebar
3. Click on Styles deck icon
4. Click on Tables Styles icon in Styles Panel
5. Insert a page break -> CTRL+ENTER
6. Insert a table on the second page
7. Double click on any table style in the list box in the Styles Panel

Actual Results: 
Table moves to previous page

Expected Results:
Table should stay on page it was on

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords||bisected
 CC||rayk...@gmail.com
 Blocks||103100

--- Comment #4 from Yousuf Philips (jay)  ---
@Jim,
Seems your apply default table style to inserted table patch has a regression.

https://gerrit.libreoffice.org/#/c/46842/


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Jacques Guilleron  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #3 from Jacques Guilleron  ---
Hi Telesto,

I confirm with
LO  6.0.0.2 Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Worked as excepted with
LO 6.0.0.1 (x64) Build ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

Telesto  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #2 from Telesto  ---
@Jay,
Thought you might be interested in this one

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115026

--- Comment #1 from Telesto  ---
Created attachment 139115
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139115=edit
Bibisect log

Bisected to:
author  Jim Raykowski    2017-10-31 15:48:07 -0800
committer   Yousuf Philips   2017-12-27 15:27:50
+0100
commit  203b913155812706e9be14c5fe2b8f543cc4fdc7 (patch)
treee2233e80cbc67d0bf834d4eb716ff935cebe6d08
parent  023949fac0043408ac1b86dc67732666d041875e (diff)
tdf#107555 Apply 'Default Style' table style to newly inserted tables

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs