[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Alex Thurgood  changed:

   What|Removed |Added

 CC||tteck95661.beck...@gmail.co
   ||m

--- Comment #17 from Alex Thurgood  ---
*** Bug 123580 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Alex Thurgood  changed:

   What|Removed |Added

 CC||punky...@grrlz.net

--- Comment #16 from Alex Thurgood  ---
*** Bug 123677 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7872
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

V Stuart Foote  changed:

   What|Removed |Added

 CC||yanekthespecialist56@icloud
   ||.com

--- Comment #15 from V Stuart Foote  ---
*** Bug 122137 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Alex Thurgood  changed:

   What|Removed |Added

 CC||b.huels...@t-online.de

--- Comment #14 from Alex Thurgood  ---
*** Bug 118130 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #13 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8fb4b2548289db4d36a7becd249fef20e7d76b86=libreoffice-6-1

tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."

It will be available in 6.1.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:6.2.0   |target:6.1.0 target:6.2.0
   ||target:6.1.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #12 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1452e73091412ba0bb72306329e1912df2ba513

tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #11 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b42fd7e9516fbbd8a92d97680524f32dd260fb2

tdf#115284: Unify LibreOffice and system full-screen concepts on macOS

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #10 from Tor Lillqvist  ---
Suggested fix in https://gerrit.libreoffice.org/#/c/54760/ . 

The fix still leaves some minor ugliness in the full-screen support. But the
resources (time) available to work on this crack are limited. The alternative
would be to simply not participate in the system full-screen mode at all,
https://gerrit.libreoffice.org/#/c/48796/ . So don't tempt me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #9 from Yousuf Philips (jay)  ---
(In reply to Tor Lillqvist from comment #8)
> How is that different from maximising the window (double-clicking the title
> bar)?

Maximizing by double-clicking the title bar doesnt hide the application dock at
the bottom if its set to always appear and in some apps, maximizing doesnt
extend the left and right sides of the window to extend to the edges of the
screen, if they arent already touching the edges.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #8 from Tor Lillqvist  ---
> So if i get this correctly, you want to implement LO's fullscreen mode but be 
> able to toggle it with OSX fullscreen mode green button and shortcut.

Yes.

> wouldnt users want that same functionality in a fullscreen mode with LO when 
> toggled with the green bubble and not what LO defines as a fullscreen mode

How is that different from maximising the window (double-clicking the title
bar)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #7 from Yousuf Philips (jay)  ---
(In reply to Alex Thurgood from comment #1)
> OK, so my ha'penneth would be rather to enable native OSX fullscreen support
> properly and disable LO's pseudo attempt to do this.

I maybe wrong, but LO already has OSX fullscreen support when you click the
green bubble button in the title bar, though it likely needs work as i see a
black empty bar at the top above the toolbars.

> Either we want an app that behaves like a good citizen of the native macOS
> application world, or we don't, if we decide on not going down that route,
> then we should also make that perfectly clear to end users...

LO having OSX fullscreen support doesnt mean that we cant also have LO
fullscreen support, only that we should likely use a different shortcut for
them, so mac users arent focused.

(In reply to Tor Lillqvist from comment #2)
> Yousuf, Firefox is not necessarily a good application to compare with if you
> want to figure out what the "ideal" native full-screen look is, as it
> is also a cross-platform app that is playing catch-up with Apple's ideas;)
> Better to look at some of Apple's own apps, like Pages, iTunes, Photos.

I had already tested Pages and Safari and its fullscreen support was identical
to Firefox's (simply hide menubar and titlebar), but mentioned Firefox as it is
a cross-platform app like LO, and on windows and linux it has document area
fullscreen support and doesnt have the feature on mac. Tested Chrome just now
and it is similar to Firefox.

(In reply to Tor Lillqvist from comment #4)
> Heiko, that sounds mostly like prejudice. In fact, the Apple guidelines for
> Full-Screen Mode use the same wordings as you do;) So it is just up to the
> application to behave like that in Full-Screen Mode.

So if i get this correctly, you want to implement LO's fullscreen mode but be
able to toggle it with OSX fullscreen mode green button and shortcut.

> If some sample apps
> (even Apple ones) don't (but just expand the UI to fill the screen but
> including all the same GUI), well, that is not the fault of the APIs and
> reason enough to not use the system APIs for full-screen mode.

If apps, even Apple ones, have a OSX fullscreen mode that simply fills the app
on the screen, wouldnt users want that same functionality in a fullscreen mode
with LO when toggled with the green bubble and not what LO defines as a
fullscreen mode?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #6 from Tor Lillqvist  ---
Heiko, so you claim that nobody can ever be confused by these two very
different modes? That everybody will always know that they are separate
concepts, and never accidentally mix them? (Example scenario that leads to a
very confusing situation: Press Cmd+Shift+F which invokes the home-grown
full-screen mode, but then try to get out of that by clicking the green button,
which additionally puts the window in system full-screen mode, then notice the
floating "Full Screen" button, click that.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #5 from Heiko Tietze  ---
(In reply to Tor Lillqvist from comment #4)

I don't see any need for action as you can enable the macOS full screen mode
with the green bubble. Plus, LibreOffice gives you a second way to show the
document with the inbuilt full screen mode. Thus we shouldn't remove one of the
two options as they serve different scenarios.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #4 from Tor Lillqvist  ---
Heiko, that sounds mostly like prejudice. In fact, the Apple guidelines for
Full-Screen Mode use the same wordings as you do;) So it is just up to the
application to behave like that in Full-Screen Mode. If some sample apps (even
Apple ones) don't (but just expand the UI to fill the screen but including all
the same GUI), well, that is not the fault of the APIs and reason enough to not
use the system APIs for full-screen mode.

I quote from
https://developer.apple.com/macos/human-interface-guidelines/app-architecture/fullscreen-mode/
: "An app window in full-screen mode offers a distraction-free working
environment. Toolbars, menus, and other standard controls are often hidden and
revealed only when the user calls for them, such as by moving the pointer to
the top of the screen. Some apps even hide essential controls to increase the
focus on content. The controls are hidden, for example, when playing a movie in
QuickTime Player or a slideshow in Photos."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #3 from Heiko Tietze  ---
I would keep the current implementation as our full screen mode is superior to
what macOS does. It is a distraction free view to the document area without any
toolbar/sidebar controls. The mac full screen just maximizes the window - and
hides the title bar in contrast to other OS. And you can always use both.

The shortcut ctrl+cmd+F is used at Finder and Chrome and some kind of standard,
isn't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #2 from Tor Lillqvist  ---
Yousuf, Firefox is not necessarily a good application to compare with if you
want to figure out what the "ideal" native full-screen look is, as it is
also a cross-platform app that is playing catch-up with Apple's ideas;) Better
to look at some of Apple's own apps, like Pages, iTunes, Photos.

Alex, I agree of course. That's what we should do. Eventually.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #1 from Alex Thurgood  ---
OK, so my ha'penneth would be rather to enable native OSX fullscreen support
properly and disable LO's pseudo attempt to do this.

Either we want an app that behaves like a good citizen of the native macOS
application world, or we don't, if we decide on not going down that route, then
we should also make that perfectly clear to end users...

Setting to new and RFE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs