[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #11 from Jim Raykowski  ---
I can't believe I just committed a patch again without 

1. asking if anyone is working on this patch
2. take (assign) patch to self

I'm going to get the next one right.  

Here is a link to a patch for review
https://gerrit.libreoffice.org/#/c/50551/

Much respect and thanks to all who make this project great and fun!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Heiko Tietze  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---

--- Comment #10 from Heiko Tietze  ---
(In reply to Thomas Lendo from comment #9)
> I'm with Harald in comment 5 that it should work for all object types...
Guess you closed the ticket unintentionally.

After discussing the topic in the design meeting the recommendation is to
implement the feature with low priority (ie. if effort is limited). Users
should be aware that a search is context dependent. But OTOH it works on most
places and wont hurt to include the document text when searching in comments. 

Objects in edit mode are out-of-scope, so the change affects only comments.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #9 from Thomas Lendo  ---
I'm with Harald in comment 5 that it should work for all object types or for
nothing when the cursor is in a comment or in 'normal edit mode' (not during
editing a shape, chart, etc.).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #8 from Jim Raykowski  ---
Hi All, 

This behavior can be changed in the move navigation code by performing the same
function as a keyboard Escape does while in a Comment and then doing the
Navigate By.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #7 from Harald Koester  ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Harald Koester from comment #5)
> > ... For some object
> > types (Graphics, Drawing) the Navigate By function still works and for other
> > types (Table, Bookmark) it does not work.
> 
> It will not work after you "enter" the object, i.e. switch to the edit mode.

I do not really understand what you mean with entering an object. E.g. is this
the case if the cursor is inside a comment? In this case as I said, the
Navigate By function *works* with some object types (Graphics, Drawing) and
does not work with other object types (Table, Bookmark).

In this case the Navigate By function works as expected.
[1] Create a new text document and insert 2 images.
[2] Insert a comment between the 2 images. The cursor is inside the comment.
[3] Display Find toolbar and select Graphics in the Navigate By drop-down menu.
[4] Click "Next graphic" (down arrow). The second image is selected as
expected. The cursor is still in the comment.
[5] Click "Previous graphic" (up arrow). The first image is selected as
expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #6 from Heiko Tietze  ---
(In reply to Harald Koester from comment #5)
> ... For some object
> types (Graphics, Drawing) the Navigate By function still works and for other
> types (Table, Bookmark) it does not work.

It will not work after you "enter" the object, i.e. switch to the edit mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #5 from Harald Koester  ---
Sorry I don't agree. I checked the Navigate By function for some other object
types while the cursor is positioned in the comment. For some object types
(Graphics, Drawing) the Navigate By function still works and for other types
(Table, Bookmark) it does not work. For me this is not consistent, either it
should work for all object types or for no types. And from a users view I would
expect, that the Navigate By function also and always works if the cursor is
positioned in a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC||rayk...@gmail.com,
   ||tietze.he...@gmail.com
 Resolution|--- |NOTABUG

--- Comment #4 from Heiko Tietze  ---
Nothing to add. Same happens when you enter an object such as text in a shape. 

That you expect the behavior from the F toolbar is another question and
results from the mix-up of functions around find with navigational operations.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #3 from BLaACkRose  ---
The table is not selected therefore noting is assigned

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|108743  |115673


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108743
[Bug 108743] [META] Find toolbar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=115673
[Bug 115673] [META] Navigate By toolbar control bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

--- Comment #2 from Kevin Suo  ---
Note that this happens not only for tables, but also for any other objects such
as shapes, images etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Kevin Suo  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||suokunl...@126.com
 Ever confirmed|0   |1

--- Comment #1 from Kevin Suo  ---
Reproduced, but I do not think this is a bug.

When cursor is in the comment, the comment area is active. Since there is no
table inside the comment, noting is found, that is why there is no reaction
when you click the up and down arrow button.

If you put the cursor back to the text area, then find the tables with up and
down arrow buttons work perfect.

Version: 6.0.0.3 (x64)
Build ID：64a0f66915f38c6217de274f0aa8e15618924765
CPU 线程：4; 操作系统：Windows 10.0; UI 渲染：默认; 
区域语言：zh-CN (zh_CN); Calc: group

I mark it as NEW, and added keyword needsUXEval.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115666] “Navigate By” Function does not Work if Cursor is Positioned in Comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115666

Harald Koester  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=79
   ||167
 Blocks||108743


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108743
[Bug 108743] [META] Find toolbar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs