[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

Caolán McNamara  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #21 from Caolán McNamara  ---
Seeing as the error was in extracting the text to translate to get it into
pootle we would have needed to reextract the strings and update the
translations. Which never happened in the 5-4 series, nothing can be done at
this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #20 from Laurent BP  ---
In final 5.4 version: Version: 5.4.7.2
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
Threads CPU : 8; OS : Linux 4.13; UI Render : par défaut; VCL : gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group

no dialog is display at all if UI is not in English.

As 5.4 branch is ended, and there is no bug in 6.0 branch, shall we (sadly) say
WONTFIX?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #19 from Laurent BP  ---
It is NOT fixed in Version: 5.4.7.1
Build ID: ef425abf896c652d17796228d1dbcfe9c7af
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #18 from Xisco Faulí  ---
A polite ping to Caolán McNamara && Laurent BP: is this bug fixed? if so, could
you please close it as RESOLVED FIXED ? Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #17 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-4-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0f36da93f6f58bf5fe8e6390133240e0f0476b55=libreoffice-5-4-6

tdf#115866 comments inside StringArray blocks drop translations

It will be available in 5.4.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||114068, 112521


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112521
[Bug 112521] [META] Message box dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114068
[Bug 114068] [META] Text strings that are not yet possible to localize or dont
appear localized
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #16 from Laurent BP  ---
Created attachment 140392
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140392=edit
Screen shot of dialog mixing German and English text

I can confirm same bug with German UI

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

Caolán McNamara  changed:

   What|Removed |Added

 CC||cl...@documentfoundation.or
   ||g

--- Comment #15 from Caolán McNamara  ---
Presumably because there is no French translation for it. Probably because the
parser error affected the extraction of the original strings that got imported
into pootle to get translated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #14 from Laurent BP  ---
Created attachment 140381
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140381=edit
Screen shot of dialog mixing French and English text

Test with LibO 5.4.6.1
Version: 5.4.6.1 (x64)
Build ID: 7d6c666f03cf1f0a0c2c51a17c0f67a8d5a8012b
Threads CPU : 4; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: group

The "Warning" is correctly translated, but the end of dialog is in English,
instead of French as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #13 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ba9572cb7a5e9e5bde8175e56f9b684919bfd2cb=libreoffice-5-4

tdf#115866 comments inside StringArray blocks drop translations

It will be available in 5.4.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.6|target:5.4.6 target:5.4.7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #12 from Laurent BP  ---
(In reply to Caolán McNamara from comment #8)
> https://gerrit.libreoffice.org/#/c/50329/ should address the missing
> 'Warning'/'Error' piece

Yes, I confirm it fixes the missing first word missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #11 from Caolán McNamara  ---
https://gerrit.libreoffice.org/#/c/50353/1 for me makes make translation find
those missing translations

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #10 from Caolán McNamara  ---
I see from make translations that some of these warnings are not getting into
the .pot, and I also see that if I remove the comments inside the StringArray
blocks that it then works, so it looks like those comments break the older
tooling

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #9 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3d1b49a02744532d637ea398b76b7486e83ea63=libreoffice-5-4

Related: tdf#115866 'Warning' missing

It will be available in 5.4.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #8 from Caolán McNamara  ---
https://gerrit.libreoffice.org/#/c/50329/ should address the missing
'Warning'/'Error' piece

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] ErrCode() Warning strings not translated and "Warning" word missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

Laurent BP  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected
 CC||caol...@redhat.com,
   ||noelgran...@gmail.com
  Component|Calc|UI
Summary|UI Warning for CSV Export   |ErrCode() Warning strings
   |"Only the active sheet was  |not translated and
   |saved" not translated   |"Warning" word missing

--- Comment #7 from Laurent BP  ---
In 6.0 branch, bug is resolved since:
https://cgit.freedesktop.org/libreoffice/core/commit?id=f1a896c71c495bdef5861eb664581507b6b9b5bb
author  Noel Grandin 2017-08-13 08:34:14 +0200
committer   Julien Nabet   2017-08-13 09:42:45
+0200
commit  f1a896c71c495bdef5861eb664581507b6b9b5bb (patch)
*fix some ErrCode IgnoreWarning() usage*

which says that regression was introduced by
author  Noel Grandin  2017-02-09 08:52:13
+0200
committer   Noel Grandin  2017-06-21
08:42:30 +0200
commit  528632660b72b105345945c13c5b68060d94a91b (patch)
*convert ErrCode to strong typedef*

This last commit seems huge and difficult to backport to 5.4 branch.

Add CC to Noel and Caolan
Change Summary to reflect more the root pb
Change component to UI (Calc+Writer)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs