[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #13 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=975a8164e05a437ec8b51a506989b0bd617854b8

Related tdf#116264 trailing newlines used for msgbox padding now harmful

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #12 from Caolán McNamara  ---
The error string itself has trailing newlines which is where the space is
coming from

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #11 from Telesto  ---
Created attachment 140659
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140659=edit
Example file

The proportions for the the locked file dialog is still off; quite a lot of
unused space.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Caolán McNamara  ---
Buttons are now visible and I reduced the border for windows. I have no opinion
on button placement under windows for message dialogs FWIW this page
https://msdn.microsoft.com/en-us/library/windows/desktop/dn742499(v=vs.85).aspx
suggests... "Right-align commit buttons in a single row across the bottom of
the dialog box, but above the footnote area. Do this even if there is a single
commit button (such as OK). ... In this example, the OK button is incorrectly
centered."
while this page...
https://msdn.microsoft.com/en-us/library/windows/desktop/bb246415(v=vs.85).aspx
"On pop-up error messages, center command buttons"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #9 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=775b12866059defdb7ae90f7bffe8720fdaf8340

related: tdf#116264 give windows message dialogs less border width

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #8 from Aron Budea  ---
(In reply to Telesto from comment #7)
> Spaces in a filename are converted to %20. The dialog shows (Attachment
> 140506 [details]): 'Untitled%201.pdf'. I personally would expect 'Untitled
> 01.pdf'. Not sure if this is bug worthy (minor detail)
I agree, please open a bug report on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #7 from Telesto  ---
@Aron (slightly off topic)
Spaces in a filename are converted to %20. The dialog shows (Attachment
140506): 'Untitled%201.pdf'. I personally would expect 'Untitled 01.pdf'. Not
sure if this is bug worthy (minor detail)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #6 from Telesto  ---
Created attachment 140506
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140506=edit
Another example

Another example with a non-native windows look. I would expect it to be more
compact..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #5 from Aron Budea  ---
Created attachment 140490
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140490=edit
Dialog with right-aligned button

I can see the button(s) now, what's a bit strange is that the buttons are
right-aligned in the dialog. And there's more space around them, but maybe
that's fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=21ef6e1157ccaca2916ec124e116fe85c74bb4ec

tdf#116264 Show added_buttons by default

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #3 from Caolán McNamara  ---
strangely I can't seem to reproduce this with the gen backend under Linux.
Maybe this will be solved by https://gerrit.libreoffice.org/#/c/50935/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisected
 CC||caol...@redhat.com
Summary|UI: The error box "Error|UI: No buttons shown in
   |saving the document" with a |dialogs like "Error saving
   |locked file has no OK   |the document" (with a
   |button  |locked file)

--- Comment #2 from Aron Budea  ---
It can't be the previous commit, actually, because it's a different dialog (but
it's affected, too).

For sure the following daily build is still good:
96d551636e9179eb6874a5156b191ef3bff0a10c, 2018-02-27_00:54:40

This daily build is bad:
d5837fcf2b1c60cfe29e2f41f32e22213710a1b8, 2018-02-28_02:16:25

Maybe this commit, then? Caolán, can you please check?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=082e69fefb7439fd4f3d543f0c402039e94c1e9c
author  Caolán McNamara 2018-02-26 16:53:37
+
committer   Caolán McNamara 2018-02-27 11:22:49
+0100

convert various MessBox to weld::MessageDialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs