[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6179

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

Jacques Guilleron  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #12 from Jacques Guilleron  ---
Works with
LO  6.1.0.0.alpha0+ Build ID: dd4f1b1bd31daf080dc0420524712dc244e539b5
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-03-20_23:26:38
Locale: fr-FR (fr_FR); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #11 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=88e22b92bce612f349f8aa38adf69a8806361da3=libreoffice-6-0

tdf#116472: import "auto" border color as black

It will be available in 6.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #10 from Regina Henschel  ---
(In reply to Luke Deller from comment #7)
> Hi Regina, do you have any suggestion on how to represent "automatic" colour
> in ODF?

There exists no way to express "automatic" in XSL-fo or CSS and even CSS3 has
nothing like "automatic". But I would not worry about that. Translating
"automatic" to "black" is fine for borders, because Word itself does not really
use "automatic" but has a black border on nearly black background, even in case
the "automatic" font color is already white.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #9 from Mike Kaganski  ---
(In reply to Luke Deller from comment #6)
> Do you think we might consider backporting these two changes to 6.0 to fix
> tdf#116179?

Of course; we could do that as follow-up for your backport when it lands I
suppose.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #8 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9078fbd14be7c2e4f7c830286cceb0003a345472

tdf#116472: import "auto" border color as black

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #7 from Luke Deller  ---
Hi Regina, do you have any suggestion on how to represent "automatic" colour in
ODF?

When text colour is set to "automatic" in the LibreOffice UI, this is saved to
ODF using the style:use-window-font-color attribute:
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#property-style_use-window-font-color

However we cannot use this for other elements like border colour and table cell
fill patterns.  Does this need an extension?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #6 from Luke Deller  ---
Thanks for looking at this Mike.  I like that your second patch preserves the
behaviour before commit fe6da2feb57c3d5e355a36f6b8ac09b48412ff39 (except with
proper black rather than #0A).  Also there is some precedent for this:

1. The example you found already in the doc (ww8) import filter:
https://gerrit.libreoffice.org/#/c/51518/1/sw/source/filter/ww8/ww8par6.cxx

2. A similar example I came across is for table cell background colour and fill
pattern colour, for which docx "auto" colour is imported as white and black
respectively.  See I preserved this behaviour in my change:
https://gerrit.libreoffice.org/#/c/50995/3/writerfilter/source/dmapper/CellColorHandler.cxx

Do you think we might consider backporting these two changes to 6.0 to fix
tdf#116179?  The alternative of adding proper COL_AUTO support for borders
sounds a bit scarier to backport.

After this though it would be a nice feature to support COL_AUTO for borders
properly, at least for better compatibility with Word documents.  Regarding the
ability to represent this in ODF, let's CC Regina - perhaps we might ask for an
enhancement in the ODF standard, and use an extension in the meantime?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #5 from Mike Kaganski  ---
https://gerrit.libreoffice.org/51519 is the preliminary patch that converts the
"auto" border color to black on import. It lacks a unit test, so WIP; also need
opinions to continue on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #4 from Mike Kaganski  ---
https://gerrit.libreoffice.org/51518 is the tentative patch that would allow
auto color in DOC, correctly handle it in property tab, and use black to show
it. Providing it just in case.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #3 from Mike Kaganski  ---
I started to prepare a patch that would provide black as displayed auto color,
allow auto color to be imported/exported from/to DOC, and also prepare the
relevant property tab for this. But now I suppose that since ODF doesn't
provide for auto border color
(https://www.w3.org/TR/REC-CSS2/box.html#propdef-border mentions simply color;
https://www.w3.org/TR/REC-CSS2/colors.html#propdef-color only defines
w3c-defined color; and
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#datatype-color
defines RGB colors), implementing this would mean that we would have in
interface something not supported by ODF.

In this state, the proper fix IMO would be to just import the auto border color
as black. Opinions?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #2 from Jacques Guilleron  ---
Hi Mike,

I reproduce with
LO  6.1.0.0.alpha0+ Build ID: 8038911866f54f3921f51a2a1e702831c42f02fd
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-03-17_23:12:09
Locale: fr-FR (fr_FR); Calc: CL
but not with
LO  6.1.0.0.alpha0+ Build ID: 0d1479cbd442c3ec3bdd20333c341ea24dcca21e
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-03-10_01:47:26
Locale: fr-FR (fr_FR); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116472] IMPORT: Page border is invisible in specific DOCX ( border color=auto)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116472

--- Comment #1 from Mike Kaganski  ---
Created attachment 140688
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140688=edit
A file with borders having w:color=auto

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs