[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Xisco Faulí  ---
Verified in

Version: 6.5.0.0.alpha0+
Build ID: ea97f0926e138712c3800f5274012f0f04fc1c47
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Franklin Weng, thanks for fixing this issue. I believe we can close it as
VERIFIED FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #13 from Xisco Faulí  ---
Created attachment 156266
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156266=edit
Verified in LibreOffice 6.5 master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #12 from Xisco Faulí  ---
A polite ping to Franklin Weng:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #11 from Commit Notification 
 ---
Franklin Weng committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/648990692c8253e3843c4c5954940e8b893d5f3e%5E%21

tdf#116862 do not encrypt to self when encryption key is not set

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #10 from Franklin Weng  ---

It works when
1) encryption key is set in the personal profile, or 
2) "When encrypting documents, always encrypt to self" is unchecked, which is
checked by default.

I think it makes sense that when sending a GPG-encrypted document the author
should encrypt it with his/her own key, or when it is saved encrypted the
author can not read it anymore.  Just that when the encrypt-to-self checkbox is
set but no encryption key is set, there should be a warning or error message
instead of jumping out the current error messages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #9 from Franklin Weng  ---
(In reply to Thorsten Behrens (CIB) from comment #4)
> Created attachment 142533 [details]
> Hack-around patch - of course we cannot simply trust all keys...
> 
> With the attached patch, it works again. No real solution though

I tried to debug it and have some interesting findings.

https://pastebin.com/ucpjLg4D

in comphelper/source/misc/storagehelper.cxx:496
xSignCertificates.getLength() is 2 though I chose only one recipient. (line 5
in pastebin)

Then I checked keyID at code line 509, after key is pushed back to vector (line
37 in pastebin)
The key is correct (my public key).

In the first iteration the result is correct.  Then goes to the second
iteration (since xSignCertificates.getLength() is 2)

I checked the key in the second iteration (line 119 in pastebin) this time it
returned another keyID (Osvaldo's public key!?)

This time crypt_res.error() returned code 53 and len was 0, so threw exception.

I have not checked why xSignCertificates.getLength() is 2 yet.  Maybe someone
would be interested in it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #8 from Franklin Weng  ---
Still reproducible in

版本：6.3.0.4
組建 ID：057fc023c990d676a43019934386b85b21a9ee99
CPU 執行緒：4; OS：Linux 4.19; UI 算繪：預設; VCL: kde5; 
語言地區：zh-TW (zh_TW.UTF-8); UI-Language: zh-TW
Calc: threaded

Signing is okay, but encrypting would fail.

Nothing different for encrypting public keys being signed or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||34694


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34694
[Bug 34694] [META] Improve usability of error messages
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #7 from Thorsten Behrens (CIB)  ---
Xisco, does signing the key help you're picking? With something != ultimate
trust?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #6 from Xisco Faulí  ---
gpg (GnuPG) 2.1.11
libgcrypt 1.6.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #5 from Xisco Faulí  ---
gpg (GnuPG) 1.4.20

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #4 from Thorsten Behrens (CIB)  ---
Created attachment 142533
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142533=edit
Hack-around patch - of course we cannot simply trust all keys...

With the attached patch, it works again. No real solution though

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #3 from Thorsten Behrens (CIB)  ---
Marina, Xisco - can you paste your respective gpg versions please?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

--- Comment #2 from Thorsten Behrens (CIB)  ---
Same here, but it's even worse - can't even use my own keys to encrypt.
Happened after upgrade to gpg2:

gpg (GnuPG) 2.2.7-unknown
libgcrypt 1.7.9

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||t...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116862] GPG: Unclear error message when the OwnerTrust is different than ultimate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116862

Xisco Faulí  changed:

   What|Removed |Added

 CC||bu...@bubli.org,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Hi bubli, this is the issue found during the hackfest, in case you're
interested...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs