[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 Armin Le Grand (CIB) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |armin.le.gr...@me.com |desktop.org | Status|NEW |ASSIGNED --- Comment #10 from Armin Le Grand (CIB) --- @Miklos: okay, added https://gerrit.libreoffice.org/#/c/57319/ Any comments...? People to add...? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 Xisco Faulí changed: What|Removed |Added Crash report or||["std::deque ||>,std::allocator > > ||>::push_back(std::unique_pt ||r > &&)"] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 --- Comment #9 from Armin Le Grand (CIB) --- @Miklos: All correct - except me being a specialist for VCL ;-) Todo for tomorrow... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 --- Comment #8 from Miklos Vajna --- Armin, I'm afraid others already consider you an expert in vcl topics. ;-) What about just asking on the dev mailing list, which has more subscribers than this bug? Best if you push your proof of concept patch to gerrit, so there is something concrete to discuss. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 Armin Le Grand (CIB) changed: What|Removed |Added CC||vmik...@collabora.co.uk --- Comment #7 from Armin Le Grand (CIB) --- Second solution works too (adding mpControlData->mpReferenceDevice->isDisposed() ? _rTargetDevice : *mpControlData->mpReferenceDevice as 2nd parameter to ControlTextRenderer contructor. But at every repaint this gets repeated and the mpControlData->mpReferenceDevice stays disposed - also after dialog is closed... -> We somehow have a living Control with disposed mpControlData->mpReferenceDevice. I do not know enough abou the current Window implementation to say if this is okay or very bad. @Miklos: Do you have an idea who might nowadays know enough about Windows/Control vcl stuff to take a look at this one...? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 --- Comment #6 from Armin Le Grand (CIB) --- One working solution is to add mpControlData->mpReferenceDevice->isDisposed() to Control::DrawControlText last 'if' to avoid a ControlTextRenderer being constructed. I will also try to construct a ControlTextRenderer by using _rTargetDevice if mpReferenceDevice is disposed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377
--- Comment #5 from Armin Le Grand (CIB) ---
mpOutDevStateStack is a std::unique_ptr and gets initialized
in OutputDevice::OutputDevice (mpOutDevStateStack.reset(new OutDevStateStack)).
It only gets reset (mpOutDevStateStack.reset()) in OutputDevice::dispose(),
thus I guess this must happen somehow.
When breaking in Control::DrawControlText at the end where ControlTextRenderer
gets constructed, mpControlData->mpReferenceDevice has a device, but it's
VclReferenceBase says indeed -> {mnRefCnt=2 mbDisposed=true }.
That mpControlData->mpReferenceDevice comes from Control directly, so that may
also be disposed already. Question is if this can be detected? There is already
Control::ImplCallEventListenersAndHandler where xThis->IsDisposed() is used
with 'VclPtr xThis(this)' (whyever).
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 --- Comment #4 from Armin Le Grand (CIB) --- Stack says: vcllo.dll!std::_Container_base12::_Orphan_all() Line 217 (c:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xutility:217) vcllo.dll!std::_Deque_alloc >,std::allocator > > > >::_Orphan_all() Line 877 (c:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\deque:877) vcllo.dll!std::deque >,std::allocator > > >::push_back(std::unique_ptr > && _Val) Line 1160 (c:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\deque:1160) vcllo.dll!OutDevStateStack::push_back(OutDevState * p) Line 25 (c:\lo\work01\vcl\source\outdev\outdevstatestack.cxx:25) vcllo.dll!OutputDevice::Push(PushFlags nFlags) Line 117 (c:\lo\work01\vcl\source\outdev\outdevstate.cxx:117) vcllo.dll!vcl::ReferenceDeviceTextLayout::ReferenceDeviceTextLayout(const Control & _rControl, OutputDevice & _rTargetDevice, OutputDevice & _rReferenceDevice) Line 140 (c:\lo\work01\vcl\source\gdi\textlayout.cxx:140) vcllo.dll!vcl::ControlTextRenderer::ControlTextRenderer(const Control & _rControl, OutputDevice & _rTargetDevice, OutputDevice & _rReferenceDevice) Line 336 (c:\lo\work01\vcl\source\gdi\textlayout.cxx:336) vcllo.dll!Control::DrawControlText(OutputDevice & _rTargetDevice, const tools::Rectangle & rRect, const rtl::OUString & _rStr, DrawTextFlags _nStyle, std::vector > * _pVector, rtl::OUString * _pDisplayText, const Size * i_pDeviceSize) Line 436 (c:\lo\work01\vcl\source\control\ctrl.cxx:436) vcllo.dll!Button::ImplDrawAlignedImage(OutputDevice * pDev, Point & rPos, Size & rSize, unsigned long nImageSep, DrawFlags nDrawFlags, DrawTextFlags nTextStyle, tools::Rectangle * pSymbolRect, bool bAddImageSep) Line 271 (c:\lo\work01\vcl\source\control\button.cxx:271) vcllo.dll!RadioButton::ImplDraw(OutputDevice * pDev, DrawFlags nDrawFlags, const Point & rPos, const Size & rSize, const Size & rImageSize, tools::Rectangle & rStateRect, tools::Rectangle & rMouseRect) Line 2066 (c:\lo\work01\vcl\source\control\button.cxx:2066) vcllo.dll!RadioButton::ImplDrawRadioButton(OutputDevice & rRenderContext) Line 2165 (c:\lo\work01\vcl\source\control\button.cxx:2165) vcllo.dll!RadioButton::Paint(OutputDevice & rRenderContext, const tools::Rectangle & __formal) Line 2427 (c:\lo\work01\vcl\source\control\button.cxx:2427) vcllo.dll!vcl::Window::ImplPaintToDevice(OutputDevice * i_pTargetOutDev, const Point & i_rPos) Line 1448 (c:\lo\work01\vcl\source\window\paint.cxx:1448) vcllo.dll!vcl::Window::PaintToDevice(OutputDevice * pDev, const Point & rPos, const Size & __formal) Line 1521 (c:\lo\work01\vcl\source\window\paint.cxx:1521) tklo.dll!VCLXWindow::draw(long nX, long nY) Line 2333 (c:\lo\work01\toolkit\source\awt\vclxwindow.cxx:2333) tklo.dll!UnoControl::draw(long x, long y) Line 1014 (c:\lo\work01\toolkit\source\controls\unocontrol.cxx:1014) drawinglayerlo.dll!drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(const drawinglayer::primitive2d::BasePrimitive2D & rCandidate) Line 672 (c:\lo\work01\drawinglayer\source\processor2d\vclpixelprocessor2d.cxx:672) drawinglayerlo.dll!drawinglayer::processor2d::BaseProcessor2D::process(const drawinglayer::primitive2d::Primitive2DContainer & rSource) Line 72 (c:\lo\work01\drawinglayer\source\processor2d\baseprocessor2d.cxx:72) drawinglayerlo.dll!drawinglayer::processor2d::BaseProcessor2D::process(const drawinglayer::primitive2d::BasePrimitive2D & rCandidate) Line 49 (c:\lo\work01\drawinglayer\source\processor2d\baseprocessor2d.cxx:49) drawinglayerlo.dll!drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(const drawinglayer::primitive2d::BasePrimitive2D & rCandidate) Line 913 (c:\lo\work01\drawinglayer\source\processor2d\vclpixelprocessor2d.cxx:913) Rendering of a RadioButton (probably unrelated to my changes, but you never know). Fact is that in OutputDevice::Push the mpOutDevStateStack is 'empty' -> mpOutDevStateStack->push_back( pState ) crashes. I have no idea what mpOutDevStateStack is or how it is managed. Taking a look... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Created attachment 143227 --> https://bugs.documentfoundation.org/attachment.cgi?id=143227=edit Valgrind trace On pc Debian x86-64 with master sources updated yesterday, it crashes my whole laptop. I could retrieve some info by using valgrind. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 Xisco Faulí changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 --- Comment #2 from Xisco Faulí --- Created attachment 143109 --> https://bugs.documentfoundation.org/attachment.cgi?id=143109=edit gdb backtrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section
https://bugs.documentfoundation.org/show_bug.cgi?id=118377 Xisco Faulí changed: What|Removed |Added Severity|normal |critical Blocks||116979 CC||armin.le.gr...@me.com, ||xiscofa...@libreoffice.org Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Priority|medium |highest --- Comment #1 from Xisco Faulí --- Regression introduced by: author Armin Le Grand 2018-03-01 15:54:32 +0100 committer Armin Le Grand 2018-04-06 22:29:02 +0200 commit 6c14c27c75a03e2363f2b363ddf0a6f2f46cfa91 (patch) treee66f50adb222dbc1490b4df2d3c63541dad999ac parent e1b247a843c5eb850fe0079819239d9883412d38 (diff) SOSAW080: Added first bunch of basic changes to helpers Bisected with: bibisect-linux64-6.1 Adding Cc: to Armin Le Grand Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116979 [Bug 116979] [META] Regression introduced by Aw080 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
