[Libreoffice-bugs] [Bug 118621] Optionally disable floating header/footer menu
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 Heiko Tietze changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |tietze.he...@gmail.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] Optionally disable floating header/footer menu
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 --- Comment #11 from Mike Kaganski --- (In reply to Heiko Tietze from comment #10) Sigh, I'd prefer to not solve easy hacks for "newbies", because - well, easy hack is expected to allow a newcomer to do something not too dull, and at the same time not too difficult, but... The top of call stack at the breakpoint: > swlo.dll!SwHeaderFooterWin::SwHeaderFooterWin(SwEditWin * pEditWin, const > SwFrame * pFrame, bool bHeader) Line 138 > at c:\lo\src\core\sw\source\uibase\docvw\headerfooterwin.cxx(138) > swlo.dll!VclPtr::Create &,SwPageFrame > const * &,bool const &>(VclPtr & , const SwPageFrame * & > , const bool & ) Line 135 > at c:\lo\src\core\include\vcl\vclptr.hxx(135) > swlo.dll!SwFrameControlsManager::SetHeaderFooterControl(const SwPageFrame * > pPageFrame, FrameControlType eType, Point aOffset) Line 107 > at c:\lo\src\core\sw\source\uibase\docvw\framecontrolsmanager.cxx(107) > swlo.dll!SwPageFrame::PaintDecorators() Line 3679 > at c:\lo\src\core\sw\source\core\layout\paintfrm.cxx(3679) > swlo.dll!SwRootFrame::PaintSwFrame(OutputDevice & rRenderContext, const > SwRect & rRect, const SwPrintData * const pPrintData) Line 3191 > at c:\lo\src\core\sw\source\core\layout\paintfrm.cxx(3191) > ... Of course, there's no reason to change something below SwRootFrame::PaintSwFrame, because this method is generic enough (it isn't specific to creation of the controls, but paints the whole frame, as its name suggests). None of its callers would have good knowledge whether (or how) to create those controls. SwRootFrame::PaintSwFrame itself doesn't directly create those controls, but calls SwPageFrame::PaintDecorators, which does many other kinds of things - so no reason to place the check in SwRootFrame::PaintSwFrame, too: too far from the actual place of controls creation. The latter (SwPageFrame::PaintDecorators) calls SwFrameControlsManager::SetHeaderFooterControl, which is specifically created to do what we want to manage. So - it's natural to think the two places for performing the check: either in places where SwFrameControlsManager::SetHeaderFooterControl is called (grepping for "SetHeaderFooterControl" gives only two such places, both in the same function) - so just calling it conditionally; or inside SwFrameControlsManager::SetHeaderFooterControl, doing the check and exiting early. These two options are both acceptable, and a newbie could propose a change with any of them (and then we'd discuss pros and contras in the gerrit change)... just telling "I can't" and me writing all this means spoiling the whole easy hack, effectively because me doing all that the newcomer was expected to do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] Optionally disable floating header/footer menu
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 --- Comment #10 from Heiko Tietze --- (In reply to Mike Kaganski from comment #9) > It *is* an easy hack. Starting from the place mentioned by Stuart (putting a > breakpoint there), one can easily see the call stack, and find a suitable > place to put a check for a config setting. That's the simple part but there is no good place for on/off. At least I cannot see a simple solution. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] Optionally disable floating header/footer menu
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 --- Comment #9 from Mike Kaganski --- (In reply to Heiko Tietze from comment #7) > Without Stuart's comment I'd say it's an easy hack but apparently it isn't. It *is* an easy hack. Starting from the place mentioned by Stuart (putting a breakpoint there), one can easily see the call stack, and find a suitable place to put a check for a config setting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] Optionally disable floating header/footer menu
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 --- Comment #8 from Christoph Bartz --- I would be very grateful for this! A [x]-option in Tools > Options > Writer > View > View would be very nice. A hidden option in Tools > Options > LibreOffice > Advanced > Expert Configuration also would suffice. In any case – Thank You! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] Optionally disable floating header/footer menu
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 Heiko Tietze changed: What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- Summary|UI: Request for |Optionally disable floating |Enhancement: Turn off |header/footer menu |Footer/Header Menu. | --- Comment #7 from Heiko Tietze --- Okay, too many options aren't a solution in general (if not "hidden" in the advanced registry) but in that case we could add "[x] Show floating header/footer menu" at Tools > Options > Writer > View > View (defaulting to on). Let's see if a dev is interested in it. Without Stuart's comment I'd say it's an easy hack but apparently it isn't. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
