[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #14 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-1-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e013eab178df3a27fe036230c80611dd1dccc7d=libreoffice-6-1-0 tdf#118716 Inner border of an embedded table can't be dragged around It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.1 |target:6.2.0 target:6.1.1 ||target:6.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #13 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=af7b9609fee603756f8cb0668ae45af37c5fb4fb=libreoffice-6-1 tdf#118716 Inner border of an embedded table can't be dragged around It will be available in 6.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0|target:6.2.0 target:6.1.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #12 from Telesto --- Many thanks for fixing this! And more in general for all the useuniqueptr work :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #11 from Xisco Faulí --- Verified in Version: 6.2.0.0.alpha0+ Build ID: dcbb65f2a4a3ee70ccd4896d7a5e975dbd9e6509 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded @Noel, Thanks for fixing this!!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #10 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c13865a4caf7898c4e59a5b22bbd493d6dad9661 tdf#118716 Inner border of an embedded table can't be dragged around It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #9 from Xisco Faulí --- Hi Noel, Thanks for the nice clarification. In your initial commit, I see 3 or 4 places where static_cast was converted to std::max< sal_uInt16 >, should they be reverted just in case as well? Would you mind providing a fix for this issue, or should I do it ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #8 from Noel Grandin --- Xisco, your change is correct, my patch was inadvisable. In this code int a; std::max(a,0) std::max will first convert a and b to sal_uInt16, therefore potentially converting a negative number to a positive number due to the conversion rules. Then it will take the larger number. While this code int a; static_cast(a > 0 ? a : 0) will compare first, and then convert the larger number to sal_uInt16, which might result in making a "a" that is larger than 2^16 into a smaller value, but which will never convert a negative "a" value into a positive value. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #7 from Xisco Faulí --- Hi Noel, This reversion fixes the issue: --- a/sw/source/uibase/uiview/viewtab.cxx +++ b/sw/source/uibase/uiview/viewtab.cxx @@ -1699,9 +1699,8 @@ void SwView::StateTabWin(SfxItemSet& rSet) const int nLft = aTabCols.GetLeftMin() + aTabCols.GetLeft(); const int nRgt = (bTableVertical ? nPageHeight : nPageWidth) - (aTabCols.GetLeftMin() + aTabCols.GetRight()); - -const sal_uInt16 nL = std::max< sal_uInt16 >(nLft, 0); -const sal_uInt16 nR = std::max< sal_uInt16 >(nRgt, 0); +const sal_uInt16 nL = static_cast< sal_uInt16 >(nLft > 0 ? nLft : 0); +const sal_uInt16 nR = static_cast< sal_uInt16 >(nRgt > 0 ? nRgt : 0); SvxColumnItem aColItem(nNum, nL, nR); However, your change seems correct... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #6 from Xisco Faulí --- Created attachment 143625 --> https://bugs.documentfoundation.org/attachment.cgi?id=143625=edit Screencast for clarification -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Xisco Faulí changed: What|Removed |Added CC||noelgran...@gmail.com, ||xiscofa...@libreoffice.org Status|UNCONFIRMED |NEW Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 --- Comment #5 from Xisco Faulí --- Reproduced in Version: 6.2.0.0.alpha0+ Build ID: 95b00f1bfa341003af23e150d316d943d47909cf CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded I also confirmed it's a regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=f14b9d30293f180500fc56d81e5390021758e7c1 Adding Cc: to Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Telesto changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #4 from Telesto --- @Dieter Could you verify this one. It's blocking me from using LibO6.1 ;-). It does happen quite often in daily usage (this report is mere an illustration) Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8715 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #3 from Telesto --- Created attachment 143534 --> https://bugs.documentfoundation.org/attachment.cgi?id=143534=edit Bibisect log Bisected to author Noel Grandin 2018-01-08 17:01:49 +0200 committer Noel Grandin 2018-01-11 07:35:43 +0100 commit f14b9d30293f180500fc56d81e5390021758e7c1 (patch) treea6cd0b853169203cfa0953230e6774e7b1dd81b4 parent d11120b95ee27cb4b05db466ed07f7a996dda125 (diff) convert (a>b?a:b) to std::max(a,b) with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #2 from Telesto --- Created attachment 143513 --> https://bugs.documentfoundation.org/attachment.cgi?id=143513=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118716] Inner border of an embedded table can't be dragged around
https://bugs.documentfoundation.org/show_bug.cgi?id=118716 --- Comment #1 from Telesto --- No repro with Version: 6.0.0.1.0+ Build ID: 47cc374c0659fd3db74a1b184c870eaa56bc385b CPU threads: 4; OS: Windows 6.3; UI render: GL; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
