[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Xisco Faulí  changed:

   What|Removed |Added

 CC||bugzilla@mkr.email

--- Comment #21 from Xisco Faulí  ---
*** Bug 119006 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #20 from Xisco Faulí  ---
Verified in

Version: 6.2.0.0.alpha0+
Build ID: aa84f1458f422c1acf38b53a3e3138cd0e84e313
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

The option is disabled now.

@bubli, @mst, Thanks for fixing this!!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #19 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-6-1-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e01c0d3d64331cfc91e3d7c2cff69e44bade4e32=libreoffice-6-1-0

tdf#118777: Disable signature line slot if non-text object

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #18 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-1-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=63543c44f2ce1af3b8a1cb350f9d03bc75a54f7d=libreoffice-6-1-0

tdf#118777 cui: use right XText in SignatureLineDialog

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0 target:6.1.1   |target:6.2.0 target:6.1.1
   ||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #17 from Xisco Faulí  ---
(In reply to Michael Stahl from comment #16)
> should be fixed now

Thanks!
should it be cherry-picked to libreoffice-6-1-0 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Michael Stahl  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #16 from Michael Stahl  ---
should be fixed now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #15 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a4f07b367284e898898b1840fc22f357099aba9=libreoffice-6-1

tdf#118777 cui: use right XText in SignatureLineDialog

It will be available in 6.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0|target:6.2.0 target:6.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #14 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=545ddabc6614e751c807e9d1e1cbf7c617fc4141=libreoffice-6-1

tdf#118777: Disable signature line slot if non-text object

It will be available in 6.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #13 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a00e1f98d4cca448c1394e2504cc7539cb9ac1d

tdf#118777: Disable signature line slot if non-text object

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #12 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7213a583f5c1d42c05dc4f19b4d4d2f9dded7733

tdf#118777 cui: use right XText in SignatureLineDialog

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #11 from Xisco Faulí  ---
> the Signature Line dialog is implemented in cui and uses the API, hence i
> don't see any way to fix this except for simply disabling the menu item when
> image shape is selected, similar to the other disabled items.

it sounds like a good solution to me...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #10 from Michael Stahl  ---
this is all a bit inconsistent and non-obivous:

if an image or shape is selected, then the view cursor doesn't have a valid
model position, and most of the Insert menu entries are disabled.

except for:

- Insert Image ... which replaces the existing image (if image selected), or
applies the image as background to existing shape

- Insert Shape ... which requires mouse interaction and will anchor the shape
close to the drawn rectangle, via GetCrsrOfst

- Insert Fontwork ... which anchors the shape close to the center of the
docuemnt view, via GetCrsrOfst

The SwXViewCursor has a method to get the view position as x/y coordinates via:

offapi/com/sun/star/text/XTextViewCursor.idl:com::sun::star::awt::Point
getPosition();

... but there appears to be no way to convert that to a model (text cursor)
position via the API, which is surprising, i.e. there is no API equivalent to
GetCursorOfst.

the Signature Line dialog is implemented in cui and uses the API, hence i don't
see any way to fix this except for simply disabling the menu item when image
shape is selected, similar to the other disabled items.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #9 from Katarina Behrens (CIB)  ---
(In reply to Thorsten Behrens (CIB) from comment #8)
> Bubli, Michael - any quick remedy?

Nay, no immediate idea. It happens every time a non-text object is selected and
I know very little of Writer UNO API to say why is this happening. In
unotext.cxx:

if (pOwnStartNode != pTmp)
{
uno::RuntimeException aRunException;
aRunException.Message = "text interface and cursor not related";
throw aRunException;
}

What is expected to happen in such case anyway, should the signature line be
inserted after the selected object, or should it replace the object?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

 CC||bu...@bubli.org,
   ||michael.st...@cib.de

--- Comment #8 from Thorsten Behrens (CIB)  ---
Bubli, Michael - any quick remedy?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #7 from Julien Nabet  ---
(In reply to Xisco Faulí from comment #6)
> ...
> I get the error: 'text interface and cursor not related'

The only location where this message is put is here:
https://opengrok.libreoffice.org/xref/core/sw/source/core/unocore/unotext.cxx#573

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #6 from Xisco Faulí  ---
In

Versión: 6.1.0.2
Id. de compilación: b3972dcf1284967612d5ee04fea9d15bcf0cc106
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group threaded


I get the error: 'text interface and cursor not related'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated 2 days ago, I could reproduce
this.

I noticed this log:
warn:vcl:22563:22563:vcl/source/app/salusereventlist.cxx:114: Uncaught
com.sun.star.uno.RuntimeException text interface and cursor not related

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Xisco Faulí  changed:

   What|Removed |Added

   Severity|major   |critical
 CC||t...@libreoffice.org
   Priority|high|highest

--- Comment #4 from Xisco Faulí  ---
Increasing severity as the patch has been cherry-picked to 6.1 ->
https://gerrit.libreoffice.org/#/c/57035/4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Priority|medium  |high
 CC||s.mehrbr...@gmail.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression
   Severity|normal  |major

--- Comment #3 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8905ae9f0fc8b0e4a95113fd81e88d4e7db57bcc

author  Samuel Mehrbrodt   2018-07-05 21:48:49
+0200
committer   Samuel Mehrbrodt   2018-07-06
07:44:16 +0200
commit  8905ae9f0fc8b0e4a95113fd81e88d4e7db57bcc (patch)
tree99b2561abcb835e0851b7063dee9d0a3338b996c
parent  3aa4edb1028bfafff38efda8843f8ebe43a38155 (diff)
Writer: Insert signature line at current cursor position

Bisected with: bibisect-linux64-6.2

Adding Cc: to Samuel Mehrbrodt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
I tried to reproduce it with an image and with an object (like in the
attachment), but I couldn't reproduce it.

Version: 6.2.0.0.alpha0+ (x64)
Build ID: b0e291a7efcd3af2a72d0b622b1f1b84723f011f
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-06-30_23:43:40
Locale: en-US (de_DE); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118777] [Crash] Insert Signature Line after select image object

2018-07-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118777

--- Comment #1 from sawakaze  ---
Created attachment 143566
  --> https://bugs.documentfoundation.org/attachment.cgi?id=143566=edit
screen capture

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs