[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #14 from Julien Nabet --- I submitted the main patch for master sources here: https://gerrit.libreoffice.org/#/c/78302/ If Jenkins doesn't complain, I'll push it (unless someone requires some changes) and cherry-pick for 6.3 branch. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #13 from Julien Nabet --- (In reply to Lionel Elie Mamane from comment #12) >... > In my understanding, this is the version of the _driver_, that is of the > sdbc-firebird code, the code in connectivity/source/firebirc. We should > increment it when we change the driver... Or we could just return the > LibreOffice version, considering that the driver is just part of LibreOffice > and has the same versioning. > > The other drivers in connectivity/source don't really do this correctly > either. I don't know about LO/Basic/Uno vars but LO version should be a global kind of global var. About sdbc, it's just a wrapper of libs in most of cases (all?), I would have thought that lib used should correspond more to what we expect for driver version. Since I'm not sure, I won't touch getDriverMajorVersion/getDriverMinorVersion for the moment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809
--- Comment #12 from Lionel Elie Mamane ---
(In reply to Julien Nabet from comment #11)
> Shouldn't we put:
> sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion( )
> {
> return 3;
> }
>
> sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion( )
> {
> return 0;
> }
In my understanding, this is the version of the _driver_, that is of the
sdbc-firebird code, the code in connectivity/source/firebirc. We should
increment it when we change the driver... Or we could just return the
LibreOffice version, considering that the driver is just part of LibreOffice
and has the same versioning.
The other drivers in connectivity/source don't really do this correctly either.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809
--- Comment #11 from Julien Nabet ---
After my day time job, I'll submit a main patch with 2 suggestions:
"Firebird (engine12)" for getDatabaseProductName
result of "SELECT rdb$get_context('SYSTEM', 'ENGINE_VERSION') as version from
rdb$database" for getDatabaseProductVersion
In a second patch, I'll put
- NumericFunctions
- StringFunctions
- TimeDateFunctions
as suggested
For driver version and name, I thought about lib used by LO.
In master we still use Firebird 3.0.0 (see
https://opengrok.libreoffice.org/xref/core/download.lst?r=df2b4a9d#48)
So I'd put:
for getDriverMajorVersion
// Retrieve version from download.lst
return OUString("3.0.0");
for getDriverName:
// Retrieve name from download.lst
Firebird-3.0.0.32483-0.tar.bz2
Also I noticed this:
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion( )
{
return 1;
}
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion( )
{
return 0;
}
See
https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx?r=1729f554#614
Shouldn't we put:
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion( )
{
return 3;
}
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion( )
{
return 0;
}
Any thoughts?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #10 from Alex Thurgood --- Confirming indeed that there has been no change in this bug status with Version: 6.3.0.4 Build ID: 057fc023c990d676a43019934386b85b21a9ee99 Threads CPU : 8; OS : Mac OS X 10.14.6; UI Render : par défaut; VCL: osx; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded Bug is still present (but unsurprising, seeing as no commits have changed what DatabaseMetaData.cxx does here). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #9 from Peter Nowee --- Not IsNull in Basic, I mean. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #8 from Peter Nowee --- Still confirmed with: Version: 6.3.0.4 Build ID: 1:6.3.0-2~bpo10+1 CPU threads: 2; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded To be exact, they return empty strings, not Null. Same with getDriverName and getDriverVersion, by the way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #7 from QA Administrators --- Dear Drew Jensen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 Xisco Faulí changed: What|Removed |Added Blocks||51780 CC||xiscofa...@libreoffice.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=51780 [Bug 51780] [META] Default to Firebird not HSQLDB in Base (for _new_ files) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #6 from Alex Thurgood --- Also confirmed with: Version: 6.2.0.0.alpha0+ Build ID: 36e1f6ebf0c74b4b90bbf1aab8d9ab69b8746f3a CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 Alex Thurgood changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Alex Thurgood --- Confirming with: Version: 6.1.1.0.0+ Build ID: 7a94069af971b9326e017d93b78118201291c48d CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; TinderBox: MacOSX-x86_64@49-TDF, Branch:libreoffice-6-1, Time: 2018-08-04_20:34:42 Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809
--- Comment #4 from Drew Jensen ---
Could I tag on a few additional items for the MetaData:
NumericFunctions
return
OUString("ABS,ACOS,ASIN,ATAN,ATAN2,BIN_AND,BIN_NOT,BIN_OR,BIN_SHL,BIN_SHR,BIN_XOR,CEIL,CEILING,COS,COSH,COT,EXP,FLOOR,LN,LOG,LOG10,MOD,PI,POWER,RAND,ROUND,SIGN,SIN,SINH,SQRT,TAN,TANH,TRUNC")
StringFunctions
return
OUString("ASCII_CHAR,ASCII_VAL,BIT_LENGTH,CHAR_LENGTH,CHAR_TO_UUID,CHARACTER_LENGTH,GEN_UUID,HASH,LEFT,LOWER,LPAD,OCTET_LENGTH,OVERLAY,POSITION,REPLACE,REVERSE,RIGHT,RPAD,SUBSTRING,TRIM,UPPER,UUID_TO_CHAR")
TimeDateFunctions
retun OUString("CURRENT_DATE,CURRENT_TIME,CURRENT_TIMESTAMP,DATEADD,
DATEDIFF,EXTRACT,'NOW','TODAY','TOMORROW','YESTERDAY'")
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809
--- Comment #3 from Drew Jensen ---
(In reply to Julien Nabet from comment #2)
> Drew: we currently use Firebird 3.0.0
> Now version retrieved must work with embedded Firebird and not embedded
> Firebird.
My .02 worth:
(Hopefully if I have any details wrong someone will correct me.)
Both the Base embedded Firebird and Base file Firebird use the Firebird
embedded engine, which in the Firebird server configuration is referred to as
an 'engine12' connection when configuring access to managed files. Server
managed .fdb files can be configured to accept 'engine12' connections or reject
them.
It could make sense then to return a string of 'Firebird (engine12)' for the
DatabaseProductName property as it would be the most precise and would be
accurate for both scenarios of an embedded database file and an external
database file using the firebird sdbc driver.
If a user is connecting to a Firebird server with a jdbc or odbc driver the
server would see that connection as 'remote' or 'loopback', using tcp/ip or or
wnet or whathaveyou, for a file on the local machine or remote machine.
Having 'engine12' in the sdbc designation could help if someone tries to create
a Base odc and pointed to a managed .fdb file only to be refused connection
attempts.
> For last one, obviously, we can't use a fixed string to display the version.
> For first case, should we display the built Firebird version in LO or the
> Firebird version corresponding to the moment we created the file?
The version number could be retrieved at runtime by executing
SELECT rdb$get_context('SYSTEM', 'ENGINE_VERSION')
as version from rdb$database;
currently (6.0, 6.1, 6.2) Base sdbc connections return 3.0.0. If the binaries
for the Firebird engine going forward are updated that should reflect any
change.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 Julien Nabet changed: What|Removed |Added CC||btom...@gmail.com, ||lio...@mamane.lu, ||rob...@familiegrosskopf.de, ||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- Drew: we currently use Firebird 3.0.0 Now version retrieved must work with embedded Firebird and not embedded Firebird. For last one, obviously, we can't use a fixed string to display the version. For first case, should we display the built Firebird version in LO or the Firebird version corresponding to the moment we created the file? Code pointers: - https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx#599 - https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx#604 For getDatabaseProductName(), could we indicate "Firebird" or should we distinguish if embedded version or not? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 Drew Jensen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8767 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #1 from Drew Jensen --- Created attachment 143602 --> https://bugs.documentfoundation.org/attachment.cgi?id=143602=edit newFBDoc odb -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
